From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81928C433DB for ; Thu, 28 Jan 2021 01:27:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D76B64DD1 for ; Thu, 28 Jan 2021 01:27:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231171AbhA1B1w (ORCPT ); Wed, 27 Jan 2021 20:27:52 -0500 Received: from mga12.intel.com ([192.55.52.136]:27363 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229709AbhA1B1s (ORCPT ); Wed, 27 Jan 2021 20:27:48 -0500 IronPort-SDR: 0uzsh/dP5+qR7PH2N15E4H15miijJkH/O5K6eNFhlazMqaMhxE2rv+WpVVXzR5M4Uq4YyMP2La 1OnpwSXzkMkg== X-IronPort-AV: E=McAfee;i="6000,8403,9877"; a="159335530" X-IronPort-AV: E=Sophos;i="5.79,381,1602572400"; d="scan'208";a="159335530" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 17:26:02 -0800 IronPort-SDR: Kq78ATGb6zSuQed5PKw0bvAiX9cHwz4b4UTgafQsDmhHO9VX4lPah7PJoWsjLn9GScl4l4mH9v T0778ZGgfMug== X-IronPort-AV: E=Sophos;i="5.79,381,1602572400"; d="scan'208";a="362651210" Received: from yjin15-mobl1.ccr.corp.intel.com (HELO [10.238.4.27]) ([10.238.4.27]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 17:25:59 -0800 Subject: Re: [PATCH v8] perf stat: Fix wrong skipping for per-die aggregation To: Jiri Olsa Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com, ying.huang@intel.com References: <20210125233525.13706-1-yao.jin@linux.intel.com> <20210127220827.GB284633@krava> From: "Jin, Yao" Message-ID: <58796d6e-fceb-ea1f-3a83-543569d5625c@linux.intel.com> Date: Thu, 28 Jan 2021 09:25:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210127220827.GB284633@krava> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jiri, On 1/28/2021 6:08 AM, Jiri Olsa wrote: >> @@ -1385,7 +1386,8 @@ void evsel__exit(struct evsel *evsel) >> zfree(&evsel->group_name); >> zfree(&evsel->name); >> zfree(&evsel->pmu_name); >> - zfree(&evsel->per_pkg_mask); > sorry I did not notice before, but I think we need to call > zero_per_pkg in here, otherwise we're leaking keys > > jirka > Sorry, I forgot to add the release code here. :( I will rename zero_per_pkg to evsel__zero_per_pkg and move it to evsel.c and call evsel__zero_per_pkg in evsel__exit(). Thanks Jin Yao