From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751171AbdAPGaM (ORCPT ); Mon, 16 Jan 2017 01:30:12 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:60786 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750845AbdAPGaI (ORCPT ); Mon, 16 Jan 2017 01:30:08 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a38-f79836d00000492b-aa-587c686ea96d Content-transfer-encoding: 8BIT Message-id: <587C686D.9010608@samsung.com> Date: Mon, 16 Jan 2017 15:30:05 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: Laxman Dewangan , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Lee Jones Subject: Re: [PATCH v2 1/4] mfd: max77686: Don't attempt to get i2c_device_id .data In-reply-to: <1484314449-10060-2-git-send-email-javier@osg.samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMJsWRmVeSWpSXmKPExsWy7bCmvm5eRk2EQf9mTouNM9azWrx5u4bJ 4vz5DewWS/etZrG4//Uoo8XlXXPYHNg8Nq3qZPO4c20Pm0dv8zs2jy39d9k9+rasYvT4vEku gC0q1SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH6Awl hbLEnFKgUEBicbGSvp1NUX5pSapCRn5xia1StKGhkZ6hgbmekZGRnolxrJWRKVBJQmpG/4wP zAWNvBWPt8xjaWA8xtXFyMkhIWAicf3UJ0YIW0ziwr31bF2MXBxCAjsYJf6ePMkC4bQzSeyc d4wZpqPv9laoxBxGickT/4EleAUEJX5MvgeU4OBgFpCXOHIpGyTMLKApsXX3enaI+nuMEitm 3YSq15L4+G47E4jNIqAqce0NSBEnBxtQfP+LG2wgNr+AosTVH4/BzhMViJDYOf8bO8h8EYFQ iQ37bEFmMgusZZR48LaBFSQuDBRv3JUOUs4p4C5x/vZUVpAaCYFd7BJ7d99iBKmREJCV2HQA 6hcXid2/LrJB2MISr45vYYewpSVW/bvFBNE7mVGia+1fZginh1Gicc1RqA5jifsP7jFDfMkn 8e5rDyvEAl6JjjYhiBIPia9fZ7NC2I4SV37vhwbvdUaJl1Mus0xgVJiFFHazEGE3CynsFjAy r2IUSy0ozk1PLTYsMNErTswtLs1L10vOz93ECE6QWhY7GPec8znEKMDBqMTD+2NXdYQQa2JZ cWXuIUYJDmYlEd6JKTURQrwpiZVVqUX58UWlOanFhxhNgUE/kVlKNDkfmLzzSuINTcwMTYxM DA3NjQyMlMR5FzdaRwgJpCeWpGanphakFsH0MXFwSjUwbtx8vSDG+Jyuqu5afoFlXcfz7Q6I dvNp6LgpM82vm9R6Z1Kq0CLmpT+rFphWftwuXv2jY5/Hq9OCsfOkjiRdTQupq9lTJ15fd+5Y injWivAz177MdQjVfr9NLt3bd1pH/ZqY26z7J/UkJb/rXnN8tZ20wJ3jn1LXeukfKm2u7P94 /b++9hkVJZbijERDLeai4kQA5pvTSqYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrAIsWRmVeSWpSXmKPExsVy+t9jQd3cjJoIgx2XzS02zljPavHm7Rom i/PnN7BbLN23msXi/tejjBaXd81hc2Dz2LSqk83jzrU9bB69ze/YPLb032X36NuyitHj8ya5 ALYoN5uM1MSU1CKF1Lzk/JTMvHRbpdAQN10LJYW8xNxUW6UIXd+QICWFssScUiDPyAANODgH uAcr6dsluGX0z/jAXNDIW/F4yzyWBsZjXF2MnBwSAiYSfbe3skDYYhIX7q1n62Lk4hASmMUo cf/aWrAEr4CgxI/J94BsDg5mAXmJI5eyQcLMAuoSk+YtYoaof8Ao8XfGXDaIei2Jj++2M4HY LAKqEtferGcHsdmA4vtf3ACr4RdQlLj64zEjyExRgQiJ7hOVIGERgVCJfxdvM4LMZBZYzyjR s/YW2A3CQIkFDc/ZIZZdZ5RY1TobLMEp4C5x/vZU1gmMgrOQ3DoL4dZZSG5dwMi8ilEitSC5 oDgpPdcwL7Vcrzgxt7g0L10vOT93EyM49p5J7WA8uMv9EKMAB6MSD++CHdURQqyJZcWVuYcY JTiYlUR4J6bURAjxpiRWVqUW5ccXleakFh9iNAV6diKzlGhyPjAt5JXEG5qYm5gbG1iYW1qa GCmJ8zbOfhYuJJCeWJKanZpakFoE08fEwSnVwFj5bOlv530nrsi+ubIi/PPxY1sXqeS85RL8 PWHLw0mH/r/MO/1DncfpcIhFkMDHXfm3xNobMnPPiFiJFO6IXtA12azp3+nOd1KVIRdvvz8s ZXHa7dQz/ctMUvEvxMXZHJZ2zihU+zEx8krazscawftvmU9Ia3H+3neAJVN2zZxzWveWdk59 6SmnxFKckWioxVxUnAgAKXQatdMCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170116063005epcas1p4c051d754694930bf66975a81b8fb4262 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS9DaGFuZ2UgQWdlbnQ=?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTNS9TZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170113133425epcas4p33868e579eddc3637e585b637a8dd7851 X-RootMTR: 20170113133425epcas4p33868e579eddc3637e585b637a8dd7851 References: <1484314449-10060-1-git-send-email-javier@osg.samsung.com> <1484314449-10060-2-git-send-email-javier@osg.samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2017년 01월 13일 22:34, Javier Martinez Canillas wrote: > The driver is only used in platforms that have DT support so always the > I2C device .data will be get from the matched OF node and never will be > from the I2C device ID table. > > Signed-off-by: Javier Martinez Canillas > Acked-by: Laxman Dewangan > Reviewed-by: Krzysztof Kozlowski > Tested-by: Krzysztof Kozlowski > > --- > > Changes in v2: > - Add Laxman's Acked-by tag to patch 1/4. > - Add Krzysztof's Reviewed-by and Tested-by tags to patch 1/4. > > drivers/mfd/max77686.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c > index 7b68ed72e9cb..ddae3bf3e46c 100644 > --- a/drivers/mfd/max77686.c > +++ b/drivers/mfd/max77686.c > @@ -188,14 +188,11 @@ static int max77686_i2c_probe(struct i2c_client *i2c, > if (!max77686) > return -ENOMEM; > > - if (i2c->dev.of_node) { > - match = of_match_node(max77686_pmic_dt_match, i2c->dev.of_node); > - if (!match) > - return -EINVAL; > - > - max77686->type = (unsigned long)match->data; > - } else > - max77686->type = id->driver_data; > + match = of_match_node(max77686_pmic_dt_match, i2c->dev.of_node); > + if (!match) > + return -EINVAL; > + > + max77686->type = (unsigned long)match->data; > > i2c_set_clientdata(i2c, max77686); > max77686->dev = &i2c->dev; > Looks good to me. Reviewed-by: Chanwoo Choi -- Best Regards, Chanwoo Choi S/W Center, Samsung Electronics