From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751348AbdAPGfA (ORCPT ); Mon, 16 Jan 2017 01:35:00 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:43860 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751096AbdAPGe6 (ORCPT ); Mon, 16 Jan 2017 01:34:58 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a3d-f793f6d000001fd5-9d-587c6990cdeb Content-transfer-encoding: 8BIT Message-id: <587C698F.90602@samsung.com> Date: Mon, 16 Jan 2017 15:34:55 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: Laxman Dewangan , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Lee Jones Subject: Re: [PATCH v2 2/4] mfd: max77686: Use of_device_get_match_data() helper In-reply-to: <1484314449-10060-3-git-send-email-javier@osg.samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIJsWRmVeSWpSXmKPExsWy7bCmge6EzJoIg0MrRCw2zljPavHm7Rom i/PnN7BbLN23msXi/tejjBaXd81hc2Dz2LSqk83jzrU9bB69ze/YPLb032X36NuyitHj8ya5 ALaoVJuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wcoDOU FMoSc0qBQgGJxcVK+nY2RfmlJakKGfnFJbZK0YaGRnqGBuZ6RkZGeibGsVZGpkAlCakZjZN/ MBYcFqw4e+wKcwNjF18XIyeHhICJxNQXn9kgbDGJC/fWA9lcHEICOxglPr1byQThtDNJdL3o ZoTpaNzYxwyRWM4osXn5NHaQBK+AoMSPyfdYuhg5OJgF5CWOXMoGCTMLaEps3b0erERI4B6j xNLrkiAlvAIaEkuueYGEWQRUJS4vm8MCYrMJaEnsf3ED7CB+AUWJqz8eg60VFYiQ2Dn/GztI q4hAqMSGfbYgFzALrGWUePC2gRUkLiwQJDG9XxaknFPAXeLEjLdgV0oI7GOXWPF2LSNIjYSA rMSmA8wQn7hIvFn+iQnCFpZ4dXwLO4QtLbHq3y0miN7JjBJda/9CDephlGhccxQaWsYS9x/c Y4b4kU/i3dceVogFvBIdbUIQJR4SHc/+QS1zlHj9/T8jJNiuM0pMP3GMeQKjwiykkJuFCLlZ SCG3gJF5FaNYakFxbnpqsWGBpV5xYm5xaV66XnJ+7iZGcHLUst3B+OWczyFGAQ5GJR7eBTuq I4RYE8uKK3MPMUpwMCuJ8E5MqYkQ4k1JrKxKLcqPLyrNSS0+xGgKDPqJzFKiyfnAxJ1XEm9o YmZoYmRiaGhuZGCkJM67rNE6QkggPbEkNTs1tSC1CKaPiYNTqoExvsy7k0VPXePOZ4/tVUYz NZhmHl1jfn/xLXt/L+3oY19/uWtJnm412RKoK54S8nVb5jLmQu+NLadfqlu89G+5+lq8LGuR VuMj+y6duR/SlUW/N4utS0p9bG9+KmgV7+/P0z2aPsbuW33OLics1ED4mPuZqC/Sa7kPbXm4 6GPLcQaGmUvsT7UqsRRnJBpqMRcVJwIAyrn0P6QDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRmVeSWpSXmKPExsVy+t9jAd0JmTURBqsvsFlsnLGe1eLN2zVM FufPb2C3WLpvNYvF/a9HGS0u75rD5sDmsWlVJ5vHnWt72Dx6m9+xeWzpv8vu0bdlFaPH501y AWxRbjYZqYkpqUUKqXnJ+SmZeem2SqEhbroWSgp5ibmptkoRur4hQUoKZYk5pUCekQEacHAO cA9W0rdLcMtonPyDseCwYMXZY1eYGxi7+LoYOTkkBEwkGjf2MUPYYhIX7q1n62Lk4hASWMoo cfjcO7AEr4CgxI/J91i6GDk4mAXkJY5cygYJMwuoS0yat4gZov4Bo8T21f+ZQWp4BTQkllzz AqlhEVCVuLxsDguIzSagJbH/xQ02EJtfQFHi6o/HjCDlogIREt0nKkHCIgKhEv8u3mYEGcks sJ5RomftLbC1wgIBEku/xECsus4o8f7YQbDTOAXcJU7MeMs8gVFwFpJLZyFcOgvJpQsYmVcx SqQWJBcUJ6XnGuallusVJ+YWl+al6yXn525iBMfdM6kdjAd3uR9iFOBgVOLhXbCjOkKINbGs uDL3EKMEB7OSCO/ElJoIId6UxMqq1KL8+KLSnNTiQ4ymQL9OZJYSTc4HpoS8knhDE3MTc2MD C3NLSxMjJXHextnPwoUE0hNLUrNTUwtSi2D6mDg4pRoY1yb6JG8WmHpQ4m7pmxspkm9KeI7P PBy50J5txkemmZWX9NJsa6d5XyyN6Nv28bD409l/rwVUfal9Pvuo3Scf54OvWzka1P8ET7TY Xtn6/Y3smhmdeZ8977c8zLngcmrPORcOS43oBTyfq+Yn+6yccdr9nsibpZMe79pkrBhXsyT4 9G/DhPAWKSWW4oxEQy3mouJEAN2mVULRAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170116063456epcas1p32b21bf4a87969a571355c09c342014d0 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS9DaGFuZ2UgQWdlbnQ=?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTNS9TZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170113133429epcas2p4ec409033b9bfa30945a93d767e55dac0 X-RootMTR: 20170113133429epcas2p4ec409033b9bfa30945a93d767e55dac0 References: <1484314449-10060-1-git-send-email-javier@osg.samsung.com> <1484314449-10060-3-git-send-email-javier@osg.samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2017년 01월 13일 22:34, Javier Martinez Canillas wrote: > Use the generic helper to get the matched of_device_id .data, instead of > open coding it. > > The driver was checking if matching the OF node with the driver's OF table > was failing, but this doesn't make too much sense since this can't happen > in practice. The fact the probe function was called, means OF registered a > device with a valid compatible string so a of_device_get_match_data() call > will always succeed. So just remove this unneeded check. > > Signed-off-by: Javier Martinez Canillas > Acked-by: Laxman Dewangan > > --- > > Changes in v2: > - Add Laxman's Acked-by tag to patch 2/4. > - Mention in commit message that an unneeded check for match is removed. > > drivers/mfd/max77686.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c > index ddae3bf3e46c..33dd09493605 100644 > --- a/drivers/mfd/max77686.c > +++ b/drivers/mfd/max77686.c > @@ -34,6 +34,7 @@ > #include > #include > #include > +#include > > static const struct mfd_cell max77686_devs[] = { > { .name = "max77686-pmic", }, > @@ -175,7 +176,6 @@ static int max77686_i2c_probe(struct i2c_client *i2c, > const struct i2c_device_id *id) > { > struct max77686_dev *max77686 = NULL; > - const struct of_device_id *match; > unsigned int data; > int ret = 0; > const struct regmap_config *config; > @@ -188,13 +188,8 @@ static int max77686_i2c_probe(struct i2c_client *i2c, > if (!max77686) > return -ENOMEM; > > - match = of_match_node(max77686_pmic_dt_match, i2c->dev.of_node); > - if (!match) > - return -EINVAL; > - > - max77686->type = (unsigned long)match->data; > - > i2c_set_clientdata(i2c, max77686); > + max77686->type = (unsigned long)of_device_get_match_data(&i2c->dev); > max77686->dev = &i2c->dev; > max77686->i2c = i2c; > > Looks good to me. Reviewed-by: Chanwoo Choi -- Best Regards, Chanwoo Choi S/W Center, Samsung Electronics