From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751208AbdAPGhS (ORCPT ); Mon, 16 Jan 2017 01:37:18 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:35452 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbdAPGhQ (ORCPT ); Mon, 16 Jan 2017 01:37:16 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a59-f79c56d000006d2c-78-587c6a19cd42 Content-transfer-encoding: 8BIT Message-id: <587C6A19.1060905@samsung.com> Date: Mon, 16 Jan 2017 15:37:13 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: Laxman Dewangan , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Lee Jones Subject: Re: [PATCH v2 3/4] mfd: max77686: Use the struct i2c_driver .probe_new instead of .probe In-reply-to: <1484314449-10060-4-git-send-email-javier@osg.samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA01SbWxLYRTO29ve3qG8iu2YsLohYqx2q92KVrCFson6TE2Yq7tpa2s7vS2G UMTXYj5DqhGbsIjZsmlmmdlqma8QDJ0RoSQY5jMZM0Gi7Z2Q989znvOcc97n5FCE/BCZSNkc bs7lYAtoso+47srYMSlDV28ypfp8Su15X7VE++FjpUjb2loj1ZYHz4m1z79dQ9pQw3FyGmkI VOwhDU/bG0lDyfZPpKF2/zOpYV9tBTJ0BUYYyRxOZ+XYPM6l4BxmZ57NYdHTWQtzM3I1aalM CjNJm04rHKyd09OZ2caUmbaCyDdoxVq2wBOhjCzP0xOm6lxOj5tTWJ28W08vYxiVkklNV6pU KqV64vLJKk1EspKz3nrSjgrv9l9/tNVHeNGbvsUojgKshoqudkLA8XAvXE0Woz6UHJcjON90 XSQEu0Rw8kiP+G9Fd9MtQkicQXDg0Y9YQoYHQs/hcARTFIGT4OqD/ChN4LFw4VK1VNCHEbzv aEWCPhk6zt2O1YrxaDjV1iWJYjLCX377mIziAXgkPOx5GdMPwSa4WNotjfYfjBdDTVAf7Ung KgQvPnolUX4QNkPwsSUqj8OzILTjdMwA4KAUTm0Pi6IawMMh0NzrOBM6L/qlAh4EnTdqe/Ew +F3+BAm1hxEUV/0mhGAvgq2V10hBNRGevwgTgsv+UPLzVe8AGezeKRckBvh192zvsOlQ1/gu 5lGOHyG48zDhAFL4/1ud/9/q/P+trgwRFSieK+TtFo7XFGqUPGvnPQ6L0uy0B1DsHpOX1qO2 YwtaEKYQ3U9WVr/RJJewa/kiewsCiqAHyw7mbTLJZXls0QbO5cx1eQo4vgVpIps/SCQOMTsj 1+1w5zLqNEatmhR56Uw6nSArWz/FJMcW1s3lc1wh5/pbJ6LiEr3I9nqd+/SaUSuOFTX4T9z8 kjPTklNZ3zC+NCAZp/esbKuaEMrunmGc51APS8vqNO+9HvCqnfFJYrk31LxxfFrczYSSd2OM c/d9z9dVZeiopkW2rBp7pTXT/7n+13yV+oFvzn3Ku06XnDQ79OXe14wl2zoaV2mCr+qmZPZF zVsUmwlazFtZJplw8ewfkYZzFKUDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRmVeSWpSXmKPExsVy+t9jAV3JrJoIg18fRS02zljPavHm7Rom i/PnN7BbLN23msXi/tejjBaXd81hc2Dz2LSqk83jzrU9bB69ze/YPLb032X36NuyitHj8ya5 ALYoN5uM1MSU1CKF1Lzk/JTMvHRbpdAQN10LJYW8xNxUW6UIXd+QICWFssScUiDPyAANODgH uAcr6dsluGWcunWNseAcX8W08zOYGxifc3cxcnJICJhIfNt7ihnCFpO4cG89G4gtJLCUUeL+ biYQm1dAUOLH5HssXYwcHMwC8hJHLmWDhJkF1CUmzVsE1MoFVP6AUeLu6ytsEPVaEs9Wn2EB sVkEVCUWX/nMCmKzAcX3v7gBVsMvoChx9cdjRpCZogIREt0nKkHCIgKhEv8u3mYEmckssJ5R omftLbA5wgLJEsu+LWCEuO06o8S9Y8kgNqeAu8Tl1iVMExgFZyE5dRbCqbOQnLqAkXkVo0Rq QXJBcVJ6rlFearlecWJucWleul5yfu4mRnDcPZPewXh4l/shRgEORiUe3gU7qiOEWBPLiitz DzFKcDArifBOTKmJEOJNSaysSi3Kjy8qzUktPsRoCvTrRGYp0eR8YErIK4k3NDE3MTc2sDC3 tDQxUhLnbZz9LFxIID2xJDU7NbUgtQimj4mDU6qB0VZ/wrE9tjGXVK9+95v6/lm5aW0F08lP 219sEXc6+tv81p77c3iTM9Q2Cq/6xzpr6k+Fv+HmMduY/Q4ePrvjhsyS2+0cMVIJz016Pi6P DFnv9KPSvk1f/6CpoEPfxc2v1+mv5H+27MLcsuf8qf4LbjWU2k4Tmnjjme2M2ZGdTr7PewvV BK9EZCuxFGckGmoxFxUnAgBbBUrS0QIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170116063713epcas5p17533c107a0e4163932bf4e60bf01d000 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS9DaGFuZ2UgQWdlbnQ=?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTNS9TZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170113133432epcas2p39ba1dd2059584d87215e61d665b82a26 X-RootMTR: 20170113133432epcas2p39ba1dd2059584d87215e61d665b82a26 References: <1484314449-10060-1-git-send-email-javier@osg.samsung.com> <1484314449-10060-4-git-send-email-javier@osg.samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2017년 01월 13일 22:34, Javier Martinez Canillas wrote: > If a driver is only used in DT platforms, there's no need to get the > i2c_device_id as an argument of the probe function. Since this data > can be get from the matching of_device_id. > > There's a temporary .probe_new field in struct i2c_driver that can be > used as probe callback for the case when i2c_device_id won't be used. > > Signed-off-by: Javier Martinez Canillas > Acked-by: Laxman Dewangan > Reviewed-by: Krzysztof Kozlowski > Tested-by: Krzysztof Kozlowski > > --- > > Changes in v2: > - Add Laxman's Acked-by tag to patch 3/4. > - Add Krzysztof's Reviewed-by and Tested-by tags to patch 3/4. > > drivers/mfd/max77686.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c > index 33dd09493605..896c1bf85acc 100644 > --- a/drivers/mfd/max77686.c > +++ b/drivers/mfd/max77686.c > @@ -172,8 +172,7 @@ static const struct of_device_id max77686_pmic_dt_match[] = { > }; > MODULE_DEVICE_TABLE(of, max77686_pmic_dt_match); > > -static int max77686_i2c_probe(struct i2c_client *i2c, > - const struct i2c_device_id *id) > +static int max77686_i2c_probe(struct i2c_client *i2c) > { > struct max77686_dev *max77686 = NULL; > unsigned int data; > @@ -294,7 +293,7 @@ static struct i2c_driver max77686_i2c_driver = { > .pm = &max77686_pm, > .of_match_table = of_match_ptr(max77686_pmic_dt_match), > }, > - .probe = max77686_i2c_probe, > + .probe_new = max77686_i2c_probe, > .id_table = max77686_i2c_id, > }; > > Looks good to me. Reviewed-by: Chanwoo Choi -- Best Regards, Chanwoo Choi S/W Center, Samsung Electronics