From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751484AbdAPGq3 (ORCPT ); Mon, 16 Jan 2017 01:46:29 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:52753 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751447AbdAPGqR (ORCPT ); Mon, 16 Jan 2017 01:46:17 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a2d-f79166d000001fef-8e-587c6c372163 Content-transfer-encoding: 8BIT Message-id: <587C6C36.5070606@samsung.com> Date: Mon, 16 Jan 2017 15:46:14 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: Laxman Dewangan , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Lee Jones Subject: Re: [PATCH v2 4/4] mfd: max77686: Remove I2C device ID table In-reply-to: <1484314449-10060-5-git-send-email-javier@osg.samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA01SbUhTYRTm3b27u1utbkvtZFTrQj+UXN6lbZZKltVCQyGkZcS6zYuK+5Dd adoHGJnWSPuwH2GWmkhhE21oWdYqawZR2ZK+axpF9LlCzcTsY9stivfPc855zvOe83BITFFD RJL5Fjtns7AmmpDh565HRcVoTDv0sU2dM7Vnj7aJtR8/OUXavr52ibbZfQbXDnz1IG3/xTpi GaFztewjdM8fXiJ0Vbv9hK7jwAuJrrqjBemGXXMyiWwuMY9jczibkrMYrTn5ltwkOm2dYYUh fnEsE8MkaDW00sKauSQ6NT0zZlW+KTAGrSxmTUWBVCbL8/TC5ESbtcjOKfOsvD2J3sgwahUT q1Gp1WpV3KJNS9TxAcpmLm98wCsu3CMv8Q49RmWoV+ZAUhKoODjpOiIRcATc87URDiQjFVQz gka3XywElSK4fPg89rfDe8qFhEIdgvqWGiJYkFPTYKzGhzsQSWLUXLhxvyCYxqgo6Oxukwh8 H4KhN9+RwI+GZ3ffiIMYp+ZDefWJ0BhEIH/l7eOQ5lRqHjwYexXih1N6uFA/Kgnqh1FZ0O5O CmpiVCuCwU9lIZ3p1Ep44r8lCmIptRrGG0dxYWi3BBwvjcFeoGaD6+qfXVKhx+0SCXg6vL/Z 8ceJWfCj+WloR6BqEDhaf2BCsB/BLqeHEFiLYGDQhwlbToGq769Fwgdy2FuhECg6GHZWIAGn gLe8EheMeIRgX/cH/CBS1v7nXe0/72r/864BYS0ogivkzbkcH1+oVvGsmS+y5KqMVrMLhQ4y OqYLjTSk9SCKRPRk+Zef2/UKMVvMl5p7EJAYHSZflb9Dr5DnsKXbOJvVYCsycXwPig9YfwiL DDdaA+dtsRuYuMVMnDoh8DSMhp4hbyhZqldQuaydK+C4Qs72t09ESiPL0InY7mz2+vrG47Xv miRehX9D8/7eDPxX/Z0rWZHS070j5XVbn03qlA9sTPat6Vou/ep5nfix/JutfueWWS4HmMLW fk5XimQSIzhN6rbh455lB8mUaoNJY2waJvxPb09MuBMyKps8CcVdKd9mPLm2e8GxEadmal8y mvxK1mfsJ2mcz2OZaMzGs78Bv7k8TqYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrAIsWRmVeSWpSXmKPExsVy+t9jQV3znJoIg1tP2Cw2zljPavHm7Rom i/PnN7BbLN23msXi/tejjBaXd81hc2Dz2LSqk83jzrU9bB69ze/YPLb032X36NuyitHj8ya5 ALYoN5uM1MSU1CKF1Lzk/JTMvHRbpdAQN10LJYW8xNxUW6UIXd+QICWFssScUiDPyAANODgH uAcr6dsluGX8un+RtaCVt+LipxuMDYzHuLoYOTkkBEwkLi7fxAhhi0lcuLeerYuRi0NIYBaj xKerDSwgCV4BQYkfk+8B2RwczALyEkcuZYOEmQXUJSbNW8QMUf+AUWLemUuMEPVaErfPPWMF sVkEVCVa+uaxg9hsQPH9L26wgdj8AooSV388ZgSZKSoQIdF9ohIkLCIQKvHv4m1GkJnMAusZ JXrW3gK7QVjAVeLmu1NMEMuuM0pMv38ObBmngLvEr4XfWCYwCs5CcusshFtnIbl1ASPzKkaJ 1ILkguKk9FyjvNRyveLE3OLSvHS95PzcTYzg2HsmvYPx8C73Q4wCHIxKPLwLdlRHCLEmlhVX 5h5ilOBgVhLhdcusiRDiTUmsrEotyo8vKs1JLT7EaAr07ERmKdHkfGBayCuJNzQxNzE3NrAw t7Q0MVIS522c/SxcSCA9sSQ1OzW1ILUIpo+Jg1OqgbGSR2ivc7Ts+X8eChF6q4UX5yw+3rLT Re7owS+HvWNSFzscW+xwxkfn3bW180I49uj/vCKomyPjle/yMMfh28qtfMnXNa0P1AvfS7Vu nxxV2niQ59b31iP6M5QEnsQt2mdz4dtVrmn3j6TdkjqbdZjrXoZl/3Mey1dWd8+9mjChVap2 TmrHgmQlluKMREMt5qLiRACr1BTv0wIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170116064615epcas5p2bc252cf46d0d2b12881b03cf75569a9c X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS9DaGFuZ2UgQWdlbnQ=?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTNS9TZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170113133435epcas4p47bc9f122524db29df3dc94b208a64385 X-RootMTR: 20170113133435epcas4p47bc9f122524db29df3dc94b208a64385 References: <1484314449-10060-1-git-send-email-javier@osg.samsung.com> <1484314449-10060-5-git-send-email-javier@osg.samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I think that this patch better to squash with patch3. After applying the patch3, this driver doesn't use the max77686_i2c_id table. On 2017년 01월 13일 22:34, Javier Martinez Canillas wrote: > The driver is only used in DT platforms so there's no need to > have an i2c_device_id table. > > Signed-off-by: Javier Martinez Canillas > Acked-by: Laxman Dewangan > Reviewed-by: Krzysztof Kozlowski > Tested-by: Krzysztof Kozlowski > > --- > > Changes in v2: > - Add Laxman's Acked-by tag to patch 4/4. > - Add Krzysztof's Reviewed-by and Tested-by tags to patch 4/4. > > drivers/mfd/max77686.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c > index 896c1bf85acc..b0e8e13c0049 100644 > --- a/drivers/mfd/max77686.c > +++ b/drivers/mfd/max77686.c > @@ -241,13 +241,6 @@ static int max77686_i2c_probe(struct i2c_client *i2c) > return 0; > } > > -static const struct i2c_device_id max77686_i2c_id[] = { > - { "max77686", TYPE_MAX77686 }, > - { "max77802", TYPE_MAX77802 }, > - { } > -}; > -MODULE_DEVICE_TABLE(i2c, max77686_i2c_id); > - > #ifdef CONFIG_PM_SLEEP > static int max77686_suspend(struct device *dev) > { > @@ -294,7 +287,6 @@ static struct i2c_driver max77686_i2c_driver = { > .of_match_table = of_match_ptr(max77686_pmic_dt_match), > }, > .probe_new = max77686_i2c_probe, > - .id_table = max77686_i2c_id, > }; > > module_i2c_driver(max77686_i2c_driver); > -- Best Regards, Chanwoo Choi S/W Center, Samsung Electronics