From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751354AbdARE1R (ORCPT ); Tue, 17 Jan 2017 23:27:17 -0500 Received: from lucky1.263xmail.com ([211.157.147.131]:59962 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750924AbdARE1P (ORCPT ); Tue, 17 Jan 2017 23:27:15 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: hl@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: hl@rock-chips.com X-UNIQUE-TAG: <3d2ab4ad8c8bf5d9a5996017a37333e8> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] clk: rockchip: fix the incorrect pclk_edp div width for RK3399 To: Xing Zheng , heiko@sntech.de References: <1484713256-3005-1-git-send-email-zhengxing@rock-chips.com> Cc: dianders@google.com, linux-rockchip@lists.infradead.org, Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: hl Message-ID: <587EEE97.804@rock-chips.com> Date: Wed, 18 Jan 2017 12:27:03 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1484713256-3005-1-git-send-email-zhengxing@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tested-by: Lin Huang On 2017年01月18日 12:20, Xing Zheng wrote: > The range of the pclk_edp_div_con is [13:8] and 6 bits, not 5. > > Reported-by: Lin Huang > Signed-off-by: Xing Zheng > --- > > drivers/clk/rockchip/clk-rk3399.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c > index 3490887..73121b14 100644 > --- a/drivers/clk/rockchip/clk-rk3399.c > +++ b/drivers/clk/rockchip/clk-rk3399.c > @@ -1132,7 +1132,7 @@ static struct rockchip_clk_branch rk3399_clk_branches[] __initdata = { > RK3399_CLKGATE_CON(11), 8, GFLAGS), > > COMPOSITE(PCLK_EDP, "pclk_edp", mux_pll_src_cpll_gpll_p, 0, > - RK3399_CLKSEL_CON(44), 15, 1, MFLAGS, 8, 5, DFLAGS, > + RK3399_CLKSEL_CON(44), 15, 1, MFLAGS, 8, 6, DFLAGS, > RK3399_CLKGATE_CON(11), 11, GFLAGS), > GATE(PCLK_EDP_NOC, "pclk_edp_noc", "pclk_edp", CLK_IGNORE_UNUSED, > RK3399_CLKGATE_CON(32), 12, GFLAGS), -- Lin Huang