public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: exynos: Remove address node from usb parent node
       [not found] <CGME20170118054410epcas1p4df5c5631e0b13081662eb8fff5e383b3@epcas1p4.samsung.com>
@ 2017-01-18  5:46 ` Pankaj Dubey
  2017-01-18  7:04   ` Chanwoo Choi
  0 siblings, 1 reply; 4+ messages in thread
From: Pankaj Dubey @ 2017-01-18  5:46 UTC (permalink / raw)
  To: devicetree, linux-kernel, linux-samsung-soc
  Cc: robh+dt, krzk, kgene, cw00.choi, javier, Pankaj Dubey

Address node does not required to be put after parent't node,
so remove address node from usb parent node.

Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
---
 arch/arm64/boot/dts/exynos/exynos5433.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
index 68f764e..0d7a55d 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
@@ -1285,7 +1285,7 @@
 			status = "disabled";
 		};
 
-		usbdrd30: usb@15400000  {
+		usbdrd30: usb3-0 {
 			compatible = "samsung,exynos5250-dwusb3";
 			clocks = <&cmu_fsys CLK_ACLK_USBDRD30>,
 				<&cmu_fsys CLK_SCLK_USBDRD30>;
@@ -1332,7 +1332,7 @@
 			status = "disabled";
 		};
 
-		usbhost30: usb@15a00000 {
+		usbhost30: usbhost3-0 {
 			compatible = "samsung,exynos5250-dwusb3";
 			clocks = <&cmu_fsys CLK_ACLK_USBHOST30>,
 				<&cmu_fsys CLK_SCLK_USBHOST30>;
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: exynos: Remove address node from usb parent node
  2017-01-18  5:46 ` [PATCH] arm64: dts: exynos: Remove address node from usb parent node Pankaj Dubey
@ 2017-01-18  7:04   ` Chanwoo Choi
  2017-01-18 15:36     ` Javier Martinez Canillas
  0 siblings, 1 reply; 4+ messages in thread
From: Chanwoo Choi @ 2017-01-18  7:04 UTC (permalink / raw)
  To: Pankaj Dubey, devicetree, linux-kernel, linux-samsung-soc
  Cc: robh+dt, krzk, kgene, javier

Hi Pankaj,

This issue already posted by Javier Martinez Canillas[1].
Maybe, he will post v2.

[1] https://lkml.org/lkml/2017/1/10/907
- ("Re: [PATCH v2 3/3] arm64: dts: exynos: Remove unneeded unit names in Exynos5433 nodes")

On 2017년 01월 18일 14:46, Pankaj Dubey wrote:
> Address node does not required to be put after parent't node,
> so remove address node from usb parent node.
> 
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynos5433.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index 68f764e..0d7a55d 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -1285,7 +1285,7 @@
>  			status = "disabled";
>  		};
>  
> -		usbdrd30: usb@15400000  {
> +		usbdrd30: usb3-0 {
>  			compatible = "samsung,exynos5250-dwusb3";
>  			clocks = <&cmu_fsys CLK_ACLK_USBDRD30>,
>  				<&cmu_fsys CLK_SCLK_USBDRD30>;
> @@ -1332,7 +1332,7 @@
>  			status = "disabled";
>  		};
>  
> -		usbhost30: usb@15a00000 {
> +		usbhost30: usbhost3-0 {
>  			compatible = "samsung,exynos5250-dwusb3";
>  			clocks = <&cmu_fsys CLK_ACLK_USBHOST30>,
>  				<&cmu_fsys CLK_SCLK_USBHOST30>;
> 


-- 
Best Regards,
Chanwoo Choi
S/W Center, Samsung Electronics

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: exynos: Remove address node from usb parent node
  2017-01-18  7:04   ` Chanwoo Choi
@ 2017-01-18 15:36     ` Javier Martinez Canillas
  2017-01-20  4:23       ` pankaj.dubey
  0 siblings, 1 reply; 4+ messages in thread
From: Javier Martinez Canillas @ 2017-01-18 15:36 UTC (permalink / raw)
  To: Chanwoo Choi, Pankaj Dubey, devicetree, linux-kernel,
	linux-samsung-soc
  Cc: robh+dt, krzk, kgene

Hello,

On 01/18/2017 04:04 AM, Chanwoo Choi wrote:
> Hi Pankaj,
> 
> This issue already posted by Javier Martinez Canillas[1].
> Maybe, he will post v2.
> 

That's correct, I didn't post a v2 since I was waiting for feedback
from the DT maintainers on patches 1/2 and 2/2 from the same series:

https://www.spinics.net/lists/arm-kernel/msg553286.html

But I'll re-spin just this patch since the changes are independent.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: exynos: Remove address node from usb parent node
  2017-01-18 15:36     ` Javier Martinez Canillas
@ 2017-01-20  4:23       ` pankaj.dubey
  0 siblings, 0 replies; 4+ messages in thread
From: pankaj.dubey @ 2017-01-20  4:23 UTC (permalink / raw)
  To: Javier Martinez Canillas, Chanwoo Choi, devicetree, linux-kernel,
	linux-samsung-soc
  Cc: robh+dt, krzk, kgene

Hi Javier,

On Wednesday 18 January 2017 09:06 PM, Javier Martinez Canillas wrote:
> Hello,
> 
> On 01/18/2017 04:04 AM, Chanwoo Choi wrote:
>> Hi Pankaj,
>>
>> This issue already posted by Javier Martinez Canillas[1].
>> Maybe, he will post v2.
>>
> 
> That's correct, I didn't post a v2 since I was waiting for feedback
> from the DT maintainers on patches 1/2 and 2/2 from the same series:
> 
> https://www.spinics.net/lists/arm-kernel/msg553286.html
> 
> But I'll re-spin just this patch since the changes are independent.
> 

I didn't noticed this earlier. In this case my patch [1] can be ignored.

[1]: https://patchwork.kernel.org/patch/9522645/

Thanks,
Pankaj Dubey

> Best regards,
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-01-20  4:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CGME20170118054410epcas1p4df5c5631e0b13081662eb8fff5e383b3@epcas1p4.samsung.com>
2017-01-18  5:46 ` [PATCH] arm64: dts: exynos: Remove address node from usb parent node Pankaj Dubey
2017-01-18  7:04   ` Chanwoo Choi
2017-01-18 15:36     ` Javier Martinez Canillas
2017-01-20  4:23       ` pankaj.dubey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox