From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757751AbdEKQR5 (ORCPT ); Thu, 11 May 2017 12:17:57 -0400 Received: from mout.web.de ([212.227.15.3]:58442 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756809AbdEKQRJ (ORCPT ); Thu, 11 May 2017 12:17:09 -0400 Subject: [PATCH 2/4] vmbus: Delete an error message for a failed memory allocation in vmbus_device_create() From: SF Markus Elfring To: devel@linuxdriverproject.org, Haiyang Zhang , "K. Y. Srinivasan" , Stephen Hemminger Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang References: Message-ID: <587dbcf5-8b12-fac7-693e-5f471e6d5167@users.sourceforge.net> Date: Thu, 11 May 2017 18:17:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:QGwN11vS9R0eR2aRXqx6C44A8BAZx0qAImJ93uCLI9SzLSjxcLF oTUeE9MjBwOBCfIGxnJ7ljGpYhGwklBYoH7zjmprc8son1x9Kaw6/Zo1FxiEY0ClQm2JWq6 t0yrmhuBpXsfQDS8k96eTtLk/cbu2agaSJurIJ452e0TqaJRXf66X1Ymh5T7XsWUhg3o0SY azLAG2CXFfJu+wACfU/Tg== X-UI-Out-Filterresults: notjunk:1;V01:K0:K6ev+ywm2fU=:dqUu9+wLhXm6fNLxYrtsXY zr811XfcI91LzRcLDC05D/2h7v2yxWORsXTKtvwbR9Py2AJjjXpVfBDk7fmQQuAC3u585L7y0 XGYN3vr8qYPO3TSu+AVUAhCi/j1CMvy63e8ujp6VNwYDrJJv0uWvmDz2PWk421mrXA93+Sk74 NNuuqDDlSze2CbDTxIpqa7Rc9ecBiDwEp71kc67bvaF3a9Q8Pceq1c1xDntZWXnbVZ53mYK/X lR03/e98OMSVR2lQ0JtlmDXw0Cd/CqnmSP4+wK/f7XbPgNbUIgMixWDRUsl9LttnoBxwon9jE kuqmUnkDXd5EaWVzGnz9CWbqNWPbgHKTdIFWiVItQNt6UlpGKbaXk0kEmpdDWaXYFDFgijcHP aBjRjrcyjL75EjDRwYdgiszE8qE9/A/zZbqIvyIfoXTiSZRLO5X/H24m+8GHE8EGTwAJWBNn+ asUW/v3KLCCIT4Vmho50mbss4p/I0gWVaFsTv/Nus+jA4OSa4Q6wbw2u4OTY+QRSDWNSp3tiE syBe/y7uORjH2/YRZ3iMba7UCutBnK9IQqgV3eGlYO80HSiVfBGoXG2NIvo+8+hG7398pYWkr nJQt5FLRL6I9twkMltKh8xtkv1qe6k/JBiLKAtEzmYcjEfUfggWlgrvjzNeYflh78UVlPS89m pJ3P9T3f+JtlybJRLVf7NOEl3m+pr9p/J4miwkFnePg7rm8n59ooKOWGjqcmA8TUN9igKjbAY uGvDhqmHbuHNmXGVJ7bApnZxwgAvOQb3Md9P5EboFyUF6fIpYY4HPX6CnGtuMZV9lwSy5H0Jb 8z4eQEb Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 11 May 2017 17:33:14 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/hv/vmbus_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c index 6802d74f162c..96328aebae5a 100644 --- a/drivers/hv/vmbus_drv.c +++ b/drivers/hv/vmbus_drv.c @@ -1149,7 +1149,5 @@ struct hv_device *vmbus_device_create(const uuid_le *type, - if (!child_device_obj) { - pr_err("Unable to allocate device object for child device\n"); + if (!child_device_obj) return NULL; - } child_device_obj->channel = channel; memcpy(&child_device_obj->dev_type, type, sizeof(uuid_le)); -- 2.12.3