From: Mihail Atanassov <Mihail.Atanassov@arm.com>
To: "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
David Airlie <airlied@linux.ie>,
Liviu Dudau <Liviu.Dudau@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
nd <nd@arm.com>
Subject: Re: [v2] drm/komeda: Fix typos in komeda_splitter_validate
Date: Mon, 21 Oct 2019 14:02:56 +0000 [thread overview]
Message-ID: <5882846.nLqbd4GdRz@e123338-lin> (raw)
In-Reply-To: <20191016082255.GA18768@jamwan02-TSP300>
On Wednesday, 16 October 2019 09:23:03 BST james qian wang (Arm Technology China) wrote:
> On Mon, Sep 30, 2019 at 12:23:07PM +0000, Mihail Atanassov wrote:
> > Fix both the string and the struct member being printed.
> >
> > Changes since v1:
> > - Now with a bonus grammar fix, too.
> >
> > Fixes: 264b9436d23b ("drm/komeda: Enable writeback split support")
> > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com>
> > ---
> > drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> > index 950235af1e79..2b624bfe1751 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> > @@ -564,8 +564,8 @@ komeda_splitter_validate(struct komeda_splitter *splitter,
> > }
> >
> > if (!in_range(&splitter->vsize, dflow->in_h)) {
> > - DRM_DEBUG_ATOMIC("split in_in: %d exceed the acceptable range.\n",
> > - dflow->in_w);
> > + DRM_DEBUG_ATOMIC("split in_h: %d exceeds the acceptable range.\n",
> > + dflow->in_h);
>
> Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
Thanks for the review, applied to drm-misc-fixes -
8ae501e295cce9bc6e0dd82d5204a1d5faef44f8.
> > return -EINVAL;
> > }
> >
>
--
Mihail
prev parent reply other threads:[~2019-10-21 14:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 12:23 [PATCH v2] drm/komeda: Fix typos in komeda_splitter_validate Mihail Atanassov
2019-10-16 8:23 ` [v2] " james qian wang (Arm Technology China)
2019-10-21 14:02 ` Mihail Atanassov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5882846.nLqbd4GdRz@e123338-lin \
--to=mihail.atanassov@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=james.qian.wang@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox