From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751476AbdAVBbu (ORCPT ); Sat, 21 Jan 2017 20:31:50 -0500 Received: from mail-pg0-f44.google.com ([74.125.83.44]:36170 "EHLO mail-pg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751250AbdAVBbt (ORCPT ); Sat, 21 Jan 2017 20:31:49 -0500 Subject: Re: [PATCH 3/3] cpuidle/menu: add per cpu pm_qos_resume_latency consideration To: Daniel Lezcano , "Rafael J. Wysocki" References: <1484227624-6740-1-git-send-email-alex.shi@linaro.org> <1484227624-6740-4-git-send-email-alex.shi@linaro.org> <20170117093837.GA2085@mai> <01f9b016-0b7c-44ac-70e5-8cd9b8bd1500@linaro.org> <20170119102158.GA1827@mai> <20170120105428.GA1804@mai> Cc: Greg Kroah-Hartman , "Rafael J . Wysocki" , Vincent Guittot , Linux PM , Linux Kernel Mailing List , Ulf Hansson , Rasmus Villemoes , Arjan van de Ven , Rik van Riel From: Alex Shi Message-ID: <58840B80.7000808@linaro.org> Date: Sun, 22 Jan 2017 09:31:44 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20170120105428.GA1804@mai> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Yeah, that could be problematic. The code snippet gives the general idea but it > could be changed by for example by a flag telling the cpus when they enter idle > to update their state_count. Or something like that. Yes, this idea could be helpful. But since the idle path isn't a hot path. and a few memory access won't cost a lot. So I doubt if the benefit could be measurable. > > But if you think the patchset is fine, it is ok, we can improve things afterwards. >