From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750802AbdAWEDU (ORCPT ); Sun, 22 Jan 2017 23:03:20 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:48980 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750711AbdAWEDS (ORCPT ); Sun, 22 Jan 2017 23:03:18 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D9EF960769 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=rnayak@codeaurora.org Message-ID: <5885807E.7040500@codeaurora.org> Date: Mon, 23 Jan 2017 09:33:10 +0530 From: Rajendra Nayak User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Stephen Boyd , Stanimir Varbanov CC: mturquette@baylibre.com, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, sricharan@codeaurora.org Subject: Re: [PATCH] clk: qcom: gdsc: Fix handling of hw control enable/disable References: <1484027679-18397-1-git-send-email-rnayak@codeaurora.org> <3164de46-a251-3b3f-e6f5-5c3699bb4df8@linaro.org> <20170120232049.GB20800@codeaurora.org> In-Reply-To: <20170120232049.GB20800@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/21/2017 04:50 AM, Stephen Boyd wrote: > On 01/10, Stanimir Varbanov wrote: >> >>> + udelay(1); >>> + >>> + reg = sc->gds_hw_ctrl ? sc->gds_hw_ctrl : sc->gdscr; >>> + ret = gdsc_poll_status(sc, reg, 0); >> >> This should be gdsc_poll_status(sc, reg, true) because after disabling >> hw_control we expect that the GDSC is in power_on state. >> >>> + if (ret) >>> + return ret; >>> } >>> >>> if (sc->pwrsts & PWRSTS_OFF) >>> > > I expect this patch is going for v2? Yes, sorry, coming up shortly. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation