From: Wei Xu <xuwei5@hisilicon.com>
To: Mark Rutland <mark.rutland@arm.com>, Chen Feng <puck.chen@hisilicon.com>
Cc: <robh+dt@kernel.org>, <catalin.marinas@arm.com>,
<will.deacon@arm.com>, <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<puck.chen@foxmail.com>, <dan.zhao@hisilicon.com>,
<suzhuangluan@hisilicon.com>, <saberlily.xia@hisilicon.com>,
<xuyiping@hisilicon.com>, <qijiwen@hisilicon.com>,
Linuxarm <linuxarm@huawei.com>
Subject: Re: [V2 2/2] arm64: dts: Add dts files for Hisilicon Hi3660 SoC
Date: Mon, 23 Jan 2017 14:03:27 +0000 [thread overview]
Message-ID: <58860D2F.6070007@hisilicon.com> (raw)
In-Reply-To: <20170123134656.GC16286@leverpostej>
Hi Mark,
On 2017/1/23 13:46, Mark Rutland wrote:
> On Tue, Jan 10, 2017 at 03:55:15PM +0800, Chen Feng wrote:
>> + memory@0 {
>> + device_type = "memory";
>> + reg = <0x0 0x00400000 0x0 0xbfe00000>;
>> + };
>
> The unit-address here is incorrect. The base address of this memory is
> not zero.
>
>> + timer {
>> + compatible = "arm,armv8-timer";
>> + interrupt-parent = <&gic>;
>> + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
>> + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
>> + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>,
>> + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>;
>> + clock-frequency = <1920000>;
>> + };
>
> This clock-frequency property should not be required; please remove it.
>
> Your FW should program CNTFRQ_EL0 with the timer frequency.
Thanks!
Hi Chen Feng,
Can you send out the v3 to address above comments?
And I will pick up it soon.
Best Regards,
Wei
>
> Thanks,
> Mark.
>
> .
>
next prev parent reply other threads:[~2017-01-23 14:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 7:55 [V2 1/2] document: dt: add binding for Hi3660 SoC Chen Feng
2017-01-10 7:55 ` [V2 2/2] arm64: dts: Add dts files for Hisilicon " Chen Feng
2017-01-23 13:46 ` Mark Rutland
2017-01-23 14:03 ` Wei Xu [this message]
2017-01-23 14:13 ` Sudeep Holla
2017-01-20 14:56 ` [V2 1/2] document: dt: add binding for " Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58860D2F.6070007@hisilicon.com \
--to=xuwei5@hisilicon.com \
--cc=catalin.marinas@arm.com \
--cc=dan.zhao@hisilicon.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=puck.chen@foxmail.com \
--cc=puck.chen@hisilicon.com \
--cc=qijiwen@hisilicon.com \
--cc=robh+dt@kernel.org \
--cc=saberlily.xia@hisilicon.com \
--cc=suzhuangluan@hisilicon.com \
--cc=will.deacon@arm.com \
--cc=xuyiping@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox