From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751176AbdAYBzW (ORCPT ); Tue, 24 Jan 2017 20:55:22 -0500 Received: from mga04.intel.com ([192.55.52.120]:35596 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750966AbdAYBzV (ORCPT ); Tue, 24 Jan 2017 20:55:21 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,281,1477983600"; d="scan'208";a="56880627" Message-ID: <58880514.6060105@intel.com> Date: Wed, 25 Jan 2017 09:53:24 +0800 From: Jike Song User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Alex Williamson CC: zhi.a.wang@intel.com, zhenyuw@linux.intel.com, jani.nikula@linux.intel.com, airlied@linux.ie, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, igvt-g-dev@ml01.01.org, daniel.vetter@intel.com Subject: Re: [PATCH] drm/i915/gvt/kvmgt: mdev ABI is available_instances, not available_instance References: <20170124195239.10061.54664.stgit@gimli.home> In-Reply-To: <20170124195239.10061.54664.stgit@gimli.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/25/2017 03:53 AM, Alex Williamson wrote: > Per the ABI specification[1], each mdev_supported_types entry should > have an available_instances, with an "s", not available_instance. > > [1] Documentation/ABI/testing/sysfs-bus-vfio-mdev > > Signed-off-by: Alex Williamson > --- > > This should really be fixed before initial release in v4.10 Acked-by: Jike Song Thanks for finding this! -- Thanks, Jike > > drivers/gpu/drm/i915/gvt/kvmgt.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c > index faaae07..ab1e057 100644 > --- a/drivers/gpu/drm/i915/gvt/kvmgt.c > +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c > @@ -230,8 +230,8 @@ static struct intel_vgpu_type *intel_gvt_find_vgpu_type(struct intel_gvt *gvt, > return NULL; > } > > -static ssize_t available_instance_show(struct kobject *kobj, struct device *dev, > - char *buf) > +static ssize_t available_instances_show(struct kobject *kobj, > + struct device *dev, char *buf) > { > struct intel_vgpu_type *type; > unsigned int num = 0; > @@ -269,12 +269,12 @@ static ssize_t description_show(struct kobject *kobj, struct device *dev, > type->fence); > } > > -static MDEV_TYPE_ATTR_RO(available_instance); > +static MDEV_TYPE_ATTR_RO(available_instances); > static MDEV_TYPE_ATTR_RO(device_api); > static MDEV_TYPE_ATTR_RO(description); > > static struct attribute *type_attrs[] = { > - &mdev_type_attr_available_instance.attr, > + &mdev_type_attr_available_instances.attr, > &mdev_type_attr_device_api.attr, > &mdev_type_attr_description.attr, > NULL, >