From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751803AbdAYN1L (ORCPT ); Wed, 25 Jan 2017 08:27:11 -0500 Received: from smtpbgbr2.qq.com ([54.207.22.56]:43133 "EHLO smtpbgbr2.qq.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751574AbdAYN1J (ORCPT ); Wed, 25 Jan 2017 08:27:09 -0500 X-QQ-mid: esmtp20t1485350819tq0rfa1li X-QQ-SSF: 01000000000000604G100000000000V X-QQ-FEAT: PML9g4LxpBpEDA5gDbu6Y+ggCV6GvPjZmD8ncR6tYe5wMrI7spCsSR1NUdcOx TcjVyFJX3QyOuO3598nzlouNVR1cO9S9jkxqrc7D7vmYq6wfz9OhsH4QviD+b+eD+0x3Kbh TrYAETq7rLA2+qI4dUgWOjndqKQQz0NceGz/7vpnkhVd1K+Oq1qIg9ICH58wOhaPkV2SSf5 LHUQeAc+akwWA0m1me7tYsinH9e2UmuqSUmKZG3mjGWQbX6Pg4mQOUqzy5vlfom1U2oRoK+ GlRA== X-QQ-GoodBg: 0 Subject: Re: [PATCH] mm/migration: make isolate_movable_page always defined To: Michal Hocko , Yisheng Xie References: <1485340563-60785-1-git-send-email-xieyisheng1@huawei.com> <20170125120115.GL32377@dhcp22.suse.cz> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, n-horiguchi@ah.jp.nec.com, akpm@linux-foundation.org, minchan@kernel.org, vbabka@suse.cz, guohanjun@huawei.com, qiuxishi@huawei.com From: Yisheng Xie Message-ID: <5888A7A2.9060907@foxmail.com> Date: Wed, 25 Jan 2017 21:26:58 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20170125120115.GL32377@dhcp22.suse.cz> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-QQ-SENDSIZE: 520 Feedback-ID: esmtp:foxmail.com:bgforeign:bgforeign1 X-QQ-Bgrelay: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Michal, Thanks for reviewing. On 01/25/2017 08:01 PM, Michal Hocko wrote: > On Wed 25-01-17 18:36:03, Yisheng Xie wrote: >> Define isolate_movable_page as a static inline function when >> CONFIG_MIGRATION is not enable. It should return false >> here which means failed to isolate movable pages. >> >> This patch do not have any functional change but to resolve compile >> error caused by former commit "HWPOISON: soft offlining for non-lru >> movable page" with CONFIG_MIGRATION disabled. >> >> Signed-off-by: Yisheng Xie >> --- >> include/linux/migrate.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/include/linux/migrate.h b/include/linux/migrate.h >> index ae8d475..631a8c8 100644 >> --- a/include/linux/migrate.h >> +++ b/include/linux/migrate.h >> @@ -56,6 +56,8 @@ static inline int migrate_pages(struct list_head *l, new_page_t new, >> free_page_t free, unsigned long private, enum migrate_mode mode, >> int reason) >> { return -ENOSYS; } >> +static inline bool isolate_movable_page(struct page *page, isolate_mode_t mode) >> + { return false; } > OK, so we return false here which will make __soft_offline_page return > true all the way up. Is this really what we want? Don't we want to > return EBUSY in that case? The error code propagation here is just > one big mess. That's right, my stupid coding really make a big mess here. I will make another version for patch "HWPOISON: soft offlining for non-lru movable page" to avoid that. Thanks Yisheng Xie. >> >> static inline int migrate_prep(void) { return -ENOSYS; } >> static inline int migrate_prep_local(void) { return -ENOSYS; } >> -- >> 1.7.12.4 >>