From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753338AbdA3WTg (ORCPT <rfc822;w@1wt.eu>);
        Mon, 30 Jan 2017 17:19:36 -0500
Received: from fllnx210.ext.ti.com ([198.47.19.17]:39981 "EHLO
        fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751950AbdA3WTf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 30 Jan 2017 17:19:35 -0500
Subject: Re: [PATCH] phy: qcom-ufs: Fix misplaced jump label
To: Vivek Gautam <vivek.gautam@codeaurora.org>
References: <1485504619-31886-1-git-send-email-vivek.gautam@codeaurora.org>
CC: <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        Subhash Jadavani <subhashj@codeaurora.org>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        <stable@vger.kernel.org>
From: Kishon Vijay Abraham I <kishon@ti.com>
Message-ID: <588B01BB.6050206@ti.com>
Date: Fri, 27 Jan 2017 13:45:55 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <1485504619-31886-1-git-send-email-vivek.gautam@codeaurora.org>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On Friday 27 January 2017 01:40 PM, Vivek Gautam wrote:
> We want to skip only tx/rx_iface clocks and not ref_clk_src
> as well. Fix the jump label accordingly.
> 
> Fixes: 300f96771d78 ("phy: qcom-ufs: Skip obtaining rx/tx_iface_clk for msm8996 based phy")

merged, thanks.

-Kishon
> 
> Cc: Subhash Jadavani <subhashj@codeaurora.org>
> Cc: Martin K. Petersen <martin.petersen@oracle.com>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
> ---
> 
> Based on linux-phy next.
> 
>  drivers/phy/phy-qcom-ufs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c
> index c69568b8543d..1aee8723a682 100644
> --- a/drivers/phy/phy-qcom-ufs.c
> +++ b/drivers/phy/phy-qcom-ufs.c
> @@ -189,12 +189,12 @@ int ufs_qcom_phy_init_clks(struct ufs_qcom_phy *phy_common)
>  	if (err)
>  		goto out;
>  
> +skip_txrx_clk:
>  	err = ufs_qcom_phy_clk_get(phy_common->dev, "ref_clk_src",
>  				   &phy_common->ref_clk_src);
>  	if (err)
>  		goto out;
>  
> -skip_txrx_clk:
>  	/*
>  	 * "ref_clk_parent" is optional hence don't abort init if it's not
>  	 * found.
>