Re: [PATCH v2 2/2] PM / devfreq: Add suspend frequency support

[Chanwoo Choi <cw00.choi@samsung.com>]

Hi Viresh,

On 2017년 01월 30일 13:50, Viresh Kumar wrote:
> On Wed, Dec 28, 2016 at 5:37 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>> +++ b/drivers/devfreq/devfreq.c
>> @@ -620,6 +620,23 @@ struct devfreq *devfreq_add_device(struct device *dev,
>>                 goto err_init;
>>         }
>>
>> +       /*
>> +        * Get the suspend frequency from OPP table. But the devfreq device
>> +        * using passive governor don't need to get the suspend frequency
>> +        * because the passive devfreq device depend on the parent devfreq
>> +        * device.
>> +        */
>> +       devfreq->suspend_freq = 0L;
>> +       if (strncmp(devfreq->governor_name, "passive", 7)) {
>> +               struct dev_pm_opp *opp;
>> +
>> +               rcu_read_lock();
>> +               opp = dev_pm_opp_get_suspend_opp(dev);
>> +               if (opp)
>> +                       devfreq->suspend_freq = dev_pm_opp_get_freq(opp);
> 
> The interface has changed a bit recently. Can you please use below
> function instead ?

I knew. This patch posted before applying your patch.

> 
> dev_pm_opp_get_suspend_opp_freq()

This patch has not yet reviewed by devfreq maintainer.
So, I'm just waiting the review.

But, this patch is wrong on latest opp patches.
I'll fix it and resend it.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics