From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754727AbdAaArB (ORCPT ); Mon, 30 Jan 2017 19:47:01 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:45198 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754634AbdAaAq2 (ORCPT ); Mon, 30 Jan 2017 19:46:28 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: b6c32a2d-f79836d00000138e-e6-588fdb64de74 Content-transfer-encoding: 8BIT Message-id: <588FDB63.2080105@samsung.com> Date: Tue, 31 Jan 2017 09:33:39 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Viresh Kumar Cc: MyungJoo Ham , Kyungmin Park , hl@rock-chips.com, tjakobi@math.uni-bielefeld.de, chanwoo@kernel.org, "Rafael J. Wysocki" , Linux PM list , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 2/2] PM / devfreq: Add suspend frequency support In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGJsWRmVeSWpSXmKPExsWy7bCmum7q7f4IgwffGS0m3rjCYvFjwylm i7NNb9gtLu+aw2bxufcIo8XtxhVsFmdOX2K1aFv9gdVi41cPB06PTas62TzuXNvD5vHvGLvH lqvtLB5/Z+1n8ejbsorR4/MmuQD2qFSbjNTElNQihdS85PyUzLx0WyXv4HjneFMzA0NdQ0sL cyWFvMTcVFslF58AXbfMHKDDlBTKEnNKgUIBicXFSvp2NkX5pSWpChn5xSW2StGGhkZ6hgbm ekZGRnomxrFWRqZAJQmpGRfvtTAVvOaq2LnvGksD4y32LkZODgkBE4lFNzrYIGwxiQv31gPZ XBxCAksZJTrmLGeBcNqZJNZ3HGSD6Zi69yATRGIOo8TCH2tYQBK8AoISPybfA7I5OJgF5CWO XMoGCTMLaEq8+DIJatA9Ronjuz6xQ9RrSbS2zQOzWQRUJXrOzwKbwwYU3//iBtgyfgFFias/ HjOC2KICERI7539jB5kvAlTz8mYqyExmgW1MErdO7GcCqREWcJfYuW4+mM0pECzxY9UEsHck BM6xS9zr7WcEaZYQkJXYdIAZ4hkXic4De1khbGGJV8e3QINFWuLv0luMEL3djBJrXjaxQjg9 jBKNa45Cg8JY4v6De8wQb/JJ9P5+wgSxgFeio00IosRD4nb3ekYI21Fi39xZzNCQY5LYuuwx 2wRGhVlIgTcLEXizkAJvASPzKkax1ILi3PTUYtMCI73ixNzi0rx0veT83E2M4DSqpbuD8csC 70OMAhyMSjy8Br39EUKsiWXFlbmHGCU4mJVEePfcAArxpiRWVqUW5ccXleakFh9iNAWG/URm KdHkfGCKzyuJNzQxMzQxsgRCc0NzJXHeBRXWEUIC6YklqdmpqQWpRTB9TBycUg2MK0I567hf 7+b0Fp+wK+eIz/3vM+2LthXsYKx5LHH56PNH09yKYqKSfide2jVlWxH3TvfIuF4tNY+rHosD Qw9YXUk2+zOlz7Kzon1Oju31urCXWgm7c+MMijsfNoQ8frj/yBFlPb3L32rEuZXeRciwfb56 vC5ca8umTUum392XsX9PmZXV/qdnlViKMxINtZiLihMBl3WVlbkDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrPIsWRmVeSWpSXmKPExsVy+t9jQd3k2/0RBl9eG1pMvHGFxeLHhlPM Fmeb3rBbXN41h83ic+8RRovbjSvYLM6cvsRq0bb6A6vFxq8eDpwem1Z1snncubaHzePfMXaP LVfbWTz+ztrP4tG3ZRWjx+dNcgHsUW42GamJKalFCql5yfkpmXnptkqhIW66FkoKeYm5qbZK Ebq+IUFKCmWJOaVAnpEBGnBwDnAPVtK3S3DLuHivhangNVfFzn3XWBoYb7F3MXJySAiYSEzd e5AJwhaTuHBvPVsXIxeHkMAsRomdp+6DFfEKCEr8mHyPpYuRg4NZQF7iyKVsCFNdYsqUXIjy B4wSm08sgyrXkmhtmwdmswioSvScn8UCYrMBxfe/uMEGYvMLKEpc/fGYEWSOqECERPeJShBT BKjk5c1UkJHMAjuYJBbNWMMIUi4s4C6xc918Johd85gkGl6cBJvJKRAscevKRaYJjIKzkFw6 C+HSWQiXLmBkXsUokVqQXFCclJ5rlJdarlecmFtcmpeul5yfu4kRHJnPpHcwHt7lfohRgINR iYdXo60/Qog1say4MvcQowQHs5II754bQCHelMTKqtSi/Pii0pzU4kOMpkCvTmSWEk3OByaN vJJ4QxNzE3NjAwtzS0sTIyVx3sbZz8KFBNITS1KzU1MLUotg+pg4OKUaGHc+3i9aYr/7SpS8 gZvHGoVItocVdx7v4Ga/dUz4mkatt868qqJLPsbHNwpdOetwWrCndN2m/zuK/Y4ozhCxTL58 I+iIrTWX4NOoCQ4bavQPTfv5gtNY3XPbl+03L+1e/zA6dUm865XT1698M9vlfPTp6vQlp7W+ rShtVzm0K3L3lK2mwZ47l11XYinOSDTUYi4qTgQAnTPM5eICAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170131003339epcas5p19fb9d651b06b093cf7862d65961c90dc X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS/ssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTNS9TZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20161228120710epcas5p25597b14fdf1dce59f2bc185d0f5f5401 X-RootMTR: 20161228120710epcas5p25597b14fdf1dce59f2bc185d0f5f5401 References: <1482926828-19746-1-git-send-email-cw00.choi@samsung.com> <1482926828-19746-3-git-send-email-cw00.choi@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Viresh, On 2017년 01월 30일 13:50, Viresh Kumar wrote: > On Wed, Dec 28, 2016 at 5:37 PM, Chanwoo Choi wrote: >> +++ b/drivers/devfreq/devfreq.c >> @@ -620,6 +620,23 @@ struct devfreq *devfreq_add_device(struct device *dev, >> goto err_init; >> } >> >> + /* >> + * Get the suspend frequency from OPP table. But the devfreq device >> + * using passive governor don't need to get the suspend frequency >> + * because the passive devfreq device depend on the parent devfreq >> + * device. >> + */ >> + devfreq->suspend_freq = 0L; >> + if (strncmp(devfreq->governor_name, "passive", 7)) { >> + struct dev_pm_opp *opp; >> + >> + rcu_read_lock(); >> + opp = dev_pm_opp_get_suspend_opp(dev); >> + if (opp) >> + devfreq->suspend_freq = dev_pm_opp_get_freq(opp); > > The interface has changed a bit recently. Can you please use below > function instead ? I knew. This patch posted before applying your patch. > > dev_pm_opp_get_suspend_opp_freq() This patch has not yet reviewed by devfreq maintainer. So, I'm just waiting the review. But, this patch is wrong on latest opp patches. I'll fix it and resend it. -- Best Regards, Chanwoo Choi Samsung Electronics