Re: [PATCH v6 32/42] drm/mediatek: mtk_hdmi: Cleanup function mtk_hdmi_resume()

CK Hu (胡俊光)
2025-02-13T07:57:29Z

On Tue, 2025-02-11 at 12:33 +0100, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
>
>
> Remove the error print in case of mtk_hdmi_clk_enable_audio()
> failures: since the APIs will already print on their own, having
> one in there is redundant.

Reviewed-by: CK Hu <ck.hu@mediatek.com>

>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index 53c28737ac2a..8f31363c5522 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -1704,15 +1704,8 @@ static __maybe_unused int mtk_hdmi_suspend(struct device *dev)
> static __maybe_unused int mtk_hdmi_resume(struct device *dev)
> {
> struct mtk_hdmi *hdmi = dev_get_drvdata(dev);
> - int ret = 0;
>
> - ret = mtk_hdmi_clk_enable_audio(hdmi);
> - if (ret) {
> - dev_err(dev, "hdmi resume failed!\n");
> - return ret;
> - }
> -
> - return 0;
> + return mtk_hdmi_clk_enable_audio(hdmi);
> }
>
> static SIMPLE_DEV_PM_OPS(mtk_hdmi_pm_ops, mtk_hdmi_suspend, mtk_hdmi_resume);
> --
> 2.48.1
>