Re: [PATCH v6 37/42] drm/mediatek: mtk_hdmi_common: Assign DDC adapter pointer to bridge

CK Hu (胡俊光)
2025-02-14T05:10:46Z

On Thu, 2025-02-13 at 11:38 +0100, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
>
>
> Il 13/02/25 10:20, CK Hu (胡俊光) ha scritto:
> > On Tue, 2025-02-11 at 12:34 +0100, AngeloGioacchino Del Regno wrote:
> > > External email : Please do not click links or open attachments until you have verified the sender or the content.
> > >
> > >
> > > In preparation for adding the new HDMI TX v2 IP driver, assign the
> > > pointer to the DDC adapter to struct drm_bridge during probe.
> >
> > I could not find where to use hdmi->bridge.ddc in the patch of adding hdmi v2.
> > Could you describe more about where or which function would use this?
> >
>
> I have already replied to this exact question a long time ago.
>
> https://lore.kernel.org/all/b5a77637-64b0-4ed3-9619-e76d094505af@collabora.com/

Sorry, I forget this.

Reviewed-by: CK Hu <ck.hu@mediatek.com>

>
> Regards,
> Angelo
>
> > Regards,
> > CK
> >
> > >
> > > This commit brings no functional changes.
> > >
> > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > > ---
> > > drivers/gpu/drm/mediatek/mtk_hdmi_common.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_common.c b/drivers/gpu/drm/mediatek/mtk_hdmi_common.c
> > > index 5ea45608921c..2c91f65f26fa 100644
> > > --- a/drivers/gpu/drm/mediatek/mtk_hdmi_common.c
> > > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_common.c
> > > @@ -411,6 +411,7 @@ struct mtk_hdmi *mtk_hdmi_common_probe(struct platform_device *pdev)
> > > hdmi->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID
> > > | DRM_BRIDGE_OP_HPD;
> > > hdmi->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
> > > + hdmi->bridge.ddc = hdmi->ddc_adpt;
> > > hdmi->bridge.vendor = "MediaTek";
> > > hdmi->bridge.product = "On-Chip HDMI";
> > >
> > > --
> > > 2.48.1
> > >
> >
>
>