From: "Alex G." <mr.nuke.me@gmail.com>
To: Vasanthakumar Thiagarajan
<vasanthakumar.thiagarajan@oss.qualcomm.com>,
jjohnson@kernel.org, ath11k@lists.infradead.org,
Jeff Johnson <jeff.johnson@oss.qualcomm.com>
Cc: baochen.qiang@oss.qualcomm.com, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] wifi: ath11k: move .max_tx_ring to struct ath11k_hw_hal_params
Date: Wed, 14 Jan 2026 15:29:53 -0600 [thread overview]
Message-ID: <5896283.e9J7NaK4W3@nukework.gtech> (raw)
In-Reply-To: <c8456b52-f14c-4bcf-9385-580e9607219d@oss.qualcomm.com>
On Wednesday, January 14, 2026 11:24:19 AM CST Jeff Johnson wrote:
> On 1/12/2026 11:00 PM, Vasanthakumar Thiagarajan wrote:
> > On 12/28/2025 8:44 PM, Alexandru Gagniuc wrote:
> >> ".max_tx_ring" is an upper bounds to indexing ".tcl2wbm_rbm_map". It
> >> is initialized in, core.c, a different file than the array. This
> >> spaghetti-like relation is fragile and not obvious. Accidentally
> >> setting ".max_tx_ring" too high leads to a hard to track out-of-
> >> bounds access and memory corruption.
> >>
> >> There is a small ambiguity on the meaning of "max_tx_ring":
> >> - The highest ring, max=3 implies there are 4 rings (0, 1, 2, 3)
> >> - The highest number to use for array indexing (there are 3 rings)
> >>
> >> Clarify this dependency by moving ".max_tx_ring" adjacent to the array
> >> ".tcl2wbm_rbm_map", and name it "num_tx_rings". Use ARRAY_SIZE()
> >> instead of #defines to initialize the length field.
> >>
> >> The ath11k_hw_hal_params_qca6390 uses fewer num_tx_rings than its map,
> >> so use a constant to express the correct value. Add a static_assert()
> >> to fail compilation if the constant is accidentally set too high.
> >
> > Text related to static_assert to be removed accordingly.
>
Hi Jeff,
> I removed the last sentence in 'pending', please check:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git/commit/?h=pendin
> g&id=26bb149b5e011b0f73f7b74421589cbd38e3304b
Re-reading the commit message, I think it makes sense to also remove the
sentence "The ath11k_hw_hal_params_qca6390 uses fewer num_tx_rings than its
map, so use a constant to express the correct value.". Do you think it's worth
submitting a v4 with this minor change?
Alex
> >> The intent is to make the code easier to understand rather than fix
> >> an existing bug.
> >>
> >> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
> >
> > With the above minor comment addressed.
> >
> > Reviewed-by: Vasanthakumar Thiagarajan
> > <vasanthakumar.thiagarajan@oss.qualcomm.com>
next prev parent reply other threads:[~2026-01-14 21:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-28 15:14 [PATCH v3] wifi: ath11k: move .max_tx_ring to struct ath11k_hw_hal_params Alexandru Gagniuc
2025-12-29 3:14 ` Baochen Qiang
2026-01-13 7:00 ` Vasanthakumar Thiagarajan
2026-01-14 17:24 ` Jeff Johnson
2026-01-14 21:29 ` Alex G. [this message]
2026-01-14 21:59 ` Jeff Johnson
2026-01-15 4:43 ` Alex G.
2026-01-16 1:26 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5896283.e9J7NaK4W3@nukework.gtech \
--to=mr.nuke.me@gmail.com \
--cc=ath11k@lists.infradead.org \
--cc=baochen.qiang@oss.qualcomm.com \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=jjohnson@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=vasanthakumar.thiagarajan@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox