From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754518AbdBFQKJ (ORCPT ); Mon, 6 Feb 2017 11:10:09 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:50170 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753676AbdBFQKG (ORCPT ); Mon, 6 Feb 2017 11:10:06 -0500 Subject: Re: [PATCH net-next v1 7/7] bpf: Always test unprivileged programs To: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= , References: <20170205231428.23846-1-mic@digikod.net> <20170205231428.23846-7-mic@digikod.net> CC: , Daniel Borkmann , "Shuah Khan" , Arnaldo Carvalho de Melo From: Alexei Starovoitov Message-ID: <58989FA0.7000906@fb.com> Date: Mon, 6 Feb 2017 08:09:04 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20170205231428.23846-7-mic@digikod.net> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2620:10d:c090:200::8:4f6c] X-ClientProxiedBy: DM3PR14CA0094.namprd14.prod.outlook.com (10.166.157.20) To BL2PR15MB0961.namprd15.prod.outlook.com (10.167.116.23) X-MS-Office365-Filtering-Correlation-Id: c29cbd41-da55-4f11-0d3b-08d44eaa7c0a X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BL2PR15MB0961; X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB0961;3:foOMhXZuuhoPgA4TyEe94TuCIOt3yA5NtFxowvIesGdq+GfIwY2i8EtkWpzrgp098OeAr/REfat0Fj/U03NHAbGvkpY1YVnplSDRbMiM6jpbHLgqOMnehXA5ov4AXpm+OCAOqYvcdAoXHDvaYniN5NriXDPRiXxBoK1DifPJs5fwZbq8a25j+zOBbdcNOWyigGQz5Aw6M1a5C1ZRarFqNNzQON9FoTszKTBJwPQHLZPXbDBVVJkw2uuRCXx7RGJWg4h8upzJlh1nX7ht0HeF6g==;25:fNjNTV1qtQavPB/aLZptmBrzB7Ir2VKilJBR9GIP9lILF0/u8v8th/5ekk98SDfDGjJr2wPnEoWTlpqXpz0cYuV1/UdmKscPmtlgxGjzWEjULRUrron8OO5cPsNg4cYYs7jNkKKkZ4FtB7WQvm5sVKQQ/O4j2Nz13pVzAvH4Bv/Ib38DWQkkF02TZam5D3BdXRkJqZL2LPeLxtyJy9BpofV1L/MSWOuJoVdSN0vuK35dVyN3bpBNzFXFw19DFxopsoLMSZ79ep/TSzDEF0/IabSI8qDY17rnTfUP27IUg2IA3m0JHmfwmJvd7VD+7024lF6pDjn2pr9IbSTE90YigDKDxj7e9qqrHQTkfvc8oYRFDj+Wo+CD8+jgRF+yXPPh1uSaAA3SbSSgTxNGmU87hFAExCXny/kPDYA3kqq0t/OgrgOaKgF/pcnQcofsXrFMOpxBi4Sc/+K+fRaYmgHUmA== X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB0961;31:HqpTkffm9bdIJxhZgtmn7oTbxo228OPVF3P3hwFAiShghRFWYr+0W92TchXyxgpHap8B2BjFGpsElDk/OX0Actr0DBcriEvMFkSfw7Oed0/vV5wMJndJ0pYg5x0YlE/sCKrhky6zhBtzggWwbdmmpirUUmfGymvIxfTZUpxGzODg8r3P247oZSGh6JeA6qRLcGIWKBeC7dLce0kEghwLaFhgmH3qNaZAmANo1xwsw5MDsfXq2e44m4mPmXyy2PW+Zy3R5cyUFuIKwCAuv+PEI82zNJo2W36wzwUGKXVqELg=;20:tRtpJu3CVjtf/qPkvVQr6TJMeqTO6kNRd0fuRREi8ySe0FzdMVlFU3Bz3WXj/jQtYZItBq27fijstIJV9dGy5y/PX2Qd2ZPBdd8KDPrr/5f7aqRGkX+tWICfJqdm8e9JKgNSr27pEFQ+ntlxWNO0U7ZIFMRkeZeMTROvLfOMLODuv03jjShYoiYX4ZhUEkAz+zlIsvaPBotpCDediq3z2PvTT3stqwYnWktLwH8ugsAf8HeeGAipcm8y3mIkJj8h4CBeBuhN7t1taQnxK2AHvYKDg6hcZPkePwncz9AA7Hv8qjOHvPF48VqQSuoHHNeQ5coitRyx/31Zf9zx50ZSFpeo/+4knF6mbS8BIm41VBQVWN3KaRNrLitKDpwh8awYtwtaQHdXDKLwFUT8rO5ogpLZ9NFwZD9BG9LPHRs61zs7H13361OHTTJ7Cj3keqwO46rDmpKi6UpifI+mmY63jwo4076YZX+4FOyI3eSA5ZMLMQR3ZNhQWjWcU9n859Om X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(20170203043)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123558025)(20161123560025)(20161123564025)(20161123555025)(20161123562025)(6072148);SRVR:BL2PR15MB0961;BCL:0;PCL:0;RULEID:;SRVR:BL2PR15MB0961; X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB0961;4:nuHpWMCU+R86agicb9aDVToFPPRqW8G+bL7X8mFjSAPtxFq4ZqtX4r0yElVjY+YtoVAtMxeDgxkSDuEKWfHKvrs2jRHEKGqH6pyKrI5P/b4TneVcU9h0aBKDZuU5wi2IApnrSWBzdhexU9m7lqWdEkpgX8zrMuS8nr7TFplHA1sxFJ2FGmW2a6GPuBo9AkVjuLppeyITOhrOy3t3cqnWjdbZmRH9lYraoOliO/2EBvxnNZmcaf+nDnZaniRtbdl/JpYIlpjZquUJ63iDF/S+KcmU/VeIu2z11a3dX11d/a2Ea0Tb6zIMMG8vFtr/kOj2QFUd34oPHA3B9MI8VnIsx0GD2Kl7+n4Zmdl+3hBQiN6s7o4mhS1iUHIaoP5u5fHh7llrFSDIyc+grOGYdhXZppQBqki5iVoattiYsqvY5aJR7DUMk6pjBOW43H3pEZZ0kzRvU7uE3s8quW4fcVPfydOOOq2p5sgH7ukp4njWfm/bNVXoGkhk+q2b6KkxzBXGqdN14uY9yINueS29Z/CRNwDEb4yol6UJiSKao36iOZVXFlvwpEtSAnQSyqOpB/vXsh/q9YtI48HHzLtZXrDlxn5fDqfLmgmqzpOc6CjMI4/tPDPn62xXavUn8GrbfMrrRwxgXXGyaT6TD5at93DW5g== X-Forefront-PRVS: 0210479ED8 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(39450400003)(39410400002)(39830400002)(189002)(199003)(377454003)(24454002)(50986999)(6486002)(106356001)(105586002)(36756003)(38730400001)(6666003)(229853002)(65816999)(68736007)(33656002)(2950100002)(54356999)(101416001)(42186005)(76176999)(87266999)(53936002)(54906002)(25786008)(59896002)(47776003)(80316001)(23676002)(6246003)(53546003)(50466002)(65956001)(65806001)(8676002)(64126003)(305945005)(1706002)(81156014)(189998001)(4326007)(81166006)(7736002)(6116002)(92566002)(97736004)(5660300001)(86362001)(5001770100001)(99136001)(4001350100001)(2906002)(2870700001)(83506001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:BL2PR15MB0961;H:[IPv6:2620:10d:c082:1055:d8e3:f959:da6e:5859];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTDJQUjE1TUIwOTYxOzIzOi9KYnFHWThpMXZzc2xvSGg3WTBTUWVVSk12?= =?utf-8?B?TTVWRUFCSlJONHpMWVh0VFFRcjNNYnBTb1djc2ZpNGthWXhQamo2cmZqYnVQ?= =?utf-8?B?WXN5L1E2ZzRwcHN1bW9XWjRyV1R6U2t1WEJBb1U4aVowaUVTdzRhVHFBU293?= =?utf-8?B?SnFBbExNc21PdjJwRTFGUzlaVE9SeVRpcG9JRTAzTXlMZHVUUTJ6czJBSzY0?= =?utf-8?B?eDZaTnRZUy9BMWhGbVFTZzhXRFhMSVU5OWRsb0JpSVRVY2VaZVZiOC8rWkll?= =?utf-8?B?dVBCa1h1dXprZ1hqSFVMdUt3QlpLbURWREI2NTh2R3hIR294SG0vQnBzNEw2?= =?utf-8?B?OTRpWkdpR0VsQW5KbkRoQnhqY2FZUHlPck16SnRhQzFJVjdueGZZMXplTEZp?= =?utf-8?B?TWtNVFN6Nkk5QUdhUGRlSVFXQW1UeGN5STAvWWhKL3B0TXZ3bHpjY1AzUzVR?= =?utf-8?B?ZjMveHlkRzZGQklsTGZDQnRzSHdlbVozd0RqZ3ZoazZ2bm5BWUt3alJpREx5?= =?utf-8?B?VUFoNFMyQ2xwYjYxVFROd0RaYTh6aEwzOTNBVGc0REZ1R051cDM0UjU3RlIv?= =?utf-8?B?ZXdwa01YVldnVndYRVpKM0x2bkVrNlRhaEw2bm1MV3ZWWVdUNVM3N1ZwWlVV?= =?utf-8?B?VG44NW8ydUtNZjdXWmgydWpzcHgrOVpGOTZSdFgzU3hQRU4wb0EyN2kxSlhM?= =?utf-8?B?TWpDNXFoNmphamNtN205Lzh5czdrNENmQ2JKYTBVWnFkU0ZOV3FOM0lpWE1W?= =?utf-8?B?SFJFcktjOGZVbDJhbGFrUXFId292TEZlZ29UdEZsWVRQa2JobnBLcjRZL0hO?= =?utf-8?B?VkJablMvK0xlY3orUWxDUEU1SFlWK09IM21ZUTRaemJkaE9DVU83NDd4aURN?= =?utf-8?B?ME9VdUdjazdwY3VNd1NaWGh4bWc1TktsbDF2Q0J6MVZ6SDgrcXd3TFhyRjVm?= =?utf-8?B?SisvQXZjRTFaR1FVb01TeVQwQ2d6TVBnWm1WMlNoYXlpVlpRWkJoTndCeTls?= =?utf-8?B?MlUvNWY4azBXaUIxTEhVdGdHcGdQVFBJWk0wRDBuRkEwWUtXaXV1OGtIcFM3?= =?utf-8?B?U3RvWkxzb1h3ME9kWmdwcUFrNFllK2VIcW13QlNiWW91am1pOGZXa1AyY1Ey?= =?utf-8?B?VlFJcm9WN1NkQkw0cHhUTFJEUjF6Qjh2NFk1NU84elF6MGg5Zy9LTCttV3Fu?= =?utf-8?B?aDVFK2ZSR3I1NkQ5cGRqT3B0T1hlWmVmUjdPdzhvaU85TDhWSTRyR0FjbnJh?= =?utf-8?B?ZFNsVERLZThYTVBCYjZpbUwrUjAzYkFqM0FBQnpSUjFEL3dmVmc5TzBhQ2o4?= =?utf-8?B?ZUJDNXNWbkppKzM2ck54cUIyVjJKWXdacUNzeG9aVzFPTTJlWWNRanpMOFhp?= =?utf-8?B?cTk3VDU5Z3AyaVhYTEpDejdCaHJ1UlBhbmkzRll5cGNHR3NLMlNLZ3NGbjZD?= =?utf-8?B?UjNCODRBWHd5dkhkN1NaNEZsZ0diQ1pDTzRlYmdnVDNjRkpMaVpqSldJZHl1?= =?utf-8?B?Y1c0MjA5QTVRNDE0bTI2MkVVMUdOaTJDbXNUTEkzZWhleFVETjRXTmp0Y2sz?= =?utf-8?B?d3BCQThia3FzOTVRcmFUZGYvZTlEMk5wMENkbzh1bUFzUWxXam01bjA1WlhS?= =?utf-8?B?YnNZb1lnQnArZGw0QTRPTTRZM05sbnVwSCtJQSs4dWF2THFvdURUbjhKV0RQ?= =?utf-8?B?Zk5jMHJCblhoT1RaMm42QWxuR1VaNmNYbVhYRXlzVlVxZU5za3pxd1N4Q1Ir?= =?utf-8?B?eWJEL0ZUclM5NWNaaEl6QUFhWlFack5ldVQ1cWlxRjdLMzJRK3FSZTNEdUZx?= =?utf-8?B?MGRUYXZYNHh6d1c1VjcxSTV2SjVTWDNIKzVHOUEvb09sZHlCQkFUdXBjdUhE?= =?utf-8?B?RGdZSWZ5aERveEdacDRlRncwWHhNdlVSK09wQ3JWNFZsZ2tQZUtqSDBKMU1K?= =?utf-8?B?Qk14Uytzdm90TTgyVXBQTXZIVUF5Yi8zY1hDQjhQNnpjN3Z4bm1Zc0QvRFpw?= =?utf-8?Q?QnarX6?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB0961;6:g4f4uurJJBGPi85UWFbe6JImf1PJ0WUK8P01uMZ9AWgBaIjyjOUqi1pnl4Qs7GV7zZoDZNsFiJZcK/cXkkxKVy3uC3vU8wIpGQaT5rWrfwDGNZEJI3O+FRqNVGjDPZeeIvO391zxbIKBRLHmXgHXpVNAYmAzG9mkLrbstlks2W3uzgT5FM1iIVdxYob8t4CnlRUrgZDDRCAawyxjOVdO5cbE5FqrxZUC6rI6h9avu300CIc2nz/WURAVZ4bn05cAbWHUhfotpsAb8j90bRqCKWv5hVJzrT/wZoFTa+eeJfZlcx27KRbMXb+rUk57PL3Z1caP+gaQb9NmpbqbjkPTiB92SQoKBuy3duyQVdk51FiLRTyx6S+RnkUtusLi+uRfpuONbgAwcLTwlBJ3qmxZaw==;5:KAhPLJ0DBDWq87fLo7CNO7dxFQaSCTQPsaW6dmetdErh/PCquWC26ppMEMsOE7hxfedOrRMOBPq1y5hObdELz6N1VSfbuZw/vzRIPJRwB+QsT+dR1p+wATF5+2JiRwMzPLbSO7/nsgCckMcDfn23u4E7H6abta31vH14gcP/UlM=;24:risHIvyUzpB6diGYeJ58trkHxU9FT5wVc2q8ZPyiSqRl7FegoH4ba2wn6KaTx5PGot0hbHO0FBKhAUU/6GrHVjulP2MKgdyXrIVdi2V5LG0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB0961;7:BUfnaHWUkQkHyuNSQzCc2wDk4Fer1/eGGwgSVOGvRUYoVWOZ6DD1dht9y6D2rnAQDGy/XTj0ItUC6/u6Uq2QigHgu2B3KN7SOeYv6C/kSV5l6CaYbpNAw2n2UhuXAAFTw9kTYjAWGp29MTVg1zVOTaAOPNMc+7nD40KPT8gV7DRuSW5YuM2h4yHw5zSrNPIr8iHUZybmyNEO8rsACT5uaYgeus+M4PzM7syosBjH4WAxU7E8OQBqYSmxa3QWVNlLo/1hDiGb39915VV8z3ek/HfvLNVi+vfl/eexTZDdoZ+DCFhBF0o8HuJaQ0IhmqdRLKF7Rnen4JRGqAYhx6w5Vew7eo1EIs9kijV9wuTRfNtk6Do5y2RpL6JJ8N4IuLlzPoqXOL39Gi/ih7F0MVKYFODQsYc0qLpnrk54Xwhoj+p4CnyOMmTbVqZ7ije0rGpjJjQHEUgG78DS2phW0QZcRYYTMzwroSKYL0busK54EaKUVE6QZzwYYRLU6eoQQU783u/TeYxq6X8Crs33j3fSQA==;20:uy6r/JxDsRq6IB3h8ntNvNeiwrYAptAcLa5pb4NxYqi14bUbUpmFHdHt6SJ69DMDLExE8K222tfivdL7+oTLLazy12C/m6GQJPjhmGGKnlmOBYvqXRxlpJ8B33KHqlGtE6khYkwJCBQI4JOz+KQ3dQd30OfGvJaF6P5BBrnqeio= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2017 16:09:08.8354 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR15MB0961 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-06_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/5/17 3:14 PM, Mickaël Salaün wrote: > - if (unpriv && test->prog_type) > - continue; > + if (!test->prog_type) { > + if (!unpriv) > + set_admin(false); > + printf("#%d/u %s ", i, test->descr); > + do_test_single(test, true, &passes, &errors); > + if (!unpriv) > + set_admin(true); > + } > > - printf("#%d %s ", i, test->descr); > - do_test_single(test, unpriv, &passes, &errors); > + if (!unpriv) { > + printf("#%d/p %s ", i, test->descr); > + do_test_single(test, false, &passes, &errors); > + } great idea. Acked-by: Alexei Starovoitov as far as other patches.. we need to figure out how to avoid conflicts between net-next and Arnaldo's tree where Joe's patches went. Mickael, can you see some way of splitting the patch set between trees? Like above test_verfier.c improvement needs to go into net-next. The rest can go via perf