From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753207AbdBGFWd (ORCPT ); Tue, 7 Feb 2017 00:22:33 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:43055 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751967AbdBGFW3 (ORCPT ); Tue, 7 Feb 2017 00:22:29 -0500 Subject: Re: [PATCH 3/5] perf/sdt/x86: Move OP parser to tools/perf/arch/x86/ To: Masami Hiramatsu References: <20161214000732.1710-1-alexis.berlemont@gmail.com> <20170202111143.14319-1-ravi.bangoria@linux.vnet.ibm.com> <20170202111143.14319-4-ravi.bangoria@linux.vnet.ibm.com> <20170207121105.c16c1bded3f24c798eac318a@kernel.org> Cc: acme@redhat.com, alexis.berlemont@gmail.com, linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, mpe@ellerman.id.au, naveen.n.rao@linux.vnet.ibm.com, maddy@linux.vnet.ibm.com, Ravi Bangoria From: Ravi Bangoria Date: Tue, 7 Feb 2017 10:52:17 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20170207121105.c16c1bded3f24c798eac318a@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17020705-0020-0000-0000-00000B4B1C37 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006571; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000202; SDB=6.00818310; UDB=6.00399870; IPR=6.00595771; BA=6.00005120; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014206; XFM=3.00000011; UTC=2017-02-07 05:22:26 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17020705-0021-0000-0000-000059E26A45 Message-Id: <58995989.9020202@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-07_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702070051 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Masami for the review. On Tuesday 07 February 2017 08:41 AM, Masami Hiramatsu wrote: > On Thu, 2 Feb 2017 16:41:41 +0530 > Ravi Bangoria wrote: > >> SDT marker argument is in N@OP format. N is the size of argument and >> OP is the actual assembly operand. OP is arch dependent component and >> hence it's parsing logic also should be placed under tools/perf/arch/. >> > Ok, I have one question. Is there any possibility that N is different > size of OP? e.g. 8@dil, in this case we will record whole rdi. > is that OK? By looking at list of markers on my x86 Fedora25 box, yes, it's possible for case when register size used in OP is more than size specified by N. For example, -4@68(%rbx). But I don't see any argument which specifies higher size in N compared to size of register in OP, like you mentioned in your example. Ravi