From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755626AbdBHATh (ORCPT ); Tue, 7 Feb 2017 19:19:37 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:42739 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbdBHATf (ORCPT ); Tue, 7 Feb 2017 19:19:35 -0500 Subject: Re: [PATCH net-next v3 04/11] bpf: Use bpf_load_program() from the library To: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= , References: <20170207214500.27496-1-mic@digikod.net> <20170207214500.27496-5-mic@digikod.net> CC: Arnaldo Carvalho de Melo , Daniel Borkmann , "David S . Miller" , , Shuah Khan From: Alexei Starovoitov Message-ID: <589A5597.7090107@fb.com> Date: Tue, 7 Feb 2017 15:17:43 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20170207214500.27496-5-mic@digikod.net> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2620:10d:c090:180::1:35b0] X-ClientProxiedBy: DM5PR1601CA0023.namprd16.prod.outlook.com (10.174.111.36) To BL2PR15MB0961.namprd15.prod.outlook.com (10.167.116.23) X-MS-Office365-Filtering-Correlation-Id: 92ebc479-e904-4631-135a-08d44faf897d X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BL2PR15MB0961; X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB0961;3:RY1rowdutSNCCP9cpt17K0IXHMpYo5m2Hzld+A9WhVwJ4vXvIjLnxmfiFAy2V6+zLsb0nUW6M11FyoaT6MTlDNaSPNAho6CfbKuUuvfxJ7NLc1awDmzyxXuCRU61RPn3oEZ/vhMt+3idbdyt9NakAkM48QL5xT9YeSRr4sTbBqiWGjx1w4DFJ7K3FUJT+kONMTrnFRnvsS6mMlhDz6ubn4H5bwjPoPAiJINorRodqcL2mItLrNAO5vnW/lgMpClOA0kBuptkPmp1jJoZOvjRnw==;25:3+3vcVME8jkBYBzbLpFPxXWOQpp5itYouOs53zd6Z/rLdfU+/ySaybZilToBD5u2rvMta6kT7ywzi4ynBEsvZ9crbcs29U4r7xTdtKIcBqqcYca9lkWddbhn4NfWcmH30z0I3rc6L7GaLr1ygOGVHigMhRsBAgg+y13mjw3F96P8f+ZLWItNrsciedWk3vjTXQ6NCv1mLYZxWuWqbId61qEvQvbp0kkuidQs9mx4f32GkxfMC6Z1JU8GF3zEKOC2cwbaD1pfFvem2dhDLLNjn+LMlzX03d7nq2bzOKzH42xaay93kx7gojTARdk9OOLBbiJIIEO+Mj0v5PlghlpcI4pZEgqj5hXoB8SCmfZLMVaDPwelhXTspB8AM0ReA3SKPgWeD5iNzPE60zfIhOQpWOQQUAWgTPKKKyZQgc5pAV1As1E+OwDDzvOw2JhOj8l9mhDyWtZEmjBf43dAE2TlZA== X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB0961;31:5I5xJHzW9WD9AhPr827VWPaqKlt8GWCVKzYoHuxYEho0O/ZxiGhM2zCopD11DX3+gnlqPwlWa9NN8V2DxI9SzfF9B/bvfK+A+OpWT1jVvi6kUxHJPfNc0lLDlumSKQTwkqSqTrqZjFntaJWoYI5Vl98kwnLBz1MMTNtR+3/SV4fJC0uKjV/AjmC9mvC8NF9kbvIB/uck+2RzvVnI2FhLZ0R79epjXSLAb04pv+6GVEp/KAYhGIYedtHf/YsK1KsUPx69f78ABJQLpsCT14ZodA==;20:9gq/7tYOWYxmZKF4KTKVPwjaXd1wOMZqsHmiZCaMShXhedyfo0uX/+OWgiqungOk9uNY2TyDPPJBS90yJcpyLzsTn2YDKkW+Sx9+yA8ot31mBL57lPNJv4cvACLL1cH8Am0MhMh4C4TxmHL5diYW4IeAyh6i7vSKc4Pc7QEHPeAB4PwzPKBJv+tLH2AXvzN5QR3NbFUeuO9RUV0c1DDzkJsAoRCyuch0oRu+OGVAJC4vbB6U6QwXzASqLqYS4qKX/sQ/o7XDQ9Vny5ikZj9126q1IfnCqRcD8OonXRwOGz9VTx4HtmAhgkmYNzF9V3hPeaRqG3h6SOqul1qJraqyi2I6rQX5JiDbIwHsQt8T3+EJKZX9hBeNHVBNQZSxwMb/VncC0rDUcVQsgosnt8JJnlZ46uEYk56aYLLfU4tXnHNwDfqVumuFBfLol5b+1tckG23hUMNaaG0jN2mWjKGT7dGtH+1EkJt+f8orzWghfaCSPOZr7GI+seAcJPbospZ8 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(2017020603029)(5005006)(20170203043)(8121501046)(3002001)(10201501046)(6041248)(20161123555025)(20161123560025)(20161123558025)(20161123562025)(20161123564025)(6072148);SRVR:BL2PR15MB0961;BCL:0;PCL:0;RULEID:;SRVR:BL2PR15MB0961; X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB0961;4:wPSxKv2k8P5OR+4J14yTVbIxVbUw1CPec0Q4iwojotKUUiWfBGE8n5BdUNIs+acyCh4QWCpdoBVnPW2xQ4rUJ+vqhJ0v2xCyDDiDG4CleqeDDBwFPMdKLvruQY0NMwYgU/cAZ/0SA6Cj6m/4/BlN+3PNkRAOtvN3QmwnNCMCRGl0l3H+LPmzq4kpnjGaNeWHs0L7sT8Nc08N4348jw66+1zUV3TnbmvYBiqWK7dbzoc3Rkcm1wdjlt88MIPUSsJx2vX/Rr0mgvkL7bpG4VtNbzwmyE/RKVXKm0fUgrawPceri5+Txb1QX9FCe14+H7HD6Rl53l/DeX5zLHqDWkt31AFzMdXSSrb0Zx9XGioWA4itfynd94XqD/Wz5hBKO6Iaf3zSd6TMKgtetTydJjOnvjHuE10uJamgi6FklXjSN8p8KRaFTcOPfCwz8CMH+N9xyKRcS1NlmnPYnr2uB0jhiucwvXxPoYXShm9hhKKo/gt4iPem6QiihoJMcEL9H0lY9D/my9u3u8Lw1c4VTB92c6MqsPQpYHvm+w9ur/88JU16ptmItzrNPAi2cWtVooXF1EIlJQhmbMrlVhoGOQF7p8sBXL9EZlV6ZNUgxG5scEfRGigk2JLGi3p6iAeL0eVA2DFlhWHxS6NEiZtBWbArCdDLGxoteKuR4jMw4ELITlE= X-Forefront-PRVS: 0211965D06 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(39450400003)(189002)(199003)(377454003)(24454002)(54906002)(42186005)(229853002)(47776003)(65816999)(106356001)(59896002)(105586002)(6486002)(25786008)(101416001)(53936002)(50986999)(2950100002)(33656002)(6116002)(50466002)(64126003)(1706002)(2906002)(54356999)(4326007)(87266999)(76176999)(2870700001)(97736004)(53546003)(68736007)(36756003)(6666003)(81156014)(81166006)(8676002)(305945005)(7736002)(65956001)(86362001)(38730400002)(23676002)(5660300001)(80316001)(92566002)(189998001)(4001350100001)(6246003)(83506001)(65806001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:BL2PR15MB0961;H:[IPv6:2620:10d:c081:1110::117a];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTDJQUjE1TUIwOTYxOzIzOmlSRlRnTml1U25NTVNyUmVHMDg5Q0xYZEZE?= =?utf-8?B?bWRxaElqTWg3WUo3YlAyNzdpeXJ5WkxnSmZyTU9OWDViMEtLd1dHSUtpaTND?= =?utf-8?B?YlJ3ZWtXT0d1MnpSaVB6Y1lzOWJuamdjampLcitaUGhyRVk3SE40K0lveVor?= =?utf-8?B?VWduVmlqcjZ0SVJ0SE54V0l1cFNjcG1iQVVxWS9qYlJqV3QzZFFoUVcvQnZU?= =?utf-8?B?SGFtTGdZU3VIUWpsVnNaSkREeDhBTkhCWE9RV281VWpsYlRyeHhhOFUveUli?= =?utf-8?B?OHcrNVZXbk1sM2lVTFFiY3F2cW5peGJMTTdnUm1idWZyMnV0aHc5NmYwalZk?= =?utf-8?B?RDFGWjlmS0hTOFdLSU9EOUFTb21xZjVBTWFoTFRKTm9qN0hMR3RYcHFFNUZa?= =?utf-8?B?dDhXSDBkeVBkbEJlOVVmcmhxcU93ZzFDSldWVEduZDFNZE9HSjArMUdFUmZF?= =?utf-8?B?d3IvbFB3Sm5sb21CbGNLNTN3ZStqZ2xxK1g1OEVKRkErMFhuOGtlaHdpZEtx?= =?utf-8?B?bmpkT3N1UlFmaElYMVA1ZXNmSEpEZUoycE1pWkl3dmtFcEVmRHFxaXYrNzRv?= =?utf-8?B?ZS9iTlI4c1AzNHlkY2xJMnVvVnA0aWJwYUhQTnppdU1ZNks4WUxpTW44allD?= =?utf-8?B?VWtITjJGQmZJYW1oaWlBaWJhZitNczdaSlNFdjFHVWFNSU5FTklHZUJUSGJl?= =?utf-8?B?UkFHTUZzbURkSnVxVVpLRlRVNGI2aDdOQnNJcEpxSUxTR0JpdFltZXdlU0Jy?= =?utf-8?B?TmFFVzRrTzFSSzBvVXQxdWdPbkFwdVlsSFQ4T05na1BLTjlwUVJZSWNJYlJI?= =?utf-8?B?SFVaaGlEa0xaNVpVbHhiTWpRcU9ER01tU2x6SjZqaDd5SitLcGJoNGg1RzAr?= =?utf-8?B?Qk03VFhnZGFhM0N6MS9PempPUmZqb0NjaHdxR1E4RTgzWFNQdndWWXEvdmZM?= =?utf-8?B?bU9mY1BGVVFzeEUwSXZJeUNtbnUvOXAvY3Z5eUs2YW9pbnVFYUZZUHBuRGFE?= =?utf-8?B?a0FQOURpY1c4bzhKbytrOU0zV004NDJiT25UV1BuaEhBOGVrdFI3SkVFUzRm?= =?utf-8?B?MndxTnc4QURjVDBhbDZ2UjVoaTdibTAxa1M5TGpOTUljeDBSdnZMeWtiQ1BM?= =?utf-8?B?M1A2OFVwdWxFMTZWMi9SV2dWL1NSYXhjZTJaRUpwZldjRGVBUEVOZnhCS3Z2?= =?utf-8?B?cFpaejdpZFlyOGVVOWwrRklBWC9YMXNwK1VITDdBM3B6MGo4WU9zczQ2RFly?= =?utf-8?B?bEo2OG9qdWxvd2FoNXBqZ1drRzBGSzE5QTRKMWhuVmdaUWZWK2pWcmp6d0F0?= =?utf-8?B?dUJLbEtRejkxVCsyVWdsVk9QOGl0bHhWdDR5am5LR01ZY2hjQU8vNlFWelIx?= =?utf-8?B?Q0NjSDIrbHdGcWZNaWhOdlZ4dERpUWpDaFNSeGdXOUsyNWpaQ2ppRE56TGFi?= =?utf-8?B?ZDNPdzFPSWx5U1FwRFNsUVE0Vm1oSDFrMFg3WUYrVW5DVFpVY1V1TzBJS3d1?= =?utf-8?B?RHNCZDBYZ1lFcGptRjZnN3ZDRVcwdkx3RVpVR09XU0RzYlU2Z0VsNGVBQmNR?= =?utf-8?B?NW10dUxEVDcrMnFtMFNULzhXeURieEh0amdzbDlqRU92c05obDBLNlNRbGpH?= =?utf-8?B?WGNaL2x6b0I5Q256Y3A2ZHdDUmpNYXVDQS9IMDE0RjMvbDUxRXpheG5EQVFO?= =?utf-8?B?a3lEc1BKTWFyTmdjMUUxc2JmU2k1UDVvbmJmYWJ3MmpiakoxUGJRSEUvUEth?= =?utf-8?B?Vi9UZ01sNDJ3QlZjcmw5WWttT2JWV2pRcGlnYnY4ODk4clFzdGlYQkk2T0E0?= =?utf-8?B?QkNQaURRc1UvaUljZXpzR3VRTWpIdnVOQ09YNUwyMVFiTkE9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB0961;6:I1eC1D7W69FdF+n6bdSTaa6A5fSDzKLukQMz4tWJs/GSpfS5vfQG3bIdDV6zq4v+VCrIrWAe8NVqlLvHXrAG7RM16sQXYT3aHn7sMzcFwE39bsb5prwYTy3+WRkGPGUTbd2CqwGY2f+Xk79C5UiXcnykxnYUZIgZpSU1TElDAkQfO4svtnzVQTxhpk5goB/0N+vb0feGIKJ2BrV8HvHxsM3jnTmqr8QeLCeoEzubsqudyGmWQCIn4Cc+/li4ggXRC0H3ByvK49o5MLprBwATJXvelNX/HjSzoQ62aWNlnIZI7EU5YJgPz7k6v+YuxcQ1BAhxW0QfDXsHesVyuSQWmxMpvOLRsCAzCqCqSKwLX2rSIYejSOCa01fsYlRJ0SDnAKVE2SLXfFJtLQpAVgP58g==;5:WMI5P7SWIUukX66ETCLTVapiVTzkEtJecC7gbd6qj+g9S+sZVgejB/wK6DsMqka0tSXW4a7ii9T1sne4Oe4jNGYDfhG7CUGDlJj+BQn2wmgwOILB7l9Q/Okz55Nxg0H2I2HHU5wW9LXSvAZVIYVA0jEFn8MymO6HMU8B4crHj0o=;24:06laQR0lVO+Zo5gsSO0bYPd1v9fGXRvMjS+ZzqcFPKapYsZGgXSPNlhLg7SLbCB816U8hqkrD9Aa8oEiQxNK+y2mYHHh3mn34KXMdWBcEAs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB0961;7:8Mb/BKmqZWEHQBXUmGme/t1OJ66dyHD22lQOKFPjJKhMi9xqzvZpsHKlmJFlegU9WmQtb43jKnx3N/XwhFyAiGaEyc8UhuHFA2Q641R3Y5Y+dj42sj/8PmTSmO1VyoFY4tJn2kvVORfsTkJfY07czhb42aYueskbA2X2xolCbwxbjOk6dLsXohCqgwzhdOVYCuMMG2FAesZiQKy/9SDfokDplCZULEvpFVqQouLEoqjrZChCxLq5/Glo0jZbVKkoZ57+AwuWrKvWTLRHkD58VU/pp5pkjydldfbeIpgLMzXgH2XE8tom44UzNW7onaUa21EtyLjz6gBIgYkIiXXfTSzzLSRwDVMTvzJPP06t9zoM1lhdNGZrDcZkOWumMcxqB5fok4AyUO/M4D8mG+WobM0pNux3no74h+WQsniKN2zRPvx4db8ujUmqG+mMCAGA7XRMtdA0/726BmGeoDttO/7MVjxvG0B/dDuYFeKM+oC5hC304snS1sGJagoTX4zPu+MwRj5dX+yRj0LAjKFQYw==;20:Aro9ESl0Mw3b9MiKCwcNVTnS6Bw04unpnSH9TYyhIfYjgk9x1ZzjgW5zIISf6RMHv0PNsK2rSrZBvhg/ur35RUpJO8ucQGYwDKu+DlkImOyXs2vxf54r3eSsXPYUF/be5SbzbIQVRsx7LJ1EZGx3FCk7fn/cNKZGFEnq6X4+R8E= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2017 23:17:49.7058 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR15MB0961 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-07_12:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/7/17 1:44 PM, Mickaël Salaün wrote: > - union bpf_attr attr; > + union bpf_attr attr = {}; > > - bzero(&attr, sizeof(attr)); I think somebody mentioned that there are compilers out there that don't do it correctly, hence it was done with explicit bzero. Arnaldo, Wang, do you remember the details?