From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932810AbdBHAgQ (ORCPT ); Tue, 7 Feb 2017 19:36:16 -0500 Received: from regular1.263xmail.com ([211.150.99.139]:32905 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbdBHAgN (ORCPT ); Tue, 7 Feb 2017 19:36:13 -0500 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 3/7] drm/rockchip: gem: add mutex lock for drm mm To: Thierry Reding References: <1486456542-18675-1-git-send-email-mark.yao@rock-chips.com> <1486456542-18675-4-git-send-email-mark.yao@rock-chips.com> <20170207121909.GA18315@ulmo.ba.sec> Cc: David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org From: Mark yao Message-ID: <589A661C.5070505@rock-chips.com> Date: Wed, 8 Feb 2017 08:28:12 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20170207121909.GA18315@ulmo.ba.sec> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017年02月07日 20:19, Thierry Reding wrote: > On Tue, Feb 07, 2017 at 04:35:38PM +0800, Mark Yao wrote: >> drm_mm_insert_node_generic and drm_mm_remove_node may access same >> resource with list ops, it's not threads safe, so protect this context >> with mutex lock. >> >> Fix bug: >> [49451.856244] ================================================================== >> [49451.856350] BUG: KASAN: wild-memory-access on address dead000000000108 >> [49451.856379] Write of size 8 by task Binder:218_4/683 >> [49451.856417] CPU: 2 PID: 683 Comm: Binder:218_4 Not tainted 4.4.36 #62 >> [49451.856443] Hardware name: Rockchip RK3399 Excavator Board edp (Android) (DT) >> [49451.856469] Call trace: >> [49451.856519] [] dump_backtrace+0x0/0x230 >> [49451.856556] [] show_stack+0x14/0x1c >> [49451.856592] [] dump_stack+0xa0/0xc8 >> [49451.856633] [] kasan_report+0x110/0x4dc >> [49451.856670] [] __asan_store8+0x24/0x7c >> [49451.856715] [] drm_mm_insert_node_generic+0x2dc/0x464 >> [49451.856760] [] rockchip_gem_iommu_map+0x60/0x158 >> [49451.856794] [] rockchip_gem_create_object+0x278/0x488 >> [49451.856827] [] rockchip_gem_create_with_handle+0x24/0x10c >> [49451.856862] [] rockchip_gem_create_ioctl+0x3c/0x50 >> [49451.856896] [] drm_ioctl+0x354/0x52c >> [49451.856939] [] do_vfs_ioctl+0x670/0x78c >> [49451.856976] [] SyS_ioctl+0x60/0x88 >> [49451.857009] [] el0_svc_naked+0x24/0x28 >> >> Change-Id: I2ea377aa9ca24f70c59e2d86f2a6ad5ccb9c0891 > This is meaningless in an upstream tree. Please remove. > > Thierry Right, Forget to remove "Change-Id: " Thanks. -- Ｍark Yao