From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753862AbdBNLjG (ORCPT ); Tue, 14 Feb 2017 06:39:06 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:46816 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752933AbdBNLic (ORCPT ); Tue, 14 Feb 2017 06:38:32 -0500 Subject: Re: [PATCH v3 2/2] powerpc: emulate_step tests for load/store instructions To: Michael Ellerman References: <1487063803-10848-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <1487063803-10848-3-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <877f4tm4n2.fsf@concordia.ellerman.id.au> Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, benh@kernel.crashing.org, paulus@samba.org, lsorense@csclub.uwaterloo.ca, oohall@gmail.com, naveen.n.rao@linux.vnet.ibm.com, ast@kernel.org, chris@distroguy.com, aneesh.kumar@linux.vnet.ibm.com, bsingharora@gmail.com, anton@samba.org, paul.gortmaker@windriver.com, bauerman@linux.vnet.ibm.com, viro@zeniv.linux.org.uk, christophe.leroy@c-s.fr, duwe@lst.de, oss@buserror.net, Ravi Bangoria From: Ravi Bangoria Date: Tue, 14 Feb 2017 17:08:10 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <877f4tm4n2.fsf@concordia.ellerman.id.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17021411-0016-0000-0000-0000062997EC X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006614; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000203; SDB=6.00821781; UDB=6.00401956; IPR=6.00599234; BA=6.00005135; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014278; XFM=3.00000011; UTC=2017-02-14 11:38:27 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17021411-0017-0000-0000-00003761C9EF Message-Id: <58A2EC22.8080209@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-14_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702140116 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 14 February 2017 04:16 PM, Michael Ellerman wrote: > Ravi Bangoria writes: > >> diff --git a/arch/powerpc/lib/Makefile b/arch/powerpc/lib/Makefile >> index 0e649d7..ddc879d 100644 >> --- a/arch/powerpc/lib/Makefile >> +++ b/arch/powerpc/lib/Makefile >> @@ -33,3 +33,7 @@ obj-$(CONFIG_ALTIVEC) += xor_vmx.o >> CFLAGS_xor_vmx.o += -maltivec $(call cc-option,-mabi=altivec) >> >> obj-$(CONFIG_PPC64) += $(obj64-y) >> + >> +ifeq ($(CONFIG_PPC64), y) >> +obj-$(CONFIG_KPROBES_SANITY_TEST) += test_emulate_step.o >> +endif > FYI, the right way to do that is: > > obj64-$(CONFIG_KPROBES_SANITY_TEST) += test_emulate_step.o > obj-$(CONFIG_PPC64) += $(obj64-y) > > And in this Makefile you don't need to add the second line because it's > already there. Thanks for this. Will change accordingly and send next version. Ravi > > cheers >