From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751983AbdBOLyy (ORCPT ); Wed, 15 Feb 2017 06:54:54 -0500 Received: from mail-eopbgr40085.outbound.protection.outlook.com ([40.107.4.85]:21536 "EHLO EUR03-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751462AbdBOLyx (ORCPT ); Wed, 15 Feb 2017 06:54:53 -0500 From: Laurentiu Tudor To: Bogdan Purcareata , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "devel@driverdev.osuosl.org" Subject: Re: [PATCH] staging: fsl-mc: Add missing header Thread-Topic: [PATCH] staging: fsl-mc: Add missing header Thread-Index: AQHShhfvamo40a2szkiMauUF4tUEVKFp+G0A Date: Wed, 15 Feb 2017 11:54:49 +0000 Message-ID: <58A44188.70103@nxp.com> References: <1487004041-2873-1-git-send-email-bogdan.purcareata@gmail.com> In-Reply-To: <1487004041-2873-1-git-send-email-bogdan.purcareata@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=laurentiu.tudor@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [192.88.146.1] x-ms-office365-filtering-correlation-id: ad9cc6ff-10ba-4346-7027-08d455997204 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:VI1PR0401MB1853; x-microsoft-exchange-diagnostics: 1;VI1PR0401MB1853;7:6T/NsHSBVDimJw94V71IgJHxVVh4RNwyZvDOtlB4lj7Imh2nI8JO8J/D/j0JDDbapSh0Q2P0Gwoiow448U99kG/eT5b6f/Q1RVYZ03pVrmNx/7Wanzo1/FVlCnH45yyZvwpbtNuqYnePDdNKEYSIoyLcqpTeODJjrSRvXi/i2wOt6LD2FCMVItjJNuYY7Y7X4w8RkpNiH4abribNWTAsP/e18VnZaeMvD2748afg9dMugty+GLuLGyI6DeIBnpUGmbKNWq9xtzWFGXiXxXOfZRJBSuSmt2UWM0zr1l6v0PICXsdsUdzDsr9T9DyXk0ljnSBZJXlGpKHaX3I+i7LrG/NGJRUm5didOfBzshGct2FWUF0zFz6B5ZIWsgnJ/MDJIyQz6HAJVIsUk823sSZl8YFHBFpZXle85G4FVCKko+W+isU/+sJvsGvtf/69lctTM50IO+qMT7NMOpuRE5tM05vf92M+z4kRI6eZwYamTUnKtoOCyM+fzfVfatTcHRdbT5umSRM62tB10FzyvOLhWw== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123558025)(20161123562025)(6072148);SRVR:VI1PR0401MB1853;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0401MB1853; x-forefront-prvs: 021975AE46 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39850400002)(39410400002)(39860400002)(39450400003)(39840400002)(189002)(377454003)(24454002)(199003)(6116002)(53936002)(33656002)(65816999)(97736004)(189998001)(305945005)(53546003)(3280700002)(3846002)(54356999)(3660700001)(68736007)(8676002)(81166006)(50986999)(122556002)(81156014)(389900002)(102836003)(38730400002)(6246003)(76176999)(8936002)(5660300001)(36756003)(2950100002)(2906002)(99286003)(101416001)(6512007)(2501003)(86362001)(7736002)(66066001)(2900100001)(6486002)(25786008)(77096006)(6506006)(92566002)(106116001)(105586002)(229853002)(6436002)(2201001)(106356001)(39060400002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0401MB1853;H:VI1PR0401MB1856.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="Windows-1252" Content-ID: <628B8F041B62C04B9CA48AE3465D7A5E@eurprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2017 11:54:49.5691 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB1853 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v1FBt5fi020108 On 02/13/2017 06:40 PM, Bogdan Purcareata wrote: > Compiling the fsl-mc bus driver will yield a couple of static analysis > errors: > warning: symbol 'fsl_mc_msi_domain_alloc_irqs' was not declared > warning: symbol 'fsl_mc_msi_domain_free_irqs' was not declared. > warning: symbol 'its_fsl_mc_msi_init' was not declared. > warning: symbol 'its_fsl_mc_msi_cleanup' was not declared. > > Since these are properly declared, but the header is not included, add > it in the source files. This way the symbol is properly exported. > > Signed-off-by: Bogdan Purcareata > --- > Sent against staging-testing. > > drivers/staging/fsl-mc/bus/fsl-mc-msi.c | 1 + > drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-msi.c b/drivers/staging/fsl-mc/bus/fsl-mc-msi.c > index 7975c6e..b8b2c86 100644 > --- a/drivers/staging/fsl-mc/bus/fsl-mc-msi.c > +++ b/drivers/staging/fsl-mc/bus/fsl-mc-msi.c > @@ -17,6 +17,7 @@ > #include > #include > #include "../include/mc-bus.h" > +#include "fsl-mc-private.h" > > /* > * Generate a unique ID identifying the interrupt (only used within the MSI > diff --git a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c > index 0e2c1b5..87e4471 100644 > --- a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c > +++ b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c > @@ -17,6 +17,7 @@ > #include > #include > #include "../include/mc-bus.h" > +#include "fsl-mc-private.h" > > static struct irq_chip its_msi_irq_chip = { > .name = "ITS-fMSI", > Acked-by: Laurentiu Tudor --- Best Regards, Laurentiu