From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751430AbdBOPfD (ORCPT ); Wed, 15 Feb 2017 10:35:03 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:35361 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751023AbdBOPfB (ORCPT ); Wed, 15 Feb 2017 10:35:01 -0500 Subject: Re: [PATCH] of: add EXPORT_SYMBOL for of_device_compatible_match To: Corentin Labbe , robh+dt@kernel.org References: <20170215142245.11207-1-clabbe.montjoie@gmail.com> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Frank Rowand Message-ID: <58A47521.9090909@gmail.com> Date: Wed, 15 Feb 2017 07:34:57 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20170215142245.11207-1-clabbe.montjoie@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/15/17 06:22, Corentin Labbe wrote: > This symbol will be needed for the dwmac-sun8i ethernet driver. > For letting it to be build as module, of_device_compatible_match need to > be exported. > > Signed-off-by: Corentin Labbe > --- > drivers/of/base.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/of/base.c b/drivers/of/base.c > index df6f6e3..fba351b 100644 > --- a/drivers/of/base.c > +++ b/drivers/of/base.c > @@ -524,6 +524,7 @@ int of_device_compatible_match(struct device_node *device, > > return score; > } > +EXPORT_SYMBOL(of_device_compatible_match); > > /** > * of_machine_is_compatible - Test root of device tree for a given compatible value > Rob's reply to the last person who requested that: It's not missing because no modules use it. It's generally preferred to use a match table and of_match_node. -Frank