* [PATCH] of: add EXPORT_SYMBOL for of_device_compatible_match
@ 2017-02-15 14:22 Corentin Labbe
2017-02-15 15:34 ` Frank Rowand
0 siblings, 1 reply; 5+ messages in thread
From: Corentin Labbe @ 2017-02-15 14:22 UTC (permalink / raw)
To: robh+dt, frowand.list; +Cc: devicetree, linux-kernel, Corentin Labbe
This symbol will be needed for the dwmac-sun8i ethernet driver.
For letting it to be build as module, of_device_compatible_match need to
be exported.
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
drivers/of/base.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index df6f6e3..fba351b 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -524,6 +524,7 @@ int of_device_compatible_match(struct device_node *device,
return score;
}
+EXPORT_SYMBOL(of_device_compatible_match);
/**
* of_machine_is_compatible - Test root of device tree for a given compatible value
--
2.10.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] of: add EXPORT_SYMBOL for of_device_compatible_match
2017-02-15 14:22 [PATCH] of: add EXPORT_SYMBOL for of_device_compatible_match Corentin Labbe
@ 2017-02-15 15:34 ` Frank Rowand
2017-02-17 8:20 ` Corentin Labbe
0 siblings, 1 reply; 5+ messages in thread
From: Frank Rowand @ 2017-02-15 15:34 UTC (permalink / raw)
To: Corentin Labbe, robh+dt; +Cc: devicetree, linux-kernel
On 02/15/17 06:22, Corentin Labbe wrote:
> This symbol will be needed for the dwmac-sun8i ethernet driver.
> For letting it to be build as module, of_device_compatible_match need to
> be exported.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
> drivers/of/base.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index df6f6e3..fba351b 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -524,6 +524,7 @@ int of_device_compatible_match(struct device_node *device,
>
> return score;
> }
> +EXPORT_SYMBOL(of_device_compatible_match);
>
> /**
> * of_machine_is_compatible - Test root of device tree for a given compatible value
>
Rob's reply to the last person who requested that:
It's not missing because no modules use it. It's generally preferred
to use a match table and of_match_node.
-Frank
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] of: add EXPORT_SYMBOL for of_device_compatible_match
2017-02-15 15:34 ` Frank Rowand
@ 2017-02-17 8:20 ` Corentin Labbe
0 siblings, 0 replies; 5+ messages in thread
From: Corentin Labbe @ 2017-02-17 8:20 UTC (permalink / raw)
To: Frank Rowand; +Cc: robh+dt, devicetree, linux-kernel
On Wed, Feb 15, 2017 at 07:34:57AM -0800, Frank Rowand wrote:
> On 02/15/17 06:22, Corentin Labbe wrote:
> > This symbol will be needed for the dwmac-sun8i ethernet driver.
> > For letting it to be build as module, of_device_compatible_match need to
> > be exported.
> >
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> > ---
> > drivers/of/base.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/of/base.c b/drivers/of/base.c
> > index df6f6e3..fba351b 100644
> > --- a/drivers/of/base.c
> > +++ b/drivers/of/base.c
> > @@ -524,6 +524,7 @@ int of_device_compatible_match(struct device_node *device,
> >
> > return score;
> > }
> > +EXPORT_SYMBOL(of_device_compatible_match);
> >
> > /**
> > * of_machine_is_compatible - Test root of device tree for a given compatible value
> >
>
>
>
> Rob's reply to the last person who requested that:
>
> It's not missing because no modules use it. It's generally preferred
> to use a match table and of_match_node.
>
> -Frank
I replace of_device_compatible_match like you said and it works.
Thanks
Corentin Labbe
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] of: Add EXPORT_SYMBOL for of_device_compatible_match
@ 2017-01-16 13:11 Neil Armstrong
2017-01-16 15:37 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Neil Armstrong @ 2017-01-16 13:11 UTC (permalink / raw)
To: robh+dt, frowand.list; +Cc: Neil Armstrong, devicetree, linux-kernel
Add missing EXPORT_SYMBOL for of_device_compatible_match function.
Fixes: b9c13fe32faa ("dt: Add of_device_compatible_match()")
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
drivers/of/base.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index d4bea3c..dfbcf17 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -523,6 +523,7 @@ int of_device_compatible_match(struct device_node *device,
return score;
}
+EXPORT_SYMBOL(of_device_compatible_match);
/**
* of_machine_is_compatible - Test root of device tree for a given compatible value
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] of: Add EXPORT_SYMBOL for of_device_compatible_match
2017-01-16 13:11 [PATCH] of: Add " Neil Armstrong
@ 2017-01-16 15:37 ` Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2017-01-16 15:37 UTC (permalink / raw)
To: Neil Armstrong
Cc: Frank Rowand, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
On Mon, Jan 16, 2017 at 7:11 AM, Neil Armstrong <narmstrong@baylibre.com> wrote:
> Add missing EXPORT_SYMBOL for of_device_compatible_match function.
It's not missing because no modules use it. It's generally preferred
to use a match table and of_match_node.
Rob
>
> Fixes: b9c13fe32faa ("dt: Add of_device_compatible_match()")
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> drivers/of/base.c | 1 +
> 1 file changed, 1 insertion(+)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-17 8:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-15 14:22 [PATCH] of: add EXPORT_SYMBOL for of_device_compatible_match Corentin Labbe
2017-02-15 15:34 ` Frank Rowand
2017-02-17 8:20 ` Corentin Labbe
-- strict thread matches above, loose matches on Subject: below --
2017-01-16 13:11 [PATCH] of: Add " Neil Armstrong
2017-01-16 15:37 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox