From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933377AbdBWB4O (ORCPT ); Wed, 22 Feb 2017 20:56:14 -0500 Received: from szxga03-in.huawei.com ([45.249.212.189]:2943 "EHLO dggrg03-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S932233AbdBWB4D (ORCPT ); Wed, 22 Feb 2017 20:56:03 -0500 Subject: Re: [PATCH 1/3] f2fs: clean up codes in get_ssr_segment To: Jaegeuk Kim References: <1487767851-819-1-git-send-email-yunlong.song@huawei.com> <20170223004114.GF4003@jaegeuk.local> <20170223005915.GG4003@jaegeuk.local> CC: , , , , , , , , From: Yunlong Song Message-ID: <58AE4111.2070406@huawei.com> Date: Thu, 23 Feb 2017 09:55:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20170223005915.GG4003@jaegeuk.local> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.74.205] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.58AE4124.0075,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 9e3cc3ccf811dc8a4e4ddbd4a38bd4b4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yes, exactly, I just mean it for short with word "clean up", thanks for correction. On 2017/2/23 8:59, Jaegeuk Kim wrote: > On 02/22, Jaegeuk Kim wrote: >> Hi Yunlong, >> >> This is NOT clean-up. What's your point here? > I guess you wanted to do like this. > > >From 8d344ac45890dd95c5734fd29a19a7c19364c327 Mon Sep 17 00:00:00 2001 > From: Yunlong Song > Date: Wed, 22 Feb 2017 20:50:49 +0800 > Subject: [PATCH] f2fs: do SSR for data when there is enough free space > > In allocate_segment_by_default(), need_SSR() already detected it's time to do > SSR. So, let's try to find victims for data segments more aggressively in time. > > Signed-off-by: Yunlong Song > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/segment.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > index d01ee7b94702..c27dab43c42f 100644 > --- a/fs/f2fs/segment.c > +++ b/fs/f2fs/segment.c > @@ -1541,7 +1541,7 @@ static int get_ssr_segment(struct f2fs_sb_info *sbi, int type) > struct curseg_info *curseg = CURSEG_I(sbi, type); > const struct victim_selection *v_ops = DIRTY_I(sbi)->v_ops; > > - if (IS_NODESEG(type) || !has_not_enough_free_secs(sbi, 0, 0)) > + if (IS_NODESEG(type)) > return v_ops->get_victim(sbi, > &(curseg)->next_segno, BG_GC, type, SSR); > -- Thanks, Yunlong Song