From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934672AbdBWCnO (ORCPT ); Wed, 22 Feb 2017 21:43:14 -0500 Received: from szxga03-in.huawei.com ([45.249.212.189]:2947 "EHLO dggrg03-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S932388AbdBWCmw (ORCPT ); Wed, 22 Feb 2017 21:42:52 -0500 Subject: Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment To: Jaegeuk Kim References: <1487767851-819-1-git-send-email-yunlong.song@huawei.com> <1487767851-819-3-git-send-email-yunlong.song@huawei.com> <20170223011754.GH4003@jaegeuk.local> <58AE452D.60500@huawei.com> CC: , , , , , , , , From: Yunlong Song Message-ID: <58AE4BD1.90301@huawei.com> Date: Thu, 23 Feb 2017 10:41:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <58AE452D.60500@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.74.205] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.58AE4BE7.0203,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 627da2e59f2ebdefdda545f56d998284 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jay, I miss some codes from your mail, now I check all your patch codes and make clear with question 2 and 3, it's fine. But still, how about question 1? On 2017/2/23 10:13, Yunlong Song wrote: > Hi Jay, > But there are some differences: > 1 Why not take "neighboring temperature" for ssr? For example, if type == CURSEG_COLD_DATA, > your new patch selects CURSEG_HOT_DATA first, how about select CURSEG_WARM_DATA first? > The patch I sent ensure this "neighboring temperature" for ssr. > 2 Your new patch returns 0 for node ssr, does get_ssr_segment work only for data? > 3 I see your new patch just "continue" when i == type, why not consider the current type? > > On 2017/2/23 9:17, Jaegeuk Kim wrote: >> Hi Yunlong, >> >> I've been testing the similar patches as I attached. >> >> Thanks, >> >> On 02/22, Yunlong Song wrote: >>> Signed-off-by: Yunlong Song >>> --- >>> fs/f2fs/segment.c | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c >>> index 9d13743..5fe71b9 100644 >>> --- a/fs/f2fs/segment.c >>> +++ b/fs/f2fs/segment.c >>> @@ -1540,12 +1540,17 @@ static int get_ssr_segment(struct f2fs_sb_info *sbi, int type) >>> { >>> struct curseg_info *curseg = CURSEG_I(sbi, type); >>> const struct victim_selection *v_ops = DIRTY_I(sbi)->v_ops; >>> + int old_type = type; >>> >>> if (IS_NODESEG(type)) { >>> for (; type >= CURSEG_HOT_NODE; type--) >>> if (v_ops->get_victim(sbi, &(curseg)->next_segno, >>> BG_GC, type, SSR)) >>> return 1; >>> + for (type = old_type + 1; type <= CURSEG_COLD_NODE; type++) >>> + if (v_ops->get_victim(sbi, &(curseg)->next_segno, >>> + BG_GC, type, SSR)) >>> + return 1; >>> return 0; >>> } >>> >>> @@ -1554,6 +1559,10 @@ static int get_ssr_segment(struct f2fs_sb_info *sbi, int type) >>> if (v_ops->get_victim(sbi, &(curseg)->next_segno, >>> BG_GC, type, SSR)) >>> return 1; >>> + for (type = old_type + 1; type <= CURSEG_COLD_DATA; type++) >>> + if (v_ops->get_victim(sbi, &(curseg)->next_segno, >>> + BG_GC, type, SSR)) >>> + return 1; >>> return 0; >>> } >>> >>> -- >>> 1.8.5.2 > -- Thanks, Yunlong Song