From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751411AbdBXBLx (ORCPT ); Thu, 23 Feb 2017 20:11:53 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:42214 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751246AbdBXBLv (ORCPT ); Thu, 23 Feb 2017 20:11:51 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a2c-f79b56d0000012f0-f1-58af87dd2ba2 Content-transfer-encoding: 8BIT Message-id: <58AF87DD.3030308@samsung.com> Date: Fri, 24 Feb 2017 10:09:49 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Andy Shevchenko , MyungJoo Ham , linux-kernel@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, David Cohen , Felipe Balbi Subject: Re: [PATCH v1 1/3] extcon: int3496: Propagate error code of gpiod_to_irq() In-reply-to: <20170223103156.109643-1-andriy.shevchenko@linux.intel.com> X-Brightmail-Tracker: H4sIAAAAAAAAA01Sf0hTURjl7m1vT2v2mllflmmvjGa59qbTGVmJUaNfKBGIEfbS2xTdJu9N 0UJSQ82lmYkFFiqGWjYyxhT7IdrSSopII5LKJRSmVhhIIUXQtmcl959zz3e+e+53+ChCWU4G U1lmK+bNXA5D+ku7H6o2RrorOlM0l74hfXXpZYn+UflHuf7WZKK+aeC5TP/y7lVS/7bkOqkv 6x2Q75Qbrt2fkhgcHZWkoXEo2XDe2YEMs441SbJUvC0TcxmYD8PmdEtGltkYz+w7lJaYpovR sJFsnD6WCTNzJhzP7NqfFLk7K8fzCSYsn8vJ81BJnCAwW7Zv4y15VhyWaRGs8cwRltWqWU2s WqvVqqOjjm7V6jySYzjz07tGaa6LKvjaW04UozNyG/KjgI6G51/rZCJeDi/cnaQN+VNKuhVB ZZldJl4qJFDSbPvXUVw8R4iFdgTXeocl3oKCXgpzdW6pDVEUQYfCwEi2lyZoFXTd65SLejeC lqpRqaiPgJ6Wz6QXS+lw+NZd4TMgPXzf5KiPX0KvhVdzH5AXB9EpcKfph++hZbRNAs1jbT5R IH0Y6u19hNfYjzbAzMhxrwboNjlcmrkh8fJAh4CjnxAH2AXdvU+kIg6E6cfO+cFWwe/WN0js PYfAPlUqEy9VCErsg6SoioL3425CHC0Aqn99nDdQwNlypSgxQOXL2XmzBGj8fnY+xisIfrZ9 RxdQaMOCwBr+B9awILBmRHSg5ThXMBmxoMtl1QJnEvLMRnW6xeRAvh2M2NyD3M37XIimELNY Ma7rTFHKuHyh0ORCQBHMMsUJo4dSZHCFJzFvSePzcrDgQjpP3rVEcFC6xbPRZmsaGx3DRmvj PCeWjWVWKFI1tSlK2shZcTbGuZj/2yeh/IKLkabLeTD8dM2OoppTYz3I1HVRdad7kL9Vlj9X GrSBrB1e3X5jig1ar8rO2jSW7BgvSnAenE6qt9eYuInQm6pnibPJrS8ePA1Z+XoRP1rYEH57 YlI7XYlmoiwtSIcfxETYfq1zDu11TbS3JR7oPzxboBwMeNPqpgOavuwZTt/vGGGkQibHRhC8 wP0Btc5qC5kDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAIsWRmVeSWpSXmKPExsVy+t9jAd277esjDO5PVbHobZrOZHGs7Qm7 xboXzhbzj5xjtbi8aw6bxe3GFWwWrXuPsDuweyze85LJY9OqTjaPeScDPfq2rGL0+LxJLoA1 ys0mIzUxJbVIITUvOT8lMy/dVik0xE3XQkkhLzE31VYpQtc3JEhJoSwxpxTIMzJAAw7OAe7B Svp2CW4Zz+/MYyk4xFHxdm8bcwNjM3sXIyeHhICJREPDD2YIW0ziwr31bCC2kMBSRokPD5NB bF4BQYkfk++xdDFycDALyEscuZQNEmYWUJeYNG8RUCsXUPkDRom/14+yQdRrSexY9BrMZhFQ lfiwrR1sFxtQfP+LG2BxfgFFias/HjOCzBQViJDoPlEJMkdEoItJ4nz3bbAaYYFQialr9kMt mMsoMa/1PRNIA6eAh8T7S0kTGAVmITlvFsJ5s5Cct4CReRWjRGpBckFxUnquUV5quV5xYm5x aV66XnJ+7iZGcGw9k97BeHiX+yFGAQ5GJR7ejhfrIoRYE8uKK3MPMUpwMCuJ8Kalr48Q4k1J rKxKLcqPLyrNSS0+xGgK9N9EZinR5Hxg3OeVxBuamJuYGxtYmFtamhgpifM2zn4WLiSQnliS mp2aWpBaBNPHxMEp1cBY9K/l4aELDxXyHsVfZD2hJ8HQ6Pyj7UhVzUkWlbS2ltV2+9Zs+nLB ssGSI0+y6vm516tDWpYIF9Wx3Oxv1SzYekiFeeJvkyez1tk4LC7xUirvrnVbPS/eOrlk0R1m KcVgudkLZ5gpdvAvbGK7fIDxRWwlf9CZnAsf4u4p7Lz1NGD7+m1TdsQosRRnJBpqMRcVJwIA J1r4VcMCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170224010949epcas5p16a4424229f4bf986dfc0f537808bdda1 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS/ssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTNS9TZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170223103303epcas3p496d768c3638368e98a9f6d95cb13380b X-RootMTR: 20170223103303epcas3p496d768c3638368e98a9f6d95cb13380b References: <20170223103156.109643-1-andriy.shevchenko@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017년 02월 23일 19:31, Andy Shevchenko wrote: > gpiod_to_irq() doesn't return 0. Thus, we just adjust condition and > replace -EINVAL by actual error code it returns. > > Signed-off-by: Andy Shevchenko > --- > drivers/extcon/extcon-intel-int3496.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c > index a3131b036de6..38eb6cab938f 100644 > --- a/drivers/extcon/extcon-intel-int3496.c > +++ b/drivers/extcon/extcon-intel-int3496.c > @@ -100,9 +100,9 @@ static int int3496_probe(struct platform_device *pdev) > } > > data->usb_id_irq = gpiod_to_irq(data->gpio_usb_id); > - if (data->usb_id_irq <= 0) { > + if (data->usb_id_irq < 0) { > dev_err(dev, "can't get USB ID IRQ: %d\n", data->usb_id_irq); > - return -EINVAL; > + return data->usb_id_irq; > } > > data->gpio_vbus_en = devm_gpiod_get_index(dev, "vbus en", > Applied it. Thanks. -- Best Regards, Chanwoo Choi Samsung Electronics