From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751749AbdBXBRS (ORCPT ); Thu, 23 Feb 2017 20:17:18 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:54679 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751687AbdBXBRP (ORCPT ); Thu, 23 Feb 2017 20:17:15 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a35-f79d66d000001a37-06-58af899940bc Content-transfer-encoding: 8BIT Message-id: <58AF8998.5000601@samsung.com> Date: Fri, 24 Feb 2017 10:17:12 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Andy Shevchenko , MyungJoo Ham , linux-kernel@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, David Cohen , Felipe Balbi Subject: Re: [PATCH v1 2/3] extcon: int3496: Rename GPIO pins in accordance with binding In-reply-to: <20170223103156.109643-2-andriy.shevchenko@linux.intel.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplk+LIzCtJLcpLzFFi42LZdlhTX3dm5/oIg6P7uC16m6YzWRxre8Ju se6Fs8X8I+dYLS7vmsNmcbtxBZtF694j7A7sHov3vGTy2LSqk81j3slAj74tqxg9Pm+SC2CN SrXJSE1MSS1SSM1Lzk/JzEu3VfIOjneONzUzMNQ1tLQwV1LIS8xNtVVy8QnQdcvMATpCSaEs MacUKBSQWFyspG9nU5RfWpKqkJFfXGKrFG1oaKRnaGCuZ2RkpGdiHGtlZApUkpCacXHSU6aC nUIVx6btYWlgnMnfxcjJISFgItH3q5ERwhaTuHBvPVsXIxeHkMAORom3F+exQDjtTBI/d89h gum4uf8XK4gtJDCHUeLBpkoQm1dAUOLH5HtADRwczALyEkcuZYOEmQU0JbbuXs8OUX6PUeLa EVOIci2Jraeeg41kEVCVeHZoLzOIzQYU3//iBhuIzS+gKHH1x2Ow40QFIiR2zv/GDnKPiEAX k8SCu8vAioQFoiT6Xx8GszkFPCQ2d2wAK5IQWMUu8WvFFrCDJARkJTYdYIa430Vi7stOqI+F JV4d38IOYUtLrPp3iwmit5tRYs3LJlYIp4dRonHNUTaIKmOJ+w/uMUO8xifx7msPK8QCXomO NiGIEg+JBYc2QJU7SizcvIoZEoo3GSUevfzMPoFRfhZSgM1CBNgspABbwMi8ilEstaA4Nz21 2LDAUK84Mbe4NC9dLzk/dxMjOAlqme5gnHLO5xCjAAejEg+vwbN1EUKsiWXFlbmHGCU4mJVE eNPS10cI8aYkVlalFuXHF5XmpBYfYjQFBvhEZinR5Hxggs4riTc0MTM0MTIxNDQ3MjBSEudl NZgYISSQnliSmp2aWpBaBNPHxMEp1cDo22bCNHNukLaY5U+ZltWponHs6unPhH4Ue2wwy17s orV511f9InfJRykFUVVTDvH+CHytFfRaqZ17koyVsqDlv/3ZGRnhDycccozkLjg+LzJqW/Hh v073uuPn8pd4SLVM3nHMbdPKdzX3RZSuHyxSMH9o8GsBt/FqC9/Qz0EXj/742xt1OEmJpTgj 0VCLuag4EQAGk5StmAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrEIsWRmVeSWpSXmKPExsVy+t9jQd0ZnesjDG5MtrbobZrOZHGs7Qm7 xboXzhbzj5xjtbi8aw6bxe3GFWwWrXuPsDuweyze85LJY9OqTjaPeScDPfq2rGL0+LxJLoA1 ys0mIzUxJbVIITUvOT8lMy/dVik0xE3XQkkhLzE31VYpQtc3JEhJoSwxpxTIMzJAAw7OAe7B Svp2CW4ZFyc9ZSrYKVRxbNoelgbGmfxdjJwcEgImEjf3/2KFsMUkLtxbz9bFyMUhJDCLUWLX z1mMIAleAUGJH5PvsXQxcnAwC8hLHLmUDRJmFlCXmDRvETNE/QNGiUUXjjND1GtJbD31nAnE ZhFQlXh2aC9YnA0ovv/FDTYQm19AUeLqj8eMIDNFBSIkuk9UgswREehikjjffRusRlggSqL/ 9WGog24ySjxpWQB2KaeAh8Tmjg3sExiBzkS4bxbCfbOQ3LeAkXkVo0RqQXJBcVJ6rmFearle cWJucWleul5yfu4mRnB8PZPawXhwl/shRgEORiUe3gev1kUIsSaWFVfmHmKU4GBWEuFNS18f IcSbklhZlVqUH19UmpNafIjRFOjBicxSosn5wNjPK4k3NDE3MTc2sDC3tDQxUhLnbZz9LFxI ID2xJDU7NbUgtQimj4mDU6qB8YSNdd0Oq9nv57Gl7tAy5O9h+W4rfs4//7Xb0V15F4SuiUjM V2p+yyZeaZPo+M3B80f96uPzLj326WzuUHAINP/S+j9zzj/rFQsaXzouXKmT/WRl2BIlJZdz 7jbPQr80+ge6VEqqW3rwbn8+Rab4/7L5sadjNN58t/gs9lxTTrFqwf+lfV/fKLEUZyQaajEX FScCALfXvzDFAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170224011713epcas1p4042a65e90495453d83cf455d20d34961 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS/ssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTNS9TZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170223103203epcas1p1512e927e6f4c85e793d65c2e426ed1d6 X-RootMTR: 20170223103203epcas1p1512e927e6f4c85e793d65c2e426ed1d6 References: <20170223103156.109643-1-andriy.shevchenko@linux.intel.com> <20170223103156.109643-2-andriy.shevchenko@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2017년 02월 23일 19:31, Andy Shevchenko wrote: > First of all, add an optional binding for external muxer which might be > used. > > Second, update GPIO pin names in extcon-intel-int3496.c driver to follow > the existing binding. > > Signed-off-by: Andy Shevchenko > --- > Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt | 3 +++ > drivers/extcon/extcon-intel-int3496.c | 4 ++-- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt > index dfc14f71e81f..9d97472ae51d 100644 > --- a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt > +++ b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt > @@ -10,6 +10,9 @@ Either one of id-gpio or vbus-gpio must be present. Both can be present as well. > - id-gpio: gpio for USB ID pin. See gpio binding. > - vbus-gpio: gpio for USB VBUS pin. > > +Optional properties: > +- mux-gpios: gpio for USB external muxer The Documentation/extcon/intel-int3496.txt includes already the information for id/vbus/mux pin. The extcon-usb-gpio.txt is not related with the extcon-int3496 driver. > + > Example: Examples of extcon-usb-gpio node in dra7-evm.dts as listed below: > extcon_usb1 { > compatible = "linux,extcon-usb-gpio"; > diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c > index 38eb6cab938f..81713bf7487e 100644 > --- a/drivers/extcon/extcon-intel-int3496.c > +++ b/drivers/extcon/extcon-intel-int3496.c > @@ -105,13 +105,13 @@ static int int3496_probe(struct platform_device *pdev) > return data->usb_id_irq; > } > > - data->gpio_vbus_en = devm_gpiod_get_index(dev, "vbus en", > + data->gpio_vbus_en = devm_gpiod_get_index(dev, "vbus", > INT3496_GPIO_VBUS_EN, > GPIOD_ASIS); > if (IS_ERR(data->gpio_vbus_en)) > dev_info(dev, "can't request VBUS EN GPIO\n"); > > - data->gpio_usb_mux = devm_gpiod_get_index(dev, "usb mux", > + data->gpio_usb_mux = devm_gpiod_get_index(dev, "mux", > INT3496_GPIO_USB_MUX, > GPIOD_ASIS); > if (IS_ERR(data->gpio_usb_mux)) > -- Best Regards, Chanwoo Choi Samsung Electronics