From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751422AbdBXBdJ (ORCPT ); Thu, 23 Feb 2017 20:33:09 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:50071 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751242AbdBXBdH (ORCPT ); Thu, 23 Feb 2017 20:33:07 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a2d-f793d6d0000012b6-e0-58af8cc40962 Content-transfer-encoding: 8BIT Message-id: <58AF8CC3.7080703@samsung.com> Date: Fri, 24 Feb 2017 10:30:43 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Andy Shevchenko , MyungJoo Ham , linux-kernel@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, David Cohen , Felipe Balbi Subject: Re: [PATCH v1 3/3] extcon: int3496: Add GPIO ACPI mapping table In-reply-to: <20170223103156.109643-3-andriy.shevchenko@linux.intel.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjk+LIzCtJLcpLzFFi42LZdlhTXfdIz/oIg9mbzSx6m6YzWRxre8Ju se6Fs8X8I+dYLS7vmsNmcbtxBZtF694j7A7sHov3vGTy2LSqk81j3slAj74tqxg9Pm+SC2CN SrXJSE1MSS1SSM1Lzk/JzEu3VfIOjneONzUzMNQ1tLQwV1LIS8xNtVVy8QnQdcvMATpCSaEs MacUKBSQWFyspG9nU5RfWpKqkJFfXGKrFG1oaKRnaGCuZ2RkpGdiHGtlZApUkpCaMWH5TtaC 80IVtw4eYGpgnMTfxcjJISFgInGl5wE7hC0mceHeerYuRi4OIYGljBJNP7uYIZx2JomW5+dY YDpetS9jgUgsB6o6PQMswSsgKPFj8j0gm4ODWUBe4silbJAws4CmxNbd69kh6u8xSjTeXMEE Ua8lcWbaK2YQm0VAVWJDy002EJsNKL7/xQ0wm19AUeLqj8eMILaoQITEzvnfwAaJCHQxSSy4 uwysSFjAQ+L0xF6wHziB7CVzl4EVSQisYpfYc/QVG8hFEgKyEpsOMEOYLhJTthdBPCMs8er4 Fqj3pSX+Lr3FCNHazSix5mUTK4TTA3T1mqNsEFXGEvcf3GOGeI1Povf3EyaIobwSHW1CECUe EifPb4Ya6ijx/MFDaJjeZJRo7TrMPIFRfhZSgM1CBNgspABbwMi8ilEstaA4Nz212LTASK84 Mbe4NC9dLzk/dxMjOA1q6e5g/LLA+xCjAAejEg9vRtL6CCHWxLLiytxDjBIczEoivGnpQCHe lMTKqtSi/Pii0pzU4kOMpsDwnsgsJZqcD0zReSXxhiZmhiZGlkBobmiuJM4bZTAxQkggPbEk NTs1tSC1CKaPiYNTqoEx/MHpUNn+Iw5F+faKszgLiuMmRU8zYO7ctF3xcGuk2KSEtE/5nPnS 7zv4vsakvxRcb9Hw6AWPwhmhlbF/zKv+aPkWOHHG9i/sbAg4lZA1hc9yziLhd9ukAie3M7b3 brx7eVX4+b/LGa9KnZ4hpso3dffiqVOP3SoWrrfheNvMJLdb7IbQn1AlluKMREMt5qLiRAD8 DuONmQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsVy+t9jAd0jPesjDJp28Vv0Nk1nsjjW9oTd Yt0LZ4v5R86xWlzeNYfN4nbjCjaL1r1H2B3YPRbvecnksWlVJ5vHvJOBHn1bVjF6fN4kF8Aa 5WaTkZqYklqkkJqXnJ+SmZduqxQa4qZroaSQl5ibaqsUoesbEqSkUJaYUwrkGRmgAQfnAPdg JX27BLeMCct3shacF6q4dfAAUwPjJP4uRk4OCQETiVfty1ggbDGJC/fWs4HYQgJLGSXOLwsB sXkFBCV+TL4HVMPBwSwgL3HkUjZImFlAXWLSvEXMXYxcQOUPGCUObfvMClGvJXFm2itmEJtF QFViQ8tNsJlsQPH9L26A2fwCihJXfzxmBJkpKhAh0X2iEmSOiEAXk8T57ttgNcICHhKnJ/ay Qyy4ySjR+f0kI0iCEyixZO4y9gmMArOQ3DcL4b5ZSO5bwMi8ilEitSC5oDgpPdcoL7Vcrzgx t7g0L10vOT93EyM4up5J72A8vMv9EKMAB6MSD2/Hi3URQqyJZcWVuYcYJTiYlUR409LXRwjx piRWVqUW5ccXleakFh9iNAV6cCKzlGhyPjDy80riDU3MTcyNDSzMLS1NjJTEeRtnPwsXEkhP LEnNTk0tSC2C6WPi4JRqYCx70/x9xiO1D7p1vRk70jJmqmavKuksnhXK9mfB8zit2M2duvMF NizSnrdWv/6TX84W47YPDSvTtmy0ySgInCxQtfjuwjus/e/e8gS5f9KTjjxaXKtxaTZH9/St BvsFemLc0yq/njnWtGKSg9D9TU/Ncz6ouc/LPl//K+vErjNKT2fNddmV/UOJpTgj0VCLuag4 EQCKuvIdxAIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170224013044epcas5p467ed81ca74f2af89f13c7092534670fe X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS/ssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTNS9TZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170223103233epcas2p1c4c914cb79395704d8fce85e2b23f43d X-RootMTR: 20170223103233epcas2p1c4c914cb79395704d8fce85e2b23f43d References: <20170223103156.109643-1-andriy.shevchenko@linux.intel.com> <20170223103156.109643-3-andriy.shevchenko@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2017년 02월 23일 19:31, Andy Shevchenko wrote: > In order to make GPIO ACPI library stricter prepare users of > gpiod_get_index() to correctly behave when there no mapping is > provided by firmware. > > Here we add explicit mapping between _CRS GpioIo() resources and > their names used in the driver. > > Signed-off-by: Andy Shevchenko > --- > drivers/extcon/extcon-intel-int3496.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/extcon/extcon-intel-int3496.c b/drivers/extcon/extcon-intel-int3496.c > index 81713bf7487e..1abe9071d9d0 100644 > --- a/drivers/extcon/extcon-intel-int3496.c > +++ b/drivers/extcon/extcon-intel-int3496.c > @@ -45,6 +45,17 @@ static const unsigned int int3496_cable[] = { > EXTCON_NONE, > }; > > +static const struct acpi_gpio_params id_gpios = { INT3496_GPIO_USB_ID, 0, false }; > +static const struct acpi_gpio_params vbus_gpios = { INT3496_GPIO_VBUS_EN, 0, false }; > +static const struct acpi_gpio_params mux_gpios = { INT3496_GPIO_USB_MUX, 0, false }; > + > +static const struct acpi_gpio_mapping acpi_int3496_default_gpios[] = { > + { "id-gpios", &id_gpios, 1 }, > + { "vbus-gpios", &vbus_gpios, 1 }, > + { "mux-gpios", &mux_gpios, 1 }, > + { }, > +}; > + > static void int3496_do_usb_id(struct work_struct *work) > { > struct int3496_data *data = > @@ -83,6 +94,13 @@ static int int3496_probe(struct platform_device *pdev) > struct int3496_data *data; > int ret; > > + ret = acpi_dev_add_driver_gpios(ACPI_COMPANION(dev), > + acpi_int3496_default_gpios); > + if (ret) { > + dev_err(dev, "can't add GPIO ACPI mapping\n"); > + return ret; > + } > + > data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); > if (!data) > return -ENOMEM; > @@ -154,6 +172,7 @@ static int int3496_remove(struct platform_device *pdev) > devm_free_irq(&pdev->dev, data->usb_id_irq, data); > cancel_delayed_work_sync(&data->work); > > + acpi_dev_remove_driver_gpios(ACPI_COMPANION(&pdev->dev)); Need to add the one blank line. > return 0; > } > Looks good to me. Reviewed-by: Chanwoo Choi This patch depends on the patch2. So, after resending the v2, I'll merge them if there is no problem. -- Best Regards, Chanwoo Choi Samsung Electronics