From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751282AbdBXD6e (ORCPT ); Thu, 23 Feb 2017 22:58:34 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:45647 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751049AbdBXD6Z (ORCPT ); Thu, 23 Feb 2017 22:58:25 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a2d-f793d6d0000012b6-bd-58afac255b44 Content-transfer-encoding: 8BIT Message-id: <58AFAC24.4080202@samsung.com> Date: Fri, 24 Feb 2017 12:44:36 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Enric Balletbo i Serra , MyungJoo Ham , Rob Herring Cc: Lee Jones , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Benson Leung Subject: Re: [PATCH 2/2] dt-bindings: extcon: Add support for cros-ec device In-reply-to: <20170220151854.22859-3-enric.balletbo@collabora.com> X-Brightmail-Tracker: H4sIAAAAAAAAA01SfUgTcRjmt7vdTnF2zrQ3o1oXQppbu2vqZdqn1aIIoYJhyLr02iS3yd20 DyLMykrLvrE0KzApRFqtjLKiWmoUZR9WVEsNWvRhRdGXJX3cdkXx++f5Pe/zfj28JKbbSySQ hS6PILr4IpqIxE9fSRpjSGz2Wk2H68dyNcEunDvY1qnmmgN+xPV+bkdcV+t+ggusPUpwGy60 aaZoLHVld3DLme7DyOJr2kxYnjw4T1iqTzUhy0ffiBwiV8h0CHyBIOoFV767oNBlz6LnzLdN t6WmmRgDM4FLp/Uu3ilk0dlzcwwzC4vkWWh9KV9UIlM5vCTR4yZliu4Sj6B3uCVPFr2IYVgj Y0o3sixrNI/Py2BTZcliwdHSWkEUB6JXeDsD6jJUHVWJSBIoM3hbyUoUIcN4uN3jJSpRJKmj GhHce9OAlM9GFXRcrEaKygw/7+7BlMARBA1VfepQQEvFQP+uHjxUFaNGQtvdZSEao5Kg5ZxX o+h7ENS01BOKPhmunP+ChTBOJUJDf1WYJ2T+4suHYTyIGgX3+5+FG8dRVjh78Eu40GCqAsG5 4Em10mE9gsvBtBCOpeZC+/E6TQhHUNNgd/AAHkoAqkMDN6614crOw8F3CVO2yYZ1d8r/bBYL r6+e0ih4GPxofIyU3CoEza/K1cpnC4K1ze2EohoPvU97MGWKaNg6EFQpDbSwqUKnQAu8aIhT 1FPhRfe2P/7eRHCp84FqO9LX/mde7T/zav8z7xDCmlC8UCw57YKUWswaJd4plbjsxny304fC V5lsOIM+HZrjRxSJ6CitY4nXqlPzpdJKpx8BidGDtUvtMqUt4FeuEkS3TSwpEiQ/SpW934El xOW75Rt3eWyMOY0xsxPkl86k00O0uaYdVh1l5z3CMkEoFsS/eSoyIqEMsV/Pvqt3XDX82siL 1+p069m3q7lZ763+saZbC1ZlBE9EL9+a3Kd6N5A3Y1JKzd7GyeueD8QeGL1nyrf2lOyJXfz+ mA8bJHEWY+2bjEduur4zN8m2r3ThI0fFvM3PZyfGZGSV71wTlVnn6+jdvrD7fcrS+CPMw6Hl gco0+J5XXX9MP5rGJQfPJGOixP8GiDu4/6sDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGIsWRmVeSWpSXmKPExsVy+t9jAV3VNesjDNYsY7OY/uQyi8X8I+dY LdbcPsRocf/rUUaLy7vmsFncblzBZtG69wi7A7vH7IaLLB477i5h9Ni0qpPN4861PWwefVtW MXp83iQXwBblZpORmpiSWqSQmpecn5KZl26rFBripmuhpJCXmJtqqxSh6xsSpKRQlphTCuQZ GaABB+cA92AlfbsEt4ytu9rYCm7zVaw/d5u1gbGPp4uRk0NCwETi36WpzBC2mMSFe+vZuhi5 OIQEljJKNP6aCJbgFRCU+DH5HksXIwcHs4C8xJFL2SBhZgF1iUnzFjFD1D9glLg48RZUvZbE 4T3fwGwWAVWJxT+62UBsNqD4/hc3wGx+AUWJqz8eM4LMFBWIkOg+UQkyR0SgjVHi5PaNLCAO s0ALo8S7LWsYQRqEBXwkjm6YzQ6x7SyjxPp5+1hBEpwCThJTnsxjmcAoOAvJsbMQjp2F5NgF jMyrGCVSC5ILipPSc43yUsv1ihNzi0vz0vWS83M3MYLj8Jn0DsbDu9wPMQpwMCrx8Ha8WBch xJpYVlyZe4hRgoNZSYQ3LX19hBBvSmJlVWpRfnxRaU5q8SFGU6BvJzJLiSbnA1NEXkm8oYm5 ibmxgYW5paWJkZI4b+PsZ+FCAumJJanZqakFqUUwfUwcnFINjHOfOUrqrbVZ9Wy+cnJB7MmG mUe6nXXnJaf9z7PnulZXkW76U39xTGLTr6q1jjc2e/zqedy57rbk7uS1H87eTpbLOHNkT7uj 8kWXxZLX+NY11Wyb8tbBSdj/yA7ftmvvfSslznsYvNp6S86ufOuTWgGODhWPrw6Xz72etHvS vpCXV93OK642y1diKc5INNRiLipOBADBizfV2QIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170224034437epcas5p44e195c862e79678599fbc7c8339131f4 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbUzUo7LGF7J6EKS/ssYXsnoQ=?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTNS9TZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170220151910epcas1p38ddbee98fb84886179d4cd3243eec85d X-RootMTR: 20170220151910epcas1p38ddbee98fb84886179d4cd3243eec85d References: <20170220151854.22859-1-enric.balletbo@collabora.com> <20170220151854.22859-3-enric.balletbo@collabora.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017년 02월 21일 00:18, Enric Balletbo i Serra wrote: > From: Benson Leung > > This patch add documentation for binding of USB Type C cable detection > mechanism is using EXTCON subsystem. The device can detect the presence > of display out but it may also detect other external accessories when > external accessories is attached or detached. > > Signed-off-by: Benson Leung > Signed-off-by: Enric Balletbo i Serra > --- > .../devicetree/bindings/extcon/extcon-cros-ec.txt | 24 ++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > create mode 100644 Documentation/devicetree/bindings/extcon/extcon-cros-ec.txt > > diff --git a/Documentation/devicetree/bindings/extcon/extcon-cros-ec.txt b/Documentation/devicetree/bindings/extcon/extcon-cros-ec.txt > new file mode 100644 > index 0000000..3576869 > --- /dev/null > +++ b/Documentation/devicetree/bindings/extcon/extcon-cros-ec.txt > @@ -0,0 +1,24 @@ > +ChromeOS EC Type-C Extcon device > + > +On ChromeOS systems with USB Type C ports, the ChromeOS Embedded Controller is > +able to detect the state of external accessories such as display adapters > +or USB devices when said accessories are attached or detached. > + > +The node for this device must be under a cros-ec node like google,cros-ec-spi > +or google,cros-ec-i2c. > + > +Required properties: > +- compatible: Should be "google,extcon-cros-ec". > +- google,usb-port-id: Specifies the USB port ID to use. > + > +Example: > + cros-ec@0 { > + compatible = "google,cros-ec-i2c"; > + > + ... > + > + extcon { > + compatible = "google,extcon-cros-ec"; > + google,usb-port-id = <0>; > + }; > + } > Looks good to me. Reviewed-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics