From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751976AbdB1HST (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Feb 2017 02:18:19 -0500
Received: from mail-out.m-online.net ([212.18.0.10]:44643 "EHLO
        mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751799AbdB1HSH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Feb 2017 02:18:07 -0500
X-Auth-Info: Wjdh+y3YXf5bOqAHMTOC7I+6leBRhov5kKApBP5NAVo=
Subject: Re: [v2] Input: pwm-beeper: support customized freq for SND_BELL
To: David Lechner <david@lechnology.com>
References: <1487579863-7256-1-git-send-email-hs@denx.de>
 <06af466d-ac78-ea38-77d2-3bf32a6e157c@lechnology.com>
 <58B5084A.9000709@denx.de>
 <b08d4e74-c086-304a-d6cf-ace8d2a372f7@lechnology.com>
Cc: linux-input@vger.kernel.org, Guan Ben <ben.guan@cn.bosch.com>,
        Mark Jonas <mark.jonas@de.bosch.com>, devicetree@vger.kernel.org,
        Thierry Reding <thierry.reding@gmail.com>,
        linux-kernel@vger.kernel.org,
        Boris Brezillon <boris.brezillon@free-electrons.com>,
        Rob Herring <robh+dt@kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Manfred Schlaegl <manfred.schlaegl@gmx.at>,
        Mark Rutland <mark.rutland@arm.com>
Reply-To: hs@denx.de
From: Heiko Schocher <hs@denx.de>
Message-ID: <58B51517.4050003@denx.de>
Date: Tue, 28 Feb 2017 07:13:43 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <b08d4e74-c086-304a-d6cf-ace8d2a372f7@lechnology.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello David,

Am 28.02.2017 um 06:30 schrieb David Lechner:
> On 02/27/2017 11:19 PM, Heiko Schocher wrote:
>> Hello David,
>>
>> Am 27.02.2017 um 19:11 schrieb David Lechner:
>>> On 02/20/2017 02:37 AM, Heiko Schocher wrote:
>>>> From: Guan Ben <ben.guan@cn.bosch.com>
>>>>
>>>> extend the pwm-beeper driver to support customized frequency
>>>> for SND_BELL from device tree.
>>>>
>>>> Signed-off-by: Guan Ben <ben.guan@cn.bosch.com>
>>>> Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com>
>>>> [hs@denx.de: adapted to 4.10-rc7]
>>>> Signed-off-by: Heiko Schocher <hs@denx.de>
>>>> ---
>>>>
>>>> Changes in v2:
>>>> - add comment from Rob Herring:
>>>>   rename property name "bell-frequency" to "beeper-hz"
>>>
>>> Is there a separate patch for the devicetree bindings documentation?
>>
>> No, it is in this patch ... In the meantime I got an
>> Acked-by from Rob Herring ...
>>
>
> What I should have said is that, in general, I think it is preferred to have the device tree
> bindings as a separate patch from the code changes.

I can split this into 2 patches ...

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany