From: Heiko Schocher <hs@denx.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: David Lechner <david@lechnology.com>,
linux-input@vger.kernel.org, Guan Ben <ben.guan@cn.bosch.com>,
Mark Jonas <mark.jonas@de.bosch.com>,
devicetree@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
linux-kernel@vger.kernel.org,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Rob Herring <robh+dt@kernel.org>,
Manfred Schlaegl <manfred.schlaegl@gmx.at>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [v2] Input: pwm-beeper: support customized freq for SND_BELL
Date: Wed, 1 Mar 2017 06:05:11 +0100 [thread overview]
Message-ID: <58B65687.3090801@denx.de> (raw)
In-Reply-To: <F4017B97-7994-4F44-8345-A1A6C3A14777@gmail.com>
Hello Dimitry,
Am 28.02.2017 um 07:20 schrieb Dmitry Torokhov:
> On February 27, 2017 10:13:43 PM PST, Heiko Schocher <hs@denx.de> wrote:
>> Hello David,
>>
>> Am 28.02.2017 um 06:30 schrieb David Lechner:
>>> On 02/27/2017 11:19 PM, Heiko Schocher wrote:
>>>> Hello David,
>>>>
>>>> Am 27.02.2017 um 19:11 schrieb David Lechner:
>>>>> On 02/20/2017 02:37 AM, Heiko Schocher wrote:
>>>>>> From: Guan Ben <ben.guan@cn.bosch.com>
>>>>>>
>>>>>> extend the pwm-beeper driver to support customized frequency
>>>>>> for SND_BELL from device tree.
>>>>>>
>>>>>> Signed-off-by: Guan Ben <ben.guan@cn.bosch.com>
>>>>>> Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com>
>>>>>> [hs@denx.de: adapted to 4.10-rc7]
>>>>>> Signed-off-by: Heiko Schocher <hs@denx.de>
>>>>>> ---
>>>>>>
>>>>>> Changes in v2:
>>>>>> - add comment from Rob Herring:
>>>>>> rename property name "bell-frequency" to "beeper-hz"
>>>>>
>>>>> Is there a separate patch for the devicetree bindings
>> documentation?
>>>>
>>>> No, it is in this patch ... In the meantime I got an
>>>> Acked-by from Rob Herring ...
>>>>
>>>
>>> What I should have said is that, in general, I think it is preferred
>> to have the device tree
>>> bindings as a separate patch from the code changes.
>>
>> I can split this into 2 patches ...
>
> Don't - since Rob already asked DT change you don't need to post to device tree list again and I'll merge them back together since they do not make sense separately.
Ok, I post a v3 with the changes suggested from David and Rob soon,
without splitting.
Thanks!
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2017-03-01 5:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 8:37 [PATCH v2] Input: pwm-beeper: support customized freq for SND_BELL Heiko Schocher
2017-02-27 18:11 ` [v2] " David Lechner
2017-02-28 5:19 ` Heiko Schocher
2017-02-28 5:30 ` David Lechner
2017-02-28 6:13 ` Heiko Schocher
2017-02-28 6:20 ` Dmitry Torokhov
2017-03-01 5:05 ` Heiko Schocher [this message]
2017-02-27 19:10 ` [PATCH v2] " Rob Herring
2017-02-28 5:20 ` Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58B65687.3090801@denx.de \
--to=hs@denx.de \
--cc=ben.guan@cn.bosch.com \
--cc=boris.brezillon@free-electrons.com \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred.schlaegl@gmx.at \
--cc=mark.jonas@de.bosch.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).