From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754511AbdCBInq (ORCPT ); Thu, 2 Mar 2017 03:43:46 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:48984 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754259AbdCBIn3 (ORCPT ); Thu, 2 Mar 2017 03:43:29 -0500 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a2e-f79d66d0000012ad-b7-58b7c9c0ffc2 Content-transfer-encoding: 8BIT Message-id: <58B7C9BF.1040708@samsung.com> Date: Thu, 02 Mar 2017 16:29:03 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Enric Balletbo i Serra , MyungJoo Ham , Rob Herring Cc: Lee Jones , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Benson Leung Subject: Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out. In-reply-to: <20170301111943.12170-2-enric.balletbo@collabora.com> X-Brightmail-Tracker: H4sIAAAAAAAAA01Sa0hTYRjm29nOjtLqNK3erGweqVDc9MypszS6yqIguwhShB30axPdhZ0Z rYKstJWgKEWFWholpV2sVZqaZWtdBE0tSsvSykFRWFEUQhjt7CjF9+f5nvf2vA8vRSgryTAq 1+LAdguXz5DB0qb7UVHqjs7mzLjRs1r9Cd8zqb7G+0SmvzToQfrhnw+Q/llrNakf3H+B1Be3 e+XL5Iaqwj6p4dabc8jgbjhCGl6/uE0aym40IMMPd3g6uQWnmDCXg+0qbMm25uRajKnM2k1Z K7MSEuNYNZusT2JUFs6MU5lV69LVabn5fi2MaieXX+Cn0jmeZ2KXptitBQ6sMll5RyqzlWW1 GjYuSaPVajW6+G2LtQn+lO3Y1PXwvMR2dfou1+teVIjeKkpQEAW0Dq59bZeJeCb0DjWSJSiY UtJ1CGqKTk58XBJo7boom6z4WDcZqEZwpmlELgQU9HQYOzokLUEURdDzwfs0T6AJOgputjXK xfwhBOOfj0nE/GgYLa0nBCylF0BTcV+AJ/383Y8DpICn0RHwfGwECXgGnQktNb8CjULpQwja fNdl4oQiBPd8iQIOobeD92x3oGkQvQI+9z4KKAXaI4e+d+1yQR3Q88DdQYjbrIJ+V6dExCHw 6dENuYjnwHjdKyTWuhBcrxY2Ez6HEQzX75/wIh6G3w4RooqpUPrbJxEHKODwIaWYYoCKkacT TZdDz0A/Eq3oRuC7WCsrR6rK/9yr/Ode5X/u1SKiAc3ENt5sxHyCLV7Dc2a+wGLUZFvNbhS4 y2jNLfSndq0H0RRipii+eZozlTJuJ+80exBQBBOqmO31U4oczrkb261Z9oJ8zHtQgt/8CiJs RrbVf+UWRxarS2R12mT/S2KTmFmKLXEVmUrayDlwHsY2bJ+sk1BBYYVo4bHTIeo9d05sDC9v +f54fs+XUfOv3Y3f2FnuJVfIudnFMQsXvWzZt+n36qrRQndKz5XY+Pe1m/eWph10zmvNOB7r anbmJd+8Z8wwjVMjEZEHDg60F5Xoxl5SMfDk+xkb/rA8eO+O8n7GeTkjLaYtpHdwsGN96JLk SM+GiFPqNUWdZYyUN3FsNGHnub+OuGiprQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGIsWRmVeSWpSXmKPExsVy+t9jQd0DJ7dHGEzbqGox/cllFov5R86x Wqy5fYjR4v7Xo4wWl3fNYbO43biCzaJ17xF2B3aP2Q0XWTx23F3C6LFpVSebx51re9g8+ras YvT4vEkugC3KzSYjNTEltUghNS85PyUzL91WKTTETddCSSEvMTfVVilC1zckSEmhLDGnFMgz MkADDs4B7sFK+nYJbhlnji1nKtggWNF+5wJjA+MD3i5GTg4JAROJF0tnsEHYYhIX7q0Hsrk4 hARmMUp8ePwDLMErICjxY/I9li5GDg5mAXmJI5eyQcLMAuoSk+YtYoaof8AocfvaNKh6LYm3 vSuZQWwWAVWJba0XmUBsNqD4/hc3wGr4BRQlrv54zAgyU1QgQqL7RCXIHBGBNkaJk9s3soA4 zAItjBLvtqxhBGkQFkiQOLL4LNS2s4wSS5ZfYwVJcAo4Sby+cJxtAqPgLCTHzkI4dhaSYxcw Mq9ilEgtSC4oTkrPNcpLLdcrTswtLs1L10vOz93ECI7DZ9I7GA/vcj/EKMDBqMTDe4Bpe4QQ a2JZcWXuIUYJDmYlEV7JI0Ah3pTEyqrUovz4otKc1OJDjKZA305klhJNzgemiLySeEMTcxNz YwMLc0tLEyMlcd7G2c/ChQTSE0tSs1NTC1KLYPqYODilGhgNVy3ru1PwpY7D8uGL43OPdq78 68/uYtKTx8pztTLVo//Xm42n4zZYylycs4pD+M1N3lCmq3OFMkTmTDqhaKdyOGWl6YxXM0va ua3XvZ949N7DioubAu2ZJU/sk8xZw/dt2sXSrF/B3dvnChgcK9108PsKzXtbHR/VPF/qvGp5 haH5qYN7y77OU2Ipzkg01GIuKk4EANsAtA7ZAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170302072904epcas5p24fa6a3627902c9e307407cf63f8149bb X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170301112844epcas4p34012f1564f1145f8d8a8967f4fe9a821 X-RootMTR: 20170301112844epcas4p34012f1564f1145f8d8a8967f4fe9a821 References: <20170301111943.12170-1-enric.balletbo@collabora.com> <20170301111943.12170-2-enric.balletbo@collabora.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2017년 03월 01일 20:19, Enric Balletbo i Serra wrote: > From: Benson Leung > > This is the driver for the USB Type C cable detection mechanism > built into the ChromeOS Embedded Controller on systems that > have USB Type-C ports. > > At present, this allows for the presence of display out, but in > future, it may also be used to notify host and device type cables > and the presence of power. > > Signed-off-by: Benson Leung > Signed-off-by: Enric Balletbo i Serra > --- > Changes since v1: > Requested by Chanwoo Choi > - Rename files changing _ for - > - Remove the unneeded blank line on bottom of header. > - Remove kobject.h and cros_ec_commands.h includes. > - Remove the debug message as is not necessary. > - Use the tab for indentation instead of space for if sentence. > - Define each variable on different lines when the variables should be > initialized. > - Remove EXTCON_USB and EXTCON_USB_HOST as are not really used for now. > - Add one blank line to split out between state and property setting. > - Add the author information (header and module) > > Enric Balletbo > - As Rob suggested to rename the compatible name to something indicating that > is USB Type C related I also renamed the file names, extcon-cros-ec -> > extcon-usbc-cros-ec, I think it's more clear. > > drivers/extcon/Kconfig | 7 + > drivers/extcon/Makefile | 1 + > drivers/extcon/extcon-usbc-cros-ec.c | 415 +++++++++++++++++++++++++++++++++++ > include/linux/mfd/cros_ec_commands.h | 75 +++++++ > 4 files changed, 498 insertions(+) > create mode 100644 drivers/extcon/extcon-usbc-cros-ec.c > Looks good to me. Acked-by: Chanwoo Choi I think this patch should be handled with patches[1]. [1] https://lkml.org/lkml/2017/2/14/655 I think that one maintainer among following subsystems (mfd, chrome h/w platform, rtc and extcon) will apply their git repository, and then one maintainer will send the pull request of immutable branch for these patches. -- Best Regards, Chanwoo Choi Samsung Electronics