From: Daniel Borkmann <daniel@iogearbox.net>
To: Fengguang Wu <fengguang.wu@intel.com>, netdev@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>, LKP <lkp@01.org>,
ast@fb.com
Subject: Re: [net/bpf] 3051bf36c2 BUG: unable to handle kernel paging request at 0000a7cf
Date: Thu, 02 Mar 2017 21:40:51 +0100 [thread overview]
Message-ID: <58B88353.2010508@iogearbox.net> (raw)
In-Reply-To: <20170302202338.ci6wwb3yzjmdy4n2@wfg-t540p.sh.intel.com>
On 03/02/2017 09:23 PM, Fengguang Wu wrote:
[...]
> I confirm that the below patch provided by Daniel fixes the above
> issues on mainline kernel, too. Where should this patch be sent to?
If nobody objects, I could send it to -net tree via Dave due to being
BPF related, but I don't mind sending it elsewhere too (f.e. Linus
directly?) in order to stop your bot from continuing to send such mails.
The issue seems only related to i386 and doesn't trigger each time with
Fengguang's kernel config and qemu image when I try to reproduce it.
set_memory_ro()/set_memory_rw() on i386 seems to work in general, but
when it's used/reproduced, from time to time (perhaps some corner-case?)
it looks like that memory area can have issues much later on after being
fed back to the allocator which then causes a GPF from random locations.
Gut feeling, it might be an issue in set_memory_*() that my commit
uncovered. Still looking into it, but mean-time I could just send the
below, sure.
Thanks,
Daniel
> It'd be very noisy if all these Oops hit the upcoming RC1 kernel.
>
> Daniel thinks there may be deeper problem in i386 set_memory_rw().
> However that could take much longer time to debug.
>
> Thanks,
> Fengguang
> ---
>
> Re: [bpf] 9d876e79df: BUG: unable to handle kernel paging request at 653a8346
>
>> On Tue, Feb 28, 2017 at 04:39:36PM +0100, Daniel Borkmann wrote:
>
> I have a rough feeling what it is, but I didn't have cycles to work on
> it yet (due to travel, sorry about that). The issue is likely shut down
> by just doing:
>
> ---
> arch/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux.orig/arch/x86/Kconfig 2017-03-03 03:44:35.962022996 +0800
> +++ linux/arch/x86/Kconfig 2017-03-03 03:44:35.962022996 +0800
> @@ -54,7 +54,7 @@ config X86
> select ARCH_HAS_KCOV if X86_64
> select ARCH_HAS_MMIO_FLUSH
> select ARCH_HAS_PMEM_API if X86_64
> - select ARCH_HAS_SET_MEMORY
> + select ARCH_HAS_SET_MEMORY if X86_64
> select ARCH_HAS_SG_CHAIN
> select ARCH_HAS_STRICT_KERNEL_RWX
> select ARCH_HAS_STRICT_MODULE_RWX
next prev parent reply other threads:[~2017-03-02 21:31 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 12:54 [net/bpf] 3051bf36c2 BUG: unable to handle kernel paging request at 0000a7cf Fengguang Wu
2017-03-02 20:23 ` Fengguang Wu
2017-03-02 20:40 ` Daniel Borkmann [this message]
2017-03-08 19:25 ` Linus Torvalds
2017-03-08 22:27 ` Daniel Borkmann
2017-03-08 22:36 ` Kees Cook
2017-03-08 22:51 ` Daniel Borkmann
2017-03-08 23:55 ` Laura Abbott
2017-03-09 5:36 ` Kees Cook
2017-03-09 13:04 ` Daniel Borkmann
2017-03-09 13:10 ` Thomas Gleixner
2017-03-09 13:25 ` Daniel Borkmann
2017-03-09 14:49 ` Thomas Gleixner
2017-03-09 17:51 ` Daniel Borkmann
2017-03-09 18:08 ` David Miller
2017-03-09 18:10 ` Linus Torvalds
2017-03-09 18:15 ` Linus Torvalds
2017-03-09 18:31 ` Daniel Borkmann
2017-03-09 21:32 ` Daniel Borkmann
2017-03-09 21:55 ` Borislav Petkov
2017-03-09 22:07 ` Borislav Petkov
2017-03-09 22:11 ` Daniel Borkmann
2017-03-09 22:48 ` Borislav Petkov
2017-03-09 23:26 ` Linus Torvalds
2017-03-09 23:44 ` Borislav Petkov
2017-03-10 0:13 ` Daniel Borkmann
2017-03-12 21:40 ` Borislav Petkov
2017-03-09 14:53 ` Daniel Borkmann
2017-03-09 17:48 ` Linus Torvalds
2017-03-08 22:43 ` Linus Torvalds
2017-03-09 1:34 ` Fengguang Wu
2017-03-09 13:09 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58B88353.2010508@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@fb.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).