From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755012AbdCGKrl (ORCPT ); Tue, 7 Mar 2017 05:47:41 -0500 Received: from szxga03-in.huawei.com ([45.249.212.189]:3927 "EHLO dggrg03-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1755030AbdCGKrM (ORCPT ); Tue, 7 Mar 2017 05:47:12 -0500 Message-ID: <58BE8F07.8020109@huawei.com> Date: Tue, 7 Mar 2017 18:44:23 +0800 From: Xishi Qiu User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Andrew Morton , Vlastimil Babka , Mel Gorman , Minchan Kim , Michal Hocko , Joonsoo Kim CC: Yisheng Xie , Linux MM , LKML Subject: [RFC][PATCH 2/2] mm: unreserve highatomic pageblock if direct reclaim failed References: <58BE8C91.20600@huawei.com> In-Reply-To: <58BE8C91.20600@huawei.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.25.179] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020205.58BE8F12.00BD,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: aefedd9fdf0fc993578992f46f1182b6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If direct reclaim failed, unreserve highatomic pageblock immediately is better than unreserve in should_reclaim_retry(). We may get page in next try rather than reclaim-compact-reclaim-compact... Signed-off-by: Xishi Qiu --- mm/page_alloc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 2331840..2bd19d0 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -3421,7 +3421,8 @@ void warn_alloc(gfp_t gfp_mask, nodemask_t *nodemask, const char *fmt, ...) bool drained = false; *did_some_progress = __perform_reclaim(gfp_mask, order, ac); - if (unlikely(!(*did_some_progress))) + if (unlikely(!(*did_some_progress) + && !unreserve_highatomic_pageblock(ac, false))) return NULL; retry: -- 1.8.3.1