* [PATCH] ASoC: cs35l35: trivial fix to indentation
@ 2017-03-11 19:19 Colin King
2017-03-12 14:55 ` walter harms
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2017-03-11 19:19 UTC (permalink / raw)
To: Brian Austin, Paul Handrigan, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Jiri Kosina, alsa-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Remove extraneous tab to correct the nesting level indentation
Detected by CoverityScan, CID#1416584 ("Nesting level does
not match indentation")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
sound/soc/codecs/cs35l35.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c
index 260ed42..43d33f4 100644
--- a/sound/soc/codecs/cs35l35.c
+++ b/sound/soc/codecs/cs35l35.c
@@ -1370,7 +1370,8 @@ static int cs35l35_i2c_probe(struct i2c_client *i2c_client,
for (i = 0; i < ARRAY_SIZE(cs35l35_supplies); i++)
cs35l35->supplies[i].supply = cs35l35_supplies[i];
- cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
+
+ cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
ret = devm_regulator_bulk_get(&i2c_client->dev,
cs35l35->num_supplies,
--
2.10.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: cs35l35: trivial fix to indentation
2017-03-11 19:19 [PATCH] ASoC: cs35l35: trivial fix to indentation Colin King
@ 2017-03-12 14:55 ` walter harms
0 siblings, 0 replies; 2+ messages in thread
From: walter harms @ 2017-03-12 14:55 UTC (permalink / raw)
To: Colin King
Cc: Brian Austin, Paul Handrigan, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Jiri Kosina, alsa-devel,
kernel-janitors, linux-kernel
Am 11.03.2017 20:19, schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> Remove extraneous tab to correct the nesting level indentation
>
> Detected by CoverityScan, CID#1416584 ("Nesting level does
> not match indentation")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/soc/codecs/cs35l35.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c
> index 260ed42..43d33f4 100644
> --- a/sound/soc/codecs/cs35l35.c
> +++ b/sound/soc/codecs/cs35l35.c
> @@ -1370,7 +1370,8 @@ static int cs35l35_i2c_probe(struct i2c_client *i2c_client,
>
> for (i = 0; i < ARRAY_SIZE(cs35l35_supplies); i++)
> cs35l35->supplies[i].supply = cs35l35_supplies[i];
> - cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
> +
> + cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
>
I have the feeling is better before the loop:
cs35l35->num_supplies = ARRAY_SIZE(cs35l35_supplies);
for (i = 0; i < cs35l35->num_supplies; i++)
cs35l35->supplies[i].supply = cs35l35_supplies[i];
re,
wh
> ret = devm_regulator_bulk_get(&i2c_client->dev,
> cs35l35->num_supplies,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-12 14:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-11 19:19 [PATCH] ASoC: cs35l35: trivial fix to indentation Colin King
2017-03-12 14:55 ` walter harms
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox