From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750822AbdCMEzT (ORCPT ); Mon, 13 Mar 2017 00:55:19 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:59208 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750772AbdCMEzL (ORCPT ); Mon, 13 Mar 2017 00:55:11 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a35-f79d66d000001a37-4e-58c6262c6635 Content-transfer-encoding: 8BIT Message-id: <58C6262B.2020000@samsung.com> Date: Mon, 13 Mar 2017 13:55:07 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Bartlomiej Zolnierkiewicz , Sangbeom Kim , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 2/7] regulator: max77693: Constify regulator_ops In-reply-to: <20170311190124.11512-2-krzk@kernel.org> X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0hTcRTH+917d3e1VtdZdtAe80KBI9fubdMV2gMlBj0UshiF2EUvarpN djcfBWEvNYmyshhL0B6Uj2C2slySxSoriNbKoKSmUVREZaCJkkS7XiP/+55zPud3fufLoXD1 ITKeKrY5BYeNL2XIaOLm/aSVySuW91n0jR1guub2Kkxn3n8kTcFgp9I01l+HmV7ebiJN7mAv Zgq1jmLrlWa/553S7Gs/SpqP32hH5hHfkmxip5BWJPAFgkMj2PLtBcW2wnRm07a8jDxjip5N ZlebUhmNjbcK6Uzm5uzkjcWlkR8wmnK+1BVJZfOiyKxcm+awu5yCpsguOtOZXSzL6Vh9qo7j OJ1hVe4azhhBdgtFTZ+OE2V+qvLqkw5lNTqqrEdRFNAGcIee4LKOg+dhL1mPoik13Y3gTr1P IQe1GHT+PkH86/jmmyDkwhUEF0ZGFVJBRcfA+OlwpEBROL0UHrwokdI4nQRdPV6lzIcReF56 p3ktvKnvwiWeoJdByJ0lpclI+u6X16Sk59GJ8Gr8A5L0AtoC/uaxqXfm06cwOOjrmYJi6Uzo G7+ISTqKNsLAxCQuQUBfVsKzb9+RNADoxeC7N71mJhz2fsZkHQtfH92YtiIB2v8MYHJvLYLr TWFCDuoQDLYdUMjUKhgcCuPyanPhx69jCnmACupq1DJiBve1EVLWG6D662ckb38dwWhDL9GA lnpmGOb5b5hnhmEtCG9HcUKZaC0URLaM1Ym8VXTZCnX5dqsPTR2g1tiNGp9tDiCaQswcVafn oUWt4MvFKmsAAYUz81XLF/dZ1KoCvmqv4LDnOVylghhAxojfJ/H4Bfn2yDnbnHmsIYU1cAaW TeX0HLNQpdCftKjpQt4plAhCmeD414dRUfHVKLP1WM25DVlphoryA0mdaFZuxb4B7ZZYv3Nt nHbrpf1DF0pqlyX43w608D9XhCZnERmu19HDwR1PXeKi8ebE4Yzz5wNjk9stXE5MbkGLcw9T UhVz9nFX8HdPc86R78PVs5c4furabqkfnnLXNAZeza48rQl5+9d1QUOGqN9+rr+OIcQintXi DpH/C6tfjVGWAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHIsWRmVeSWpSXmKPExsVy+t9jAV0dtWMRBl2rWC02zljPajH14RM2 i/PnN7BbfLvSwWRxedccNosZ5/cxWVxc8YXJgd1j56y77B6bVnWyefRtWcXo8XmTXABLlJtN RmpiSmqRQmpecn5KZl66rVJoiJuuhZJCXmJuqq1ShK5vSJCSQlliTimQZ2SABhycA9yDlfTt Etwy5jzrYynYyVGx5uRq9gbGTvYuRk4OCQETiTebfrJA2GISF+6tZ+ti5OIQEljKKPGu4ysz SIJXQFDix+R7QEUcHMwC8hJHLmWDhJkF1CUmzVvEDFH/gFGiueUvVL2WxM2urcwg9SwCqhIX Z/iDhNmAwvtf3GADsfkFFCWu/njMCFIiKhAh0X2iEmSMiMAkJol/By6AjREWcJE49mMxE8T8 zYwSmy8sADuaU8BU4tbPP8wTGAVmITlvFsJ5s5Cct4CReRWjRGpBckFxUnquYV5quV5xYm5x aV66XnJ+7iZGcFw9k9rBeHCX+yFGAQ5GJR7eDbOORgixJpYVV+YeYpTgYFYS4VWTPRYhxJuS WFmVWpQfX1Sak1p8iNEU6L+JzFKiyfnAmM8riTc0MTcxNzawMLe0NDFSEudtnP0sXEggPbEk NTs1tSC1CKaPiYNTqoEx7/TO1LlKxRFiEzYrL8/R1tY6/jzpDv8xuS8n7DymxLrHLI+5oc+t xyPV8fvbLtVN302qn3Wl+lwvvrLx9plt544EzZTRPSPmq1N25+YtJQfR+j6VutdmZsk9G/wD FHWKN3w2P5OYzL8jL253+afGqayNu2KW8doIVB+Uu5twfMmiUzNexS5UYinOSDTUYi4qTgQA GyYAT8ECAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170313045508epcas1p37ac5e6be01582cd08ec90fd175d5625b X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170311190145epcas1p3659851873074ec6c2a388363faa02ddf X-RootMTR: 20170311190145epcas1p3659851873074ec6c2a388363faa02ddf References: <20170311190124.11512-1-krzk@kernel.org> <20170311190124.11512-2-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2017년 03월 12일 04:01, Krzysztof Kozlowski wrote: > Static struct regulator_ops is not modified so can be made const for > code safeness. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/regulator/max77693-regulator.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/regulator/max77693-regulator.c b/drivers/regulator/max77693-regulator.c > index 3fce67982682..e7000e777292 100644 > --- a/drivers/regulator/max77693-regulator.c > +++ b/drivers/regulator/max77693-regulator.c > @@ -150,7 +150,7 @@ static const struct regulator_ops max77693_safeout_ops = { > .set_voltage_sel = regulator_set_voltage_sel_regmap, > }; > > -static struct regulator_ops max77693_charger_ops = { > +static const struct regulator_ops max77693_charger_ops = { > .is_enabled = regulator_is_enabled_regmap, > .enable = regulator_enable_regmap, > .disable = regulator_disable_regmap, > Reviewed-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics