From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750824AbdCMFLT (ORCPT ); Mon, 13 Mar 2017 01:11:19 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:42307 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbdCMFLL (ORCPT ); Mon, 13 Mar 2017 01:11:11 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a39-f799f6d000001a36-54-58c627572180 Content-transfer-encoding: 8BIT Message-id: <58C62756.2000800@samsung.com> Date: Mon, 13 Mar 2017 14:00:06 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Bartlomiej Zolnierkiewicz , Sangbeom Kim , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 1/7] regulator: max1586: Constify regulator_ops In-reply-to: <20170311190124.11512-1-krzk@kernel.org> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgk+LIzCtJLcpLzFFi42LZdlhTXzdc/ViEwd8ZShYbZ6xntZj68Amb xfnzG9gtvl3pYLK4vGsOm8WM8/uYLC6u+MLkwO6xc9Zddo9NqzrZPPq2rGL0+LxJLoAlKtUm IzUxJbVIITUvOT8lMy/dVsk7ON453tTMwFDX0NLCXEkhLzE31VbJxSdA1y0zB+gCJYWyxJxS oFBAYnGxkr6dTVF+aUmqQkZ+cYmtUrShoZGeoYG5npGRkZ6JcayVkSlQSUJqxpvjC5gLVnFX vNz6kLGBcSNnFyMnh4SAicSitaeZIWwxiQv31rN1MXJxCAnsYJQ4cHwFM4TTziTx594hdpiO U2vfQiWWM0pc/bAHrJ1XQFDix+R7LF2MHBzMAvISRy5lg4SZBTQltu5ezw5Rfw9o6rZJjF2M 7ED1WhLtKSAlLAKqEnOvnWADsdmAovtf3ACz+QUUJa7+eMwIYosKREjsnP8NbIyIwCQmiaZN u8GKhAWcJWb9+swEMpJTwFTimA5IiYTAKnaJzX/fgV0jISArsekA1I8uEk+nn4WyhSVeHd8C 9ZW0xKp/t5ggetsZJTbPAfkExOlglLi/spEVospY4v6De8wQf/FJvPvawwqxgFeio00IosRD YvnjEywQtqPEmb4t0AAFmjN5y2bmCYzys5BCaxYitGYhhdYCRuZVjGKpBcW56anFhgWmesWJ ucWleel6yfm5mxjBqU/LcgfjsXM+hxgFOBiVeHg3zDoaIcSaWFZcmXuIUYKDWUmEV032WIQQ b0piZVVqUX58UWlOavEhRlNgcE9klhJNzgem5bySeEMTM0MTIxNDQ3MjAyMlcV5Wg4kRQgLp iSWp2ampBalFMH1MHJxSDYyKPAwH7RKX6y/jy7e8k8yh8ebYnWt9kxy6fHfsv1m2uEPtphGj yOx2mRveU7V47+6TkZr69nbX13O/lX0511gVZ51dJ55mc5hRvYUjXIivTuBZwt3/OxufnFZS VVnv910spf9MO5e3A0/O8ouKDd1uPC/ftLAI7r/rKplupW54aWJHT/+uX0osxRmJhlrMRcWJ AFrZRa6TAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFIsWRmVeSWpSXmKPExsVy+t9jAd0w9WMRBvOnm1lsnLGe1WLqwyds FufPb2C3+Halg8ni8q45bBYzzu9jsri44guTA7vHzll32T02repk8+jbsorR4/MmuQCWKDeb jNTElNQihdS85PyUzLx0W6XQEDddCyWFvMTcVFulCF3fkCAlhbLEnFIgz8gADTg4B7gHK+nb JbhlvDm+gLlgFXfFy60PGRsYN3J2MXJySAiYSJxa+5YZwhaTuHBvPVsXIxeHkMBSRomV196x giR4BQQlfky+x9LFyMHBLCAvceRSNkiYWUBdYtK8RcwQ9Q8YJdYtugRUww5UryXRngJSwiKg KjH32gk2EJsNKLr/xQ0wm19AUeLqj8eMIBNFBSIkuk9UgkwREZjEJPHvwAWwc4QFnCVm/frM BGILCXQxSsxfUgIynVPAVOKYzgRGgVlITpuFcNosJKctYGRexSiRWpBcUJyUnmuYl1quV5yY W1yal66XnJ+7iREcT8+kdjAe3OV+iFGAg1GJh3fDrKMRQqyJZcWVuYcYJTiYlUR41WSPRQjx piRWVqUW5ccXleakFh9iNAX6biKzlGhyPjDW80riDU3MTcyNDSzMLS1NjJTEeRtnPwsXEkhP LEnNTk0tSC2C6WPi4JRqYMy4ftaVm4FNnG+xwuXvqsmqXNJ1Z4y3Gqc8dLfT2zA/p+nJuWW5 8wPbz9YtnPrj4wI1xZmSde+lTY/6LUv5G5G25sgcoy+LHFuOrNGXe716dkrZjtfd91Rz/FPu 1HleuzBLIimq4bripETFjS6M5xa/aj/ukGmxy7rDZsn8Rxl+ew/nfciT0FdiKc5INNRiLipO BAC5JtM9vQIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170313050006epcas1p31a65e559cf902ff22f8d77b4ccdc11eb X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170311190141epcas2p2721283aa79819ca89f11815414ae5b4a X-RootMTR: 20170311190141epcas2p2721283aa79819ca89f11815414ae5b4a References: <20170311190124.11512-1-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear all, All patches in this series looks good to me. Reviewed-by: Chanwoo Choi Best Regards, Chanwoo Choi On 2017년 03월 12일 04:01, Krzysztof Kozlowski wrote: > Static struct regulator_ops is not modified so can be made const for > code safeness. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/regulator/max1586.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/regulator/max1586.c b/drivers/regulator/max1586.c > index 2c1228d5796a..6779c2b53674 100644 > --- a/drivers/regulator/max1586.c > +++ b/drivers/regulator/max1586.c > @@ -126,14 +126,14 @@ static int max1586_v6_set_voltage_sel(struct regulator_dev *rdev, > * The Maxim 1586 controls V3 and V6 voltages, but offers no way of reading back > * the set up value. > */ > -static struct regulator_ops max1586_v3_ops = { > +static const struct regulator_ops max1586_v3_ops = { > .get_voltage_sel = max1586_v3_get_voltage_sel, > .set_voltage_sel = max1586_v3_set_voltage_sel, > .list_voltage = regulator_list_voltage_linear, > .map_voltage = regulator_map_voltage_linear, > }; > > -static struct regulator_ops max1586_v6_ops = { > +static const struct regulator_ops max1586_v6_ops = { > .get_voltage_sel = max1586_v6_get_voltage_sel, > .set_voltage_sel = max1586_v6_set_voltage_sel, > .list_voltage = regulator_list_voltage_table, >