From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758615AbdCVBPA (ORCPT ); Tue, 21 Mar 2017 21:15:00 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:44126 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758597AbdCVBO7 (ORCPT ); Tue, 21 Mar 2017 21:14:59 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a2c-f79b56d0000012f0-9d-58d1d00ff08c Content-transfer-encoding: 8BIT Message-id: <58D1D00F.40300@samsung.com> Date: Wed, 22 Mar 2017 10:14:55 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Andy Shevchenko , linux-kernel@vger.kernel.org, MyungJoo Ham Cc: Lu Baolu Subject: Re: [PATCH v1] Revert "extcon: usb-gpio: add support for ACPI gpio interface" In-reply-to: <20170321183747.32450-1-andriy.shevchenko@linux.intel.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJKsWRmVeSWpSXmKPExsWy7bCmlq7AhYsRBufncVn0Nk1nstg8cSub xeVdc9gsbjeuYHNg8Zh3MtCjb8sqRo/Pm+QCmKNSbTJSE1NSixRS85LzUzLz0m2VvIPjneNN zQwMdQ0tLcyVFPISc1NtlVx8AnTdMnOAlikplCXmlAKFAhKLi5X07WyK8ktLUhUy8otLbJWi DQ2N9AwNzPWMjIz0TIxjrYxMgUoSUjMW3jAsWMdXcWLdAfYGxpfcXYycHBICJhKfdi5ihrDF JC7cW8/WxcjFISSwlFHi3dTfrBBOO5PEpfWPmWE6zt/Zzw6RmMMocfHOXEaQBK+AoMSPyfdY uhg5OJgF5CWOXMoGCTMLaEps3b0eqv4eo8SivrdQ9RoS5/8uZAKxWQRUJfa2TQdbwCagJbH/ xQ02EJtfQFHi6o/HYPWiAhESO+d/AxskItDAKHHnwXEWiA3qEs3dEEXCQEUHNp8DG8op4C6x +dwvJpAGCYF+don1O/uYQK6TEJCV2HQA6hsXiZXz5rNC2MISr45vYYewpSX+Lr3FCNHbziix eQ7IZyBOB6PE/ZWNUB3GEvcf3GOGuIJPovf3E6gFvBIdbUIQJR4SF67/ZoKwHSXevbgLdqiQ wCxGiU1/WSYwKsxCCrxZiMCbhRR4CxiZVzGKpRYU56anFpsWGOoVJ+YWl+al6yXn525iBCc7 LZ0djPcWeB9iFOBgVOLhXTHtYoQQa2JZcWXuIUYJDmYlEd67Z4BCvCmJlVWpRfnxRaU5qcWH GE2BYT+RWUo0OR+YiPNK4g1NzAxNjCyB0NzQXEmcN8pgYoSQQHpiSWp2ampBahFMHxMHp1QD Y/XFhhbWvWlFAhELs8yKFBlua7bo8QtL3Wl6lPT10td668o3VYYTgnT9ZGKOzLhr1hNhNHvL r/D26+Ibu5Y5T7DnlHOyOZ6bXL2G58bPS3HKX0U5L9r1p0ZOr9vSaPvCtbjQXP894/Lfp1X6 ZV01dd+UBrqoNf3mdFx+guPp/VeeM1Yey3RUYinOSDTUYi4qTgQAJhnIl4wDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCIsWRmVeSWpSXmKPExsVy+t9jQV3+CxcjDPrOG1v0Nk1nstg8cSub xeVdc9gsbjeuYHNg8Zh3MtCjb8sqRo/Pm+QCmKPcbDJSE1NSixRS85LzUzLz0m2VQkPcdC2U FPISc1NtlSJ0fUOClBTKEnNKgTwjAzTg4BzgHqykb5fglrHwhmHBOr6KE+sOsDcwvuTuYuTk kBAwkTh/Zz87hC0mceHeerYuRi4OIYFZjBL7Dq9nBUnwCghK/Jh8j6WLkYODWUBe4silbJAw s4C6xKR5i5gh6h8wSmx/+ZUNol5D4vzfhUwgNouAqsTetunMIDabgJbE/hc3wGr4BRQlrv54 zAgyU1QgQqL7RCXIHBGBBkaJ2cv+M8IsaO5+DGYLA9Uc2HwObKaQwBxGiStbYkFsTgF3ic3n fjFNYBScheTUWQinzkJy6gJG5lWMEqkFyQXFSem5Rnmp5XrFibnFpXnpesn5uZsYwTH0THoH 4+Fd7ocYBTgYlXh4T8hcjBBiTSwrrsw9xCjBwawkwnv3DFCINyWxsiq1KD++qDQntfgQoynQ rxOZpUST84HxnVcSb2hibmJubGBhbmlpYqQkzts4+1m4kEB6YklqdmpqQWoRTB8TB6dUA2P4 7JL1PuXOJ2z2a7GUTzfdtJPxQ4q2tP5dYwZdv66Ja4XWB86XebSZQS5xt/RDo4t3k2bkbZ/m yLTp4vcji6Ufye+ZnbrCaMGFNP09pxPqUrc0eVyWf+BfFJV5uPrvlZNOLf8sBT7GsO6Z8PVT 2L5Xp7dXxXEdslifeYhjcWDaGmurCaweSXuUWIozEg21mIuKEwFz/ZsRtwIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170322011455epcas5p242bb1ef939433ae3be829eb82b9ee0c8 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170321183839epcas2p1de828034e7360ea8ea365861b9335626 X-RootMTR: 20170321183839epcas2p1de828034e7360ea8ea365861b9335626 References: <20170321183747.32450-1-andriy.shevchenko@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2017년 03월 22일 03:37, Andy Shevchenko wrote: > The commit 942c7924a51e introduced a check for ACPI handle for the > device that never appears on any ACPI-enabled platform so far. It seems > a confusion with extcon-intel-int3496 which does support ACPI-enabled > platforms. Only for the reason that there is no any usecase until now, and remove the confusion between extcon-usb-gpio and extcon-intel-int3496. Should we revert it? I think that both extcon-usb-gpio and extcon-intel-int3496 driver are not same operation perfectly. Also, the filename of extcon-intel-int3496 has specific name. Instead, extcon-usb-gpio.c is more common device driver. Can the extcon-intel-int3496.c support the everything on acpi side? > > Revert commit 942c7924a51e to avoid any confusion in the future. > > Cc: Lu Baolu > Signed-off-by: Andy Shevchenko > --- > drivers/extcon/extcon-usb-gpio.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c > index d47573a31e17..9c925b05b7aa 100644 > --- a/drivers/extcon/extcon-usb-gpio.c > +++ b/drivers/extcon/extcon-usb-gpio.c > @@ -26,7 +26,6 @@ > #include > #include > #include > -#include > #include > > #define USB_GPIO_DEBOUNCE_MS 20 /* ms */ > @@ -111,7 +110,7 @@ static int usb_extcon_probe(struct platform_device *pdev) > struct usb_extcon_info *info; > int ret; > > - if (!np && !ACPI_HANDLE(dev)) > + if (!np) > return -EINVAL; > > info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL); > -- Best Regards, Chanwoo Choi Samsung Electronics