From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932095AbdC1I0l (ORCPT ); Tue, 28 Mar 2017 04:26:41 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:33367 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754679AbdC1I0g (ORCPT ); Tue, 28 Mar 2017 04:26:36 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a2d-f792a6d0000055a1-44-58da1e39a636 Content-transfer-encoding: 8BIT Message-id: <58DA1E38.50907@samsung.com> Date: Tue, 28 Mar 2017 17:26:32 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Hoegeun Kwon , jy0922.shim@samsung.com, sw0312.kim@samsung.com, airlied@linux.ie, kgene@kernel.org, krzk@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com Cc: javier@osg.samsung.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, a.hajda@samsung.com, andi.shyti@samsung.com, LW@KARO-electronics.de Subject: Re: [PATCH v5 3/5] drm/exynos: dsi: Fix the parse_dt function In-reply-to: <93e79e92-a102-e931-8d63-843031848888@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOJsWRmVeSWpSXmKPExsWy7bCmhq6l3K0Ig843XBa31p1jteg9d5LJ YvuRZ6wW75f1MFrMPwIUu/L1PZvF++VdbBZv3q5hsnhx7yKLRf/j18wW589vYLfY9Pgaq8Xl XXPYLGac38dkceDJcjaLpdcvMlm07j3CbjFj8ks2i5cfT7A4CHusmbeG0WP+9EfMHptWdbJ5 bP/2gNXjfvdxJo/NS+o9tvTfZffo27KK0ePzJrkAzqhUm4zUxJTUIoXUvOT8lMy8dFsl7+B4 53hTMwNDXUNLC3MlhbzE3FRbJRefAF23zBygr5QUyhJzSoFCAYnFxUr6djZF+aUlqQoZ+cUl tkrRhoZGeoYG5npGRkZ6JsaxVkamQCUJqRnLXtcXzBCv2HGnj7WB8YhgFyMHh4SAicSEFbZd jJxAppjEhXvr2boYuTiEBJYySnz7vYIdwmlnktjwfgUzRJWJxJP+xVCJ5YwSs19tYAFJ8AoI SvyYfI8FZCqzgLzEkUvZIGFmAU2JrbvXQ9XfY5RYeeAbE0S9hsSbf6vBhrIIqEqsmtPMBmKz AdkTV9wHs0UFIiR2zv8G1iwi8J5R4tjh7UwgDrNAJ5NEX9NydpAqYQE3iVWXjzCC2JwC9hJz tjexghRJCMzlkGi6fIMV4lFZiU0HoF5wkTi78Ts7hC0s8er4FihbWuLv0luMEL3tjBJtM89A DWphlPjfc4UFospY4v6De8wQz/FJ9P5+wgSxgFeio00IosRDYv/Vn1BDHSVOHZzHAvF/H5PE qv1zWScwys9CCrJZiCCbhRRkCxiZVzGKpRYU56anFpsWGOkVJ+YWl+al6yXn525iBCdqLd0d jF8WeB9iFOBgVOLhXVF/M0KINbGsuDL3EKMEB7OSCK8k960IId6UxMqq1KL8+KLSnNTiQ4ym wBCfyCwlmpwPzCJ5JfGGJpYGJqZmxgbGhhaWSuK86iuvRQgJpCeWpGanphakFsH0MXFwSjUw rj0xSShhE/MVXqfukOQ82wml9xhLJksuVJj+Zt0p214Xr+Cv9xfoz7NQqVx2QC9/avbB4EsO 1bYlQqcObv8lJsfVNM8xc0v8mj53XcbEPt76sNrQBy/lGtztJZ0+fNwW8SVPo1ywb8+kTwL/ N6/Ls2MNeee+b+YPvphVAj4PLkadeML1XOOgEktxRqKhFnNRcSIAGDi9U+oDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42I5/e+xgK6F3K0Ig47dFha31p1jteg9d5LJ YvuRZ6wW75f1MFrMPwIUu/L1PZvF++VdbBZv3q5hsnhx7yKLRf/j18wW589vYLfY9Pgaq8Xl XXPYLGac38dkceDJcjaLpdcvMlm07j3CbjFj8ks2i5cfT7A4CHusmbeG0WP+9EfMHptWdbJ5 bP/2gNXjfvdxJo/NS+o9tvTfZffo27KK0ePzJrkAzig3m4zUxJTUIoXUvOT8lMy8dFul0BA3 XQslhbzE3FRbpQhd35AgJYWyxJxSIM/IAA04OAe4Byvp2yW4ZSx7XV8wQ7xix50+1gbGI4Jd jJwcEgImEk/6F7ND2GISF+6tZwOxhQSWMkrcWZEHYvMKCEr8mHyPpYuRg4NZQF7iyKVskDCz gLrEpHmLmLsYuYDKHzBK/Jh6hRmiXkPizb/VYDaLgKrEqjnNYDPZgOyJK+6zgcwRFYiQ6D5R CRIWEXgP1LtVBGQOs0Ank8Sr09fB6oUF3CRWXT7CCLGgj0ni9bOPYIdyCthLzNnexDqBUWAW kvtmIdw3C8l9CxiZVzFKpBYkFxQnpeca5aWW6xUn5haX5qXrJefnbmIER/8z6R2Mh3e5H2IU 4GBU4uHV4L8ZIcSaWFZcmXuIUYKDWUmEV5L7VoQQb0piZVVqUX58UWlOavEhRlOgBycyS4km 5wMTU15JvKGJuYm5sYGFuaWliZGSOG/j7GfhQgLpiSWp2ampBalFMH1MHJxSDYyL77nt1z0i +ODLhhXqtTHvXnEKdcq6zzyzIJNx3afiy97bezUN99295Ldy9dIGZV7v3Yo39dqmbDtb+5G7 W0T7yjXFE97R/fG/fHQm+Atx56m3b7dgPpxm5uyVmMO47p3ROgeWk1Ivv9z8VKMhkHFG+d8q rWsrP5ro+jmwPt8bE+wseeJmjrYSS3FGoqEWc1FxIgCkU51kFAMAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170328082632epcas5p24bbc57c57bd9ad2af51fad92991e2afd X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?64yA7J246riwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?SW5raSBEYWUbVGl6ZW4gUGxhdGZvcm0gTGFiLhtTYW1zdW5n?= =?UTF-8?B?IEVsZWN0cm9uaWNzG1NlbmlvciBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170308045502epcas1p2d2f7a0f768082b7a54b2ebe260e78436 X-RootMTR: 20170308045502epcas1p2d2f7a0f768082b7a54b2ebe260e78436 References: <1488948852-5380-1-git-send-email-hoegeun.kwon@samsung.com> <1488948852-5380-4-git-send-email-hoegeun.kwon@samsung.com> <93e79e92-a102-e931-8d63-843031848888@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Merged. Thanks, Inki Dae 2017년 03월 22일 10:36에 Hoegeun Kwon 이(가) 쓴 글: > Hi inki, > > Could you check the this patch? > For reference, patch 1/5 and 2/5 have already been applied to Krzysztof tree. > > Best regards, > Hoegeun > > > On 03/08/2017 01:54 PM, Hoegeun Kwon wrote: >> The dsi + panel is a parental relationship, so OF grpah is not needed. >> Therefore, the current dsi_parse_dt function will throw an error, >> because there is no linked OF graph for the case fimd + dsi + panel. >> >> Parse the Pll burst and esc clock frequency properties in dsi_parse_dt() >> and create a bridge_node only if there is an OF graph associated with dsi. >> >> Signed-off-by: Hoegeun Kwon >> Reviewed-by: Andrzej Hajda >> Reviewed-by: Andi Shyti >> --- >> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 32 ++++++++------------------------ >> 1 file changed, 8 insertions(+), 24 deletions(-) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c >> index f5c04d0..2d4e118 100644 >> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c >> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c >> @@ -1652,39 +1652,23 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi) >> if (ret < 0) >> return ret; >> - ep = of_graph_get_endpoint_by_regs(node, DSI_PORT_OUT, 0); >> - if (!ep) { >> - dev_err(dev, "no output port with endpoint specified\n"); >> - return -EINVAL; >> - } >> - >> - ret = exynos_dsi_of_read_u32(ep, "samsung,burst-clock-frequency", >> + ret = exynos_dsi_of_read_u32(node, "samsung,burst-clock-frequency", >> &dsi->burst_clk_rate); >> if (ret < 0) >> - goto end; >> + return ret; >> - ret = exynos_dsi_of_read_u32(ep, "samsung,esc-clock-frequency", >> + ret = exynos_dsi_of_read_u32(node, "samsung,esc-clock-frequency", >> &dsi->esc_clk_rate); >> if (ret < 0) >> - goto end; >> - >> - of_node_put(ep); >> + return ret; >> ep = of_graph_get_next_endpoint(node, NULL); >> - if (!ep) { >> - ret = -EINVAL; >> - goto end; >> - } >> - >> - dsi->bridge_node = of_graph_get_remote_port_parent(ep); >> - if (!dsi->bridge_node) { >> - ret = -EINVAL; >> - goto end; >> + if (ep) { >> + dsi->bridge_node = of_graph_get_remote_port_parent(ep); >> + of_node_put(ep); >> } >> -end: >> - of_node_put(ep); >> - return ret; >> + return 0; >> } >> static int exynos_dsi_bind(struct device *dev, struct device *master, > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > >