From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754256AbdC3JPl (ORCPT <rfc822;w@1wt.eu>);
        Thu, 30 Mar 2017 05:15:41 -0400
Received: from mailout4.samsung.com ([203.254.224.34]:34372 "EHLO
        mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753049AbdC3JPh (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 30 Mar 2017 05:15:37 -0400
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
X-AuditID: b6c32a58-f79586d000001c40-2a-58dcccb65475
Content-transfer-encoding: 8BIT
Message-id: <58DCCCB6.2030206@samsung.com>
Date: Thu, 30 Mar 2017 18:15:34 +0900
From: Chanwoo Choi <cw00.choi@samsung.com>
Organization: Samsung Electronics
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
        Thunderbird/31.6.0
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Hans de Goede <hdegoede@redhat.com>, chanwoo@kernel.org,
        MyungJoo Ham <myungjoo.ham@samsung.com>
Subject: Re: [PATCH 1/2] extcon: Use BIT() macro for the left-shift operation
In-reply-to: <CAHp75VcanOiXazx+VTuKN9GSLXotfVopmjviBfCJxnhuMtsURQ@mail.gmail.com>
X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHe3eOZ0dp9TYrH+ziOlHixLUzt5yhYVk2KlGSYN2wkx6muIvs
        TFHD0g+lrZsapJlRflipCcIUL0EmavmlKErD1GZ0MYskwQijks52un37vf/3/7zP+/x5aEJ5
        igqnc+0u3mnnrAwVQnYOREXFdD6cMGsffYswfqgaQMbq0WHS+GmoVmZ8dqeBMo6XN1FJQaae
        +pdyk7flDGX63DtCmS50tCDTnHdtetBBPiGH57J5p4q3Zzmyc+2WRGZPRmZypmGzlo1h441x
        jMrO2fhEZsfe9JiUXKvYnFEVctYCUUrnBIHZtDXB6Shw8aoch+BKZA6xrE7DauM0Op1Oo489
        skVnEC1H+ZyJrsL8b1RRw3wXWYY+kG4UTAPWQ8fUuSCJV8ITXxvlZyX2IKh7F+1GISJXyODx
        UNvfAu/NZpl00YDgx9Q7wn+hwMtg/pJPNNE0gSNg8GmeXyZwFEx/qSElvw/Bo59nf/vV4B5p
        DTCJN0CN53KgASXq96ZHA79YitfByPwb5OcV2Aw917/K3UhOL8eb4F6h/0kC30JwYaAvYAnF
        aTDR8VDm/0IwzoCrd11+D+CbcqgavIb8OuA14O0jpFF2wJXbC5TEofBxqEMu8Sr46RlDUm0F
        gvYGHykdKhFMNpf/TisWJl/5CGnIJXD++1uZ1EABlaeVEprA+yJFcm+DzslxuRTDKwTV72fI
        KqSq/y+5+n/J1f+X3A1EtKCVfL5gs/CCIV+vETibUGC3aLIcNi8KrKDa3I0W6vb1I0wjZrFi
        tnXCrAziCoViWz8CmmCWK+oGRUmRzRWX8E5HprPAygv9yCAGX02Er8hyiAttd2Wy+nit3rA5
        VhvLGuOZMEVk83OzEls4F5/H8/m880+djA4OL0MnUpZ2de9ioy0X+2DM8/RKaYW6qKR5Z23x
        s8je9t7DccMVqu1t3ceif9yfbddPtcydWu9dPMpu65063lSbvBr3PLBWvRBSDt1QhJw/cDjs
        6/GI6P36saSivYmN5dl5qWZTqjMy7aTas791dnihcaP99ZfGwfFQtvRB5KJqt2dkZjdDCjkc
        qyacAvcLFBvg05gDAAA=
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAIsWRmVeSWpSXmKPExsVy+t9jQd1tZ+5EGJzrFbR4OeEwo8XEG1dY
        LN4cn85kcXnXHDaL240r2BxYPXbOusvusWlVJ5vH+31X2Tz6tqxi9Pi8SS6ANcrNJiM1MSW1
        SCE1Lzk/JTMv3VYpNMRN10JJIS8xN9VWKULXNyRISaEsMacUyDMyQAMOzgHuwUr6dgluGXe2
        lxX8ZKuY82M7SwPjS5YuRk4OCQETiU3LVjJB2GISF+6tZ+ti5OIQEpjFKLFu6RywBK+AoMSP
        yfeAGjg4mAXkJY5cyoYw1SWmTMmFKH/AKNG1YQE7RLmWRNfVNcwgNouAqsSkpdPAdrEBxfe/
        uMEGYvMLKEpc/fGYEWSOqECERPeJyi5Gdg4RAX2J/WUgE5kFljNKfPl3GmyKsICvxNkJi5gg
        Vj0CumxBDytIK6dAsMT2i3ITGAVnIblzFsKdsxDuXMDIvIpRIrUguaA4KT3XKC+1XK84Mbe4
        NC9dLzk/dxMjOLaeSe9gPLzL/RCjAAejEg9vxdrbEUKsiWXFlbmHGCU4mJVEeGccuRMhxJuS
        WFmVWpQfX1Sak1p8iNEU6NGJzFKiyfnAuM8riTc0MTcxNzawMLe0NDFSEudtnP0sXEggPbEk
        NTs1tSC1CKaPiYNTqoFxWW/9sm/cMYLvu3n2LWa2372h/bKzxPO7GnGHNrzk9zm4IH+e3d5S
        o7dJMo28/k+WFq2NdkzvZzqidqR4/6TfDfvfrxURvL0u6uY+DYGH7Dbxu+uXsGnKznKU77i6
        sW71raPTT0oXPhaI+ZTidP3h7OBXfxfflLt75/688OfeHw5/LGjXOil4V4mlOCPRUIu5qDgR
        AMeHUybDAgAA
X-MTR: 20000000000000000@CPGS
X-CMS-MailID: 20170330091534epcas5p475d738973b1ac444c8c50ba3c177d4ba
X-Msg-Generator: CA
X-Sender-IP: 203.254.230.27
X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?=
        =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?=
X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?=
        =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?=
X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?=
CMS-TYPE: 105P
DLP-Filter: Pass
X-CFilter-Loop: Reflected
X-HopCount: 7
X-CMS-RootMailID: 20170330083943epcas1p4ccc3a12576a7232162a682b73eaeea0b
X-RootMTR: 20170330083943epcas1p4ccc3a12576a7232162a682b73eaeea0b
References: <CGME20170330083943epcas1p4ccc3a12576a7232162a682b73eaeea0b@epcas1p4.samsung.com>
 <1490863178-12782-1-git-send-email-cw00.choi@samsung.com>
 <CAHp75VcanOiXazx+VTuKN9GSLXotfVopmjviBfCJxnhuMtsURQ@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2017년 03월 30일 17:59, Andy Shevchenko wrote:
> On Thu, Mar 30, 2017 at 11:39 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>> This patch just uses the BIT() macro to make the code simple.
> 
>>         for (i = 0; i < edev->max_supported; i++) {
>>                 count += sprintf(buf + count, "%s=%d\n",
>>                                 extcon_info[edev->supported_cable[i]].name,
>> -                                !!(edev->state & (1 << i)));
>> +                                !!(edev->state & BIT(i)));
>>         }
> 
> While change is okay, the above code is fragile. There is a potential
> buffer overflow.

When extcon device is registered, extcon_dev_register() check a number of
supported external connectors. The maximum number of supported connectors
is 32. There is no buffer overflow.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics