From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754404AbdC3JYY (ORCPT ); Thu, 30 Mar 2017 05:24:24 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:32991 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753060AbdC3JYW (ORCPT ); Thu, 30 Mar 2017 05:24:22 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: b6c32a35-f79806d000002bf4-a5-58dccebfee38 Content-transfer-encoding: 8BIT Message-id: <58DCCEBE.8040401@samsung.com> Date: Thu, 30 Mar 2017 18:24:14 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Andy Shevchenko Cc: "linux-kernel@vger.kernel.org" , Hans de Goede , chanwoo@kernel.org, MyungJoo Ham Subject: Re: [PATCH 2/2] extcon: Add new extcon_register_notifier_all() to monitor all external connectors In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA01Sa2xLYRj29bSnZ8sOn9p4M7c6sYRJ251qpxMVwqTBjyUSaYjMsX620Vt6 uoYlYoihkTHEZSlDIrYGlRK3yLpbsk2kFmwu20oIZhb3McSl7Znw7/ne93me93ufvAylqqQz mVKnl3icgp2jU+VXWmZqNJForzUntAObXu9vQabqh/flpsG2IzLTvRsB2tSzrY5eoLBcr+lT WsLBPbTlXUMXbam6HESWT+EpBYpVZF4JEWzEoybOIpet1Fls5patKFxUaMzN4TV8nmkOp3YK DmLmFi8v0CwptceHc2qfYC+LlwoEUeR08+d5XGVeoi5xiV4zt5rn9Vo+Z45Wr9drDbPXzNUb 45S1pORY21ulu5PddOrFJ2UFiqT6UQoD2AAdtSEk4fHQGQvRfpTKqPA1BM+ivUh67JLBt2BE 8Vdxc2f1SCOAoP5UY7LB4rEwfDAm9yOGofBUaL27MVGm8Ezo/3xALvFjCIba65IcFmfDx4bc BEeOs6C/L5S0oePlSP9DOoHH4GnQNfw8+bsMbIXrtV+UfqRk0rEOIr6EI4XPIqhqaUxSxmE7 nGv4mpSm4BXw3l+fHAs4qIR97bWyxFjAkyHcSElwMdTdmSVtNQ4G2i4rJTwRgr8eyyTpLgSX ArERn90IntRvG8lhNjx5GqOkHUfD26G9CsmUhd2VKgla4EDHWom9EF5FP49kG5BBtCok34/U Nf8FV/MvuJr/gjuJqCAaT9yio5iIvJvXioJDLHMWa4tcjjBK3mC28Ro6FF3ejDCDuDR20/ke q0oh+MTNjmYEDMWls0dbe60q1iZsLiceV6GnzE7EZmSMB19NZWYUueIX7fQW8oa8HEOuPn5z eTzPTWAzQt1WFS4WvGQjIW7i+auTMSmZFajgtOLc0qvaoR8a8/Qtp8mLJbcrfH3l93SHI78H 3qed2Lr9m++DMTzjuGE9HtUdycpvmpx/bNKWkzupVWcGhvv2/Qy9CTSVV3K2DRd1attgg7+9 /Ht+VkY9Zm+t048ZvPD4UcfolhsLR6WRoy9Xfo+mF7kemDXqzix3tCeXXamz1XJysUTgsymP KPwBl+yadZkDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsVy+t9jQd195+5EGKxaYWbxcsJhRouJN66w WLw5Pp3J4vKuOWwWtxtXsDmweuycdZfdY9OqTjaP9/uusnn0bVnF6PF5k1wAa5SbTUZqYkpq kUJqXnJ+SmZeuq1SaIibroWSQl5ibqqtUoSub0iQkkJZYk4pkGdkgAYcnAPcg5X07RLcMmYe f8decIG3YuHTz+wNjPu5uhg5OSQETCT2tE5khLDFJC7cW8/WxcjFISQwi1Hi4txONpAEr4Cg xI/J91i6GDk4mAXkJY5cyoYw1SWmTMmFKH/AKPHq2Q9mkDivgJbEp31mIJ0sAqoSL+6uZwWx 2YDC+1/cAJvIL6AocfXHY0aQclGBCInuE5VdjOwcIgL6EvvLQAYyCyxnlPjy7zQzSLWwQI7E mn3foQ6bxyQx91s/2BhOgWCJ5lcbWCYwCs5CcucshDtnIdy5gJF5FaNEakFyQXFSeq5hXmq5 XnFibnFpXrpecn7uJkZwdD2T2sF4cJf7IUYBDkYlHt6KtbcjhFgTy4orcw8xSnAwK4nwzjhy J0KINyWxsiq1KD++qDQntfgQoynQpxOZpUST84GRn1cSb2hibmJubGBhbmlpYqQkzts4+1m4 kEB6YklqdmpqQWoRTB8TB6dUA+OBSq2Fqi6r9t7Lej/zE9fqwy8WnJo2d/aT5e25yYXtMfNL PM7rPt938f2lSK+I2jAhq2lGbP4ZZvd+9oW+m/SWZe+s9G739Zt3StrGfjJZI/1DLdpWzL9L t9ssmostZvZUo7X2fQGGyZF1zbN4a9MbvtyO99+ReaH3ZOlzhhy5jjq7P61re5VYijMSDbWY i4oTAVp8A47EAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170330092414epcas1p493c16ecfca14948ccbd791672d79ec19 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170330083943epcas1p4c5559cab13ef732b6bf149f810aa2f46 X-RootMTR: 20170330083943epcas1p4c5559cab13ef732b6bf149f810aa2f46 References: <1490863178-12782-1-git-send-email-cw00.choi@samsung.com> <1490863178-12782-2-git-send-email-cw00.choi@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017년 03월 30일 18:05, Andy Shevchenko wrote: > On Thu, Mar 30, 2017 at 11:39 AM, Chanwoo Choi wrote: >> The extcon core already provides the extcon_register_notifier() function >> in order to register the notifier block which is used to monitor >> the status change for the specific external connector such as EXTCON_USB, >> EXTCON_USB_HOST and so on. The extcon consumer uses the this function. >> >> The extcon consumer may need to monitor the all supported external >> connectors from the extcon device. In this case, The extcon consumer >> should have each notifier_block structure for each external connector. >> >> This patch adds the new extcon_register_notifier_all() function >> that extcon consumer is able to monitor the status change of all >> supported external connectors by using only one notifier_block structure. >> > >> +/** >> + * extcon_register_notifier_all() - Register a notifier block to get the noti >> + * of the status change for all supported external >> + * connectors from extcon. >> + * @edev: the extcon device that has the external connecotr. >> + * @nb: a notifier block to be registered. >> + * >> + * Note that the second parameter given to the callback of nb (val) is >> + * the current state and third parameter is the edev pointer. >> + */ > > Have you checked how it looks like in resulting document file (man / > html / ...) ? > My concern is multi-line short function description. > Actually, I didn't consider the document file as you mentioned. Do you think need to add more detailed description? -- Best Regards, Chanwoo Choi Samsung Electronics