Re: [RFC][CFT][PATCHSET v1] uaccess unification

Linus Torvalds
2017-03-29T23:43:12Z

On Wed, Mar 29, 2017 at 4:09 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> IMO that's a separate series. For now I would be bloody happy if we got
> * arch-dependent asm fixes out of the way
> * everything consolidated outside of arch/*
> * arch/*/include/uaccess*.h simplified.

Sure, I agree.

At the same time, I just think that we really *should* aim for a
simpler uaccess.h in the long term, so I would prefer we not encourage
architectures to do things that simply won't matter.

> As for __copy_in_user()... I'm not sure we want to keep it in the long run -

I agree, it's probably not worth it at all.

In fact, I suspect none of the "__copy_.*_user()" versions are worth
it, and we should strive to remove them.

There aren't even that many users, and they _have_ caused security
issues when people have had some path that hasn't checked the range.

Linus