public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
	Alex Williamson <alex.williamson@redhat.com>
Cc: <linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>,
	<qemu-devel@nongnu.org>, <izumi.taku@jp.fujitsu.com>
Subject: Re: [PATCH v6] vfio error recovery: kernel support
Date: Thu, 6 Apr 2017 16:53:44 +0800	[thread overview]
Message-ID: <58E60218.4040500@cn.fujitsu.com> (raw)
In-Reply-To: <20170406013534-mutt-send-email-mst@kernel.org>



On 04/06/2017 06:36 AM, Michael S. Tsirkin wrote:
> On Wed, Apr 05, 2017 at 04:19:10PM -0600, Alex Williamson wrote:
>> On Thu, 6 Apr 2017 00:50:22 +0300
>> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>>
>>> On Wed, Apr 05, 2017 at 01:38:22PM -0600, Alex Williamson wrote:
>>>> The previous intention of trying to handle all sorts of AER faults
>>>> clearly had more value, though even there the implementation and
>>>> configuration requirements restricted the practicality.  For instance
>>>> is AER support actually useful to a customer if it requires all ports
>>>> of a multifunction device assigned to the VM?  This seems more like a
>>>> feature targeting whole system partitioning rather than general VM
>>>> device assignment use cases.  Maybe that's ok, but it should be a clear
>>>> design decision.  
>>>
>>> Alex, what kind of testing do you expect to be necessary?
>>> Would you say testing on real hardware and making it trigger
>>> AER errors is a requirement?
>>
>> Testing various fatal, non-fatal, and corrected errors with aer-inject,
>> especially in multfunction configurations (where more than one port
>> is actually usable) would certainly be required.  If we have cases where
>> the driver for a companion function can escalate a non-fatal error to a
>> bus reset, that should be tested, even if it requires temporary hacks to
>> the host driver for the companion function to trigger that case.  AER
>> handling is not something that the typical user is going to experience,
>> so it should to be thoroughly tested to make sure it works when needed
>> or there's little point to doing it at all.  Thanks,
>>
>> Alex
> 
> Some things can be tested within a VM. What would you
> say would be sufficient on a VM and what has to be
> tested on bare metal?
> 

Does the "bare metal" here mean something like XenServer?
-- 
Sincerely,
Cao jin

  parent reply	other threads:[~2017-04-06  9:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-23  9:07 [PATCH v6] vfio error recovery: kernel support Cao jin
2017-03-24 22:12 ` Alex Williamson
2017-03-28 13:47   ` Cao jin
2017-03-28 16:12     ` Alex Williamson
2017-03-29  0:01       ` Michael S. Tsirkin
2017-03-29  2:55         ` Alex Williamson
2017-03-30 18:00           ` Michael S. Tsirkin
2017-03-30 18:16             ` Alex Williamson
2017-04-05  8:54               ` Cao jin
2017-04-05 19:38                 ` Alex Williamson
2017-04-05 21:50                   ` Michael S. Tsirkin
2017-04-05 22:19                     ` Alex Williamson
2017-04-05 22:36                       ` Michael S. Tsirkin
2017-04-05 22:56                         ` Alex Williamson
2017-04-06  8:53                         ` Cao jin [this message]
2017-04-06 15:35                           ` Alex Williamson
2017-04-06  8:49                   ` Cao jin
2017-04-05 21:56                 ` Michael S. Tsirkin
2017-04-06  8:49                   ` Cao jin
2017-04-06 15:31                     ` Alex Williamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58E60218.4040500@cn.fujitsu.com \
    --to=caoj.fnst@cn.fujitsu.com \
    --cc=alex.williamson@redhat.com \
    --cc=izumi.taku@jp.fujitsu.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox