From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754123AbdDNAn2 (ORCPT ); Thu, 13 Apr 2017 20:43:28 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:57283 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753296AbdDNAnZ (ORCPT ); Thu, 13 Apr 2017 20:43:25 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: b6c32a2d-f792a6d0000055a1-6a-58f01b2afae4 Content-transfer-encoding: 8BIT Message-id: <58F01B29.10304@samsung.com> Date: Fri, 14 Apr 2017 09:43:21 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Kishon Vijay Abraham I Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, chanwoo@kernel.org Subject: Re: [PATCH 1/2] phy: qcom-usb-hs: Replace the extcon API In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA02Se0hTcRTH++3ePenqbZYdZtm6UdZqa/e65TSVJImR/SFENHqwLnpTyW22 Oyvrj5QibRolltIwEnovabWeGpGux6QE7SUmsgI1LCkUewiltXkX9d/nnPM9v/M7X44MU06J VbIiu4tz2tliSqLA7zxaptFqEkYt+orgClNt72vc1D1UIzH5B3rEpletjZI1uNnvPSox3zx/ 0BzsvSsyj/sTc/EtXHohx+ZzTjVnz3PkF9kLMqicjda1VuMqPa2lU00plNrO2rgMKntDrnZd UXF4IqXewxaXhlO5LM9TKzPTnY5SF6cudPCuDGorTTM6Wp+iYxhGZ0jensYYw5IdXKHn8zWs pCFu3+TAN7wcBWLdSCYD0gBX2xPcSB7GeOgO+SRupJApyQsIHrQOIyGoFEF37yVMUBngS2cr LhQaEZwb+jFdIMhZMFEXwiOvYuQCePxyVySNkcvg9n2fVNCHEHSeakOCfilUNVzGI4yTi6G6 o14UYQmpgYfDvZIIx5IL4c3EwLR+DmmBlrPfpRGeHdY8b5nAhAHboNnrFkc4jsyClhvB6V45 mQaDw/3iyGAgj0uh6/RTkbDyfPC3RZfJhvaOa1GOg0/BW1KBE2DyQh8SeisR3GwM4UJQheDd lQqxoEqGd+9D0V/EwLGfg9EBBFQdUQoSMzSPjuACZ8GR72ei/nYgmOoZQyeQ2vOfeZ5/5nn+ M68JYV4Uz5XwtgKON5YwOp618aX2Al2ew+ZH07en0d5DX5tyAoiUIWomYRaPWpRidg9fZgsg kGHUbCJOEU4R+WzZfs7psDpLizk+gIxh72sx1Zw8R/iS7S4rbUjVG4yrkvXJtCmVmkskXemx KMkC1sXt4rgSzvm3TySTq8rRHbJjoO/QAabG/XtTfP32nMTl8syXm6vn7c3/hWfSg69mjL8O BYYO71MUYT/it6x/kjTiHeu3/ErSSivejnadVIdSRENMkhWVqVJ3Zj47/I32jL0wEhYf88w3 4Qt+hFtL+h4u+tCy+pP6ejPxpra/rr8ppuliBiLW55TLFbs3UzhfyNIazMmzfwCWROWakQMA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFIsWRmVeSWpSXmKPExsVy+t9jQV0t6Q8RBsd/CVtMvHGFxeLC0x42 i02Pr7FaXN41h82BxWPTqk42j81L6j2O39jO5PF5k1wAS5SbTUZqYkpqkUJqXnJ+SmZeuq1S aIibroWSQl5ibqqtUoSub0iQkkJZYk4pkGdkgAYcnAPcg5X07RLcMma9XcdcMF244u/jrywN jIf4uxg5OSQETCTendnFAmGLSVy4t56ti5GLQ0hgFqPEnql9TCAJXgFBiR+T7wEVcXAwC8hL HLmUDRJmFlCXmDRvETNE/QNGiSU3fkPVa0h0TF8BNpRFQFWi+8Q0sDibgJbE/hc32EBsfgFF ias/HjOCzBQViACqqQQJiwCVnN75gxlifoxE64SpYK3CAo4SOzceh7rtFKPEocMQt3EKWEk8 eXGHdQKj4Cwkp85COHUWklMXMDKvYpRILUguKE5KzzXKSy3XK07MLS7NS9dLzs/dxAiOp2fS OxgP73I/xCjAwajEwxtR+z5CiDWxrLgy9xCjBAezkgivMNeHCCHelMTKqtSi/Pii0pzU4kOM pkC/TmSWEk3OB8Z6Xkm8oYm5ibmxgYW5paWJkZI4b+PsZ+FCAumJJanZqakFqUUwfUwcnFIN jAGXtj16frw0J3/aSv74Ps/uex1V7OrmGrs6PjX2pluVtt7for0tXYhhRWj1af3Ep5cmnDU7 WujDzlo5v+GHRPntv1uX+Dmxt1w1snJzT/cuW+Dxg7vRJIPlz9eMRS84ymqVtGzY36l8suL4 vui61TUGjqkG/ftVee4J8K2o33d/cqCya/heJZbijERDLeai4kQAsas2jL0CAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170414004322epcas5p3f3ac4e60517e9ee30799de0be18f474e X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?7LWc7LCs7JqwG1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbU2VuaW9yIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?Q2hhbndvbyBDaG9pG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtTZW5pb3IgRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG1NUQUYbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-HopCount: 7 X-CMS-RootMailID: 20170328043830epcas1p4069bda461ad648cfd6598905b7167e9f X-RootMTR: 20170328043830epcas1p4069bda461ad648cfd6598905b7167e9f References: <1490675909-2533-1-git-send-email-cw00.choi@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kishon, On 2017년 04월 13일 20:47, Kishon Vijay Abraham I wrote: > Hi Chanwoo, > > On Tuesday 28 March 2017 10:08 AM, Chanwoo Choi wrote: >> This patch uses the resource-managed extcon API for extcon_register_notifier() >> and replaces the deprecated extcon API as following: >> - (deprecated) extcon_get_cable_state_() -> extcon_get_state() >> >> Cc: Kishon Vijay Abraham I >> Signed-off-by: Chanwoo Choi > > I've missed merging this patch for the next merge window. If you want to take > this yourself. > Acked-by: Kishon Vijay Abraham I I already posted the pull-request to GregKH for extcon subsystem. So, if possible, I hope you handle these patches. Even if these patches are not merged to 4.12-rc1, I'm ok. Just I want to handle them on your tree for next time. > > Thanks > Kishon >> --- >> drivers/phy/phy-qcom-usb-hs.c | 14 +++----------- >> 1 file changed, 3 insertions(+), 11 deletions(-) >> >> diff --git a/drivers/phy/phy-qcom-usb-hs.c b/drivers/phy/phy-qcom-usb-hs.c >> index 94dfbfd739c3..f630fa553b7d 100644 >> --- a/drivers/phy/phy-qcom-usb-hs.c >> +++ b/drivers/phy/phy-qcom-usb-hs.c >> @@ -156,12 +156,12 @@ static int qcom_usb_hs_phy_power_on(struct phy *phy) >> } >> >> if (uphy->vbus_edev) { >> - state = extcon_get_cable_state_(uphy->vbus_edev, EXTCON_USB); >> + state = extcon_get_state(uphy->vbus_edev, EXTCON_USB); >> /* setup initial state */ >> qcom_usb_hs_phy_vbus_notifier(&uphy->vbus_notify, state, >> uphy->vbus_edev); >> - ret = extcon_register_notifier(uphy->vbus_edev, EXTCON_USB, >> - &uphy->vbus_notify); >> + ret = devm_extcon_register_notifier(&ulpi->dev, uphy->vbus_edev, >> + EXTCON_USB, &uphy->vbus_notify); >> if (ret) >> goto err_ulpi; >> } >> @@ -180,16 +180,8 @@ static int qcom_usb_hs_phy_power_on(struct phy *phy) >> >> static int qcom_usb_hs_phy_power_off(struct phy *phy) >> { >> - int ret; >> struct qcom_usb_hs_phy *uphy = phy_get_drvdata(phy); >> >> - if (uphy->vbus_edev) { >> - ret = extcon_unregister_notifier(uphy->vbus_edev, EXTCON_USB, >> - &uphy->vbus_notify); >> - if (ret) >> - return ret; >> - } >> - >> regulator_disable(uphy->v3p3); >> regulator_disable(uphy->v1p8); >> clk_disable_unprepare(uphy->sleep_clk); >> > > > -- Best Regards, Chanwoo Choi Samsung Electronics