From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.23 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794993721; b=u7RUskNKYsiGhJYW9rUhkJJ2e4mEf9iyz0Zx02ZPXA7Ebys+DCC7uiLCmMNaw1SZTfAA znzE/nyo6rvk8Tl5lcVfOAAHQi5r8Xjac/eB7Ol8LHeFoNq3HXJvsLeEq9k5U0UxZWNpW W/uPnSOsvRqkJRMu9EgPY83Ums+2X44ry+a1jm9Jwjpb5UTs7sd21edIJZ07QbkNv/zYk ByPh8X/VWDMOmPUTq1AgA2BLj4GuxyUzHKFk2rWYqx1W66m4WGCoH03wecGHGGYLRgc1O 59Q98bEGsvpsB8YVtMe4xGxbgFaByk+hmrIPaQk5EDJ+k7PYFjF2NSDfxEcvWEPqgaA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794993721; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=gzIfQo+V40+G/VauJiKWlPuxA1l3b/hPJPpuHDGZsmA=; b=C17PF9BSFwizokOEN87Iip295yI4ZEF9smLx0MFJcqezwNJg6S0+x2g9OVKu6miKtQIG +fs8H+Xboq1npxs5tHTqOWIjIOU0SnBbr7QgNwjWW7OQ3K7Ld/a2zNQmfVF+p3J049BO7 Cul6jSHbpK6VHrrNIcQfvL8UL/JaG2Rwg8bwd2xhG9wsPyo2MxM7z5o8jXlJLjl8BI3DQ NWPsr7yUqqvAa/IwHDm0mjT4KKOX85SbnW+z6rVtXjsEeyVX4wFd1wBOOKXFLhkg3AfYj 0kpROLCDAWAdi8xvAd/1llzmmbWXwPnNFlT+KfhHHINdeXD0iUxjfajDnjbxiUH4OEw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=p3VRkYAW; arc=none smtp.remote-ip=91.218.175.23 Received: from mta0.migadu.com (out-23.mta0.migadu.com [91.218.175.23]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87F35606A325 for ; Wed, 18 Nov 2026 09:22:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 87F35606A325 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=p3VRkYAW X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=aApfAP319qtaqrvPZcix/c+LpziV/0GztArdiAixTSw=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794993718; v=1; x=1795598518; b=p3VRkYAWRP8IDP0E6kljvYhfMeZnH9VwOYpDlc2BgQ6PYyKc22Ce1z2G3dI832BwHQ6c0wMT /hbHINBoBMnIlWApxMJk5WrYg5SbgGB/r7MpAooSGnCKH00rAx0K8iSlqKMYwjVgul8phLsALN/ nDy1G4tzQ8pFV2Dw2H4rSrP8= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 368022f8a7a724ec; Wed, 18 Nov 2026 09:21:58 +0000 X-Mizu-Trace-ID: 368022f8a7a724ec X-Migadu-Flow: FLOW_OUT Message-ID: <58a7a7fa-500d-467a-840f-fedb59a73e52@linux.dev> Date: Wed, 18 Nov 2026 17:21:53 +0800 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 01/12] cpuset: introduce partition_enable() To: Ridong Chen , Waiman Long , Tejun Heo , Johannes Weiner , =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: Guopeng Zhang , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Ridong Chen References: <20261114083124.1340140-1-ridong.chen@linux.dev> <20261114083124.1340140-2-ridong.chen@linux.dev> Content-Language: en-US From: Guopeng Zhang In-Reply-To: <20261114083124.1340140-2-ridong.chen@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 在 2026/11/14 16:31, Ridong Chen 写道: > From: Ridong Chen > > Add partition_enable() to consolidate updates to key cpuset structures > during partition enablement, including: > 1. remote_partition > 2. effective_xcpus > 3. partition_root_state > 4. prs_err > > Key operations performed: > 1. Invokes partition_xcpus_add() to assign exclusive CPUs > 2. Maintains remote partition flag > 3. Syncs the effective_xcpus mask > 4. Updates partition_root_state and prs_err > 5. Triggers scheduler domain rebuilds > 6. Sends partition change notifications > > This helper also handles the transition between root and isolated > states of a valid partition. In that case the cpumasks are unchanged > and only the isolation state of the CPUs in @new_excpus is updated. The > caller passes the CPUs used by the partition itself, as the CPUs of its > valid child partitions keep their own state. > > A partition_state_update() helper is added to set partition_root_state > and prs_err, and to reset the partition data when the new state is not > a valid partition. > > Signed-off-by: Ridong Chen > --- > kernel/cgroup/cpuset.c | 56 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > index 7e374210c123..860cb7ea3efb 100644 > --- a/kernel/cgroup/cpuset.c > +++ b/kernel/cgroup/cpuset.c > @@ -1702,6 +1702,62 @@ static void compute_effective_nodemask(nodemask_t *new_mems, > nodes_copy(*new_mems, parent->effective_mems); > } > > +static void partition_state_update(struct cpuset *cs, int new_prs, > + enum prs_errcode prs_err) > +{ > + lockdep_assert_held(&callback_lock); > + > + cs->partition_root_state = new_prs; > + WRITE_ONCE(cs->prs_err, prs_err); > + if (!is_partition_valid(cs)) > + reset_partition_data(cs); > +} > + > +/** > + * partition_enable - Transitions a cpuset to a partition root > + * @cs: The cpuset to enable partition for > + * @parent: Parent cpuset of @cs, NULL for remote parent > + * @new_prs: New partition state to set > + * @new_excpus: New effective exclusive CPUs mask for the partition, or the > + * CPUs whose isolation state changes when switching between > + * root and isolated > + * > + * Transitions a cpuset to a partition root, only for v2. > + * It also supports the transition between root and isolated partition. > + */ > +static void __maybe_unused partition_enable(struct cpuset *cs, struct cpuset *parent, > + int new_prs, struct cpumask *new_excpus) > +{ > + int old_prs = cs->partition_root_state; > + > + lockdep_assert_cpuset_lock_held(); > + WARN_ON_ONCE(new_prs <= 0); > + WARN_ON_ONCE(!cpuset_v2()); > + > + if (old_prs == new_prs) > + return; > + > + spin_lock_irq(&callback_lock); > + if (old_prs > 0) { > + /* > + * Switch between root and isolated, cpumasks are unchanged. > + * @new_excpus holds the CPUs whose isolation state changes. > + */ > + isolated_cpus_update(new_prs, new_excpus); > + } else { > + /* enable partition should only add exclusive cpus */ > + partition_xcpus_add(new_prs, parent, new_excpus); > + /* enable remote partition */ > + if (!parent) > + cs->remote_partition = true; > + cpumask_copy(cs->effective_xcpus, new_excpus); > + } > + partition_state_update(cs, new_prs, PERR_NONE); > + spin_unlock_irq(&callback_lock); > + cpuset_force_rebuild(); > + notify_partition_change(cs, old_prs); > +} > + Hi Ridong, I haven't found any functional issues with this patch, and I think the overall direction of the refactoring is good. I just had a thought of my own and wanted to hear what you think. Currently, partition_enable() handles two different operations: enabling a partition and switching a valid partition between root and isolated. As a result, new_excpus has two different meanings depending on old_prs. Looking at the callers introduced in patches 4/12, 8/12, and 11/12, they all use partition_enable() to enable a previously non-valid partition. None of them seems to need the old_prs > 0 branch. I understand that this branch may be intended for the follow-up refactoring of update_prstate(), since partition_switch() introduced in v4 also calls partition_enable(). However, could we consider keeping partition_enable() focused solely on enabling partitions, so that new_excpus always has a single meaning? The root/isolated transition could remain in update_prstate() for now and be handled separately when update_prstate() is simplified later, perhaps through partition_switch(), or by introducing another function such as partition_set_isolation(), or some other more suitable approach. If I've misunderstood anything or overlooked a reason for keeping these two operations together, please let me know. Thanks, and all the best! Best regards, Guopeng > /* > * remote_partition_enable - Enable current cpuset as a remote partition root > * @cs: the cpuset to update