From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCE6AC7618E for ; Sun, 23 Apr 2023 02:56:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230151AbjDWC4n (ORCPT ); Sat, 22 Apr 2023 22:56:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229556AbjDWC4l (ORCPT ); Sat, 22 Apr 2023 22:56:41 -0400 Received: from out-23.mta1.migadu.com (out-23.mta1.migadu.com [IPv6:2001:41d0:203:375::17]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33A9B2136 for ; Sat, 22 Apr 2023 19:56:40 -0700 (PDT) Message-ID: <58a984d3-a89d-89d4-2491-a559bc8b1076@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1682218598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0dgL3xDEkr6o6FRjE7kxu44l06Ma5AgulZJtHgzYbLM=; b=Q7m1T9YsWl4Y5ORRjicXCwxB8qgnMV8rW0ao/MMqnGtjS/1xpC04DP0cpOg/8PZWz6HR9e aqaE9qWi/pMPNbDmkT56zCKn0NGohsQj1+mLYtklDWTJT0dhfomnfGm2xzsAwpNIpr2g3U od8Oirq5s7ybLp19iol11dEW46qadf0= Date: Sun, 23 Apr 2023 10:56:30 +0800 MIME-Version: 1.0 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Guoqing Jiang Subject: Re: [PATCH for-next v2 2/3] RDMA/rtrs: Fix the last iu->buf leak in err path To: Li Zhijian , haris.iqbal@ionos.com, jinpu.wang@ionos.com, jgg@ziepe.ca, leon@kernel.org, linux-rdma@vger.kernel.org Cc: linux-kernel@vger.kernel.org References: <1682213212-2-1-git-send-email-lizhijian@fujitsu.com> <1682213212-2-3-git-send-email-lizhijian@fujitsu.com> Content-Language: en-US In-Reply-To: <1682213212-2-3-git-send-email-lizhijian@fujitsu.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/23/23 09:26, Li Zhijian wrote: > The last iu->buf will leak if ib_dma_mapping_error() fails. Fixes: c0894b3ea69d("RDMA/rtrs: core: lib functions shared between client and server modules") > Signed-off-by: Li Zhijian > --- > V2: new patch to address memory leaking > --- > drivers/infiniband/ulp/rtrs/rtrs.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/infiniband/ulp/rtrs/rtrs.c b/drivers/infiniband/ulp/rtrs/rtrs.c > index 4bf9d868cc52..3696f367ff51 100644 > --- a/drivers/infiniband/ulp/rtrs/rtrs.c > +++ b/drivers/infiniband/ulp/rtrs/rtrs.c > @@ -37,8 +37,10 @@ struct rtrs_iu *rtrs_iu_alloc(u32 iu_num, size_t size, gfp_t gfp_mask, > goto err; > > iu->dma_addr = ib_dma_map_single(dma_dev, iu->buf, size, dir); > - if (ib_dma_mapping_error(dma_dev, iu->dma_addr)) > + if (ib_dma_mapping_error(dma_dev, iu->dma_addr)) { > + kfree(iu->buf); > goto err; > + } > > iu->cqe.done = done; > iu->size = size; Good catch, Acked-by: Guoqing Jiang Thanks, Guoqing